[binutils-gdb/gdb-8.0-branch] PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

[binutils-gdb/gdb-8.0-branch] PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT c247e38d78a98f85066e4a61032ee742d08a0579 ***

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Branch: gdb-8.0-branch
Commit: c247e38d78a98f85066e4a61032ee742d08a0579

PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

On <=RHEL6 hosts Fedora/RHEL GDB started to 'kill -STOP' all processes it
detached.  Even those not originally T-stopped.  This is a Fedora-specific
patch which is based on upstream GDB's PROC_STATE_STOPPED state.

I believe (I did not verify) this patch did regress it:
commit d617208bb06bd461b52ce041d89f7127e3044762
Author: Pedro Alves <palves@redhat.com>
Date:   Mon Jul 25 12:42:17 2016 +0100
    linux-procfs: Introduce enum proc_state

As originally there was strstr() but now there is strcmp() and so the missing
trailing '\n' no longer matches.

The Bug was found by Michal Kolar.

Reproducibility:
$ gdb -p $PID
(gdb) quit
$ ...

Actual results:
===
RHEL6.9 x86_64 # scl enable devtoolset-7 bash
RHEL6.9 x86_64 # which gdb
/opt/rh/devtoolset-7/root/usr/bin/gdb
RHEL6.9 x86_64 # ./testcase.sh
24737 pts/0    S+     0:00 /bin/sleep 4
24737 pts/0    T+     0:00 /bin/sleep 4
RHEL6.9 x86_64 #
===

Expected results:
===
RHEL6.9 x86_64 # which gdb
/usr/bin/gdb
RHEL6.9 x86_64 # ./testcase.sh
24708 pts/0    S+     0:00 /bin/sleep 4
24708 pts/0    S+     0:00 /bin/sleep 4
./testcase.sh: line 20: kill: (24708) - No such process
RHEL6.9 x86_64 #
===

gdb/ChangeLog
2017-09-01  Jan Kratochvil  <jan.kratochvil@redhat.com>

	PR gdb/22046
	* nat/linux-procfs.c (parse_proc_status_state): Fix PROC_STATE_STOPPED
	detection.

Failures on Fedora-s390x-m64, branch gdb-8.0-branch

[sergiodj+buildbot]

Buildslave:
	marist-fedora-s390x

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-s390x-m64/builds/6028>

Commit(s) tested:
	c247e38d78a98f85066e4a61032ee742d08a0579

Author(s) (in the same order as the commits):
	Jan Kratochvil <jan.kratochvil@redhat.com>

Subject:
	PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-s390x-m64/c2/c247e38d78a98f85066e4a61032ee742d08a0579/>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=10: wait for stops
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Ubuntu-AArch64-native-gdbserver-m64, branch gdb-8.0-branch

[sergiodj+buildbot]

Buildslave:
	ubuntu-aarch64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-native-gdbserver-m64/builds/2615>

Commit(s) tested:
	c247e38d78a98f85066e4a61032ee742d08a0579

Author(s) (in the same order as the commits):
	Jan Kratochvil <jan.kratochvil@redhat.com>

Subject:
	PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch64-native-gdbserver-m64/c2/c247e38d78a98f85066e4a61032ee742d08a0579/>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=8: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=16: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=19: wait for stops
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch gdb-8.0-branch

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-extended-gdbserver-m32/builds/1246>

Commit(s) tested:
	c247e38d78a98f85066e4a61032ee742d08a0579

Author(s) (in the same order as the commits):
	Jan Kratochvil <jan.kratochvil@redhat.com>

Subject:
	PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-extended-gdbserver-m32/c2/c247e38d78a98f85066e4a61032ee742d08a0579/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.mi/mi-var-rtti.exp: run to mi-var-rtti.cc:250
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=15: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=19: wait for stops
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Ubuntu-AArch32-native-gdbserver-m32, branch gdb-8.0-branch

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/1236>

Commit(s) tested:
	c247e38d78a98f85066e4a61032ee742d08a0579

Author(s) (in the same order as the commits):
	Jan Kratochvil <jan.kratochvil@redhat.com>

Subject:
	PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/c2/c247e38d78a98f85066e4a61032ee742d08a0579/>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=3: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=8: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=10: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=11: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=13: wait for stops
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Ubuntu-AArch64-m64, branch gdb-8.0-branch

[sergiodj+buildbot]

Buildslave:
	ubuntu-aarch64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-m64/builds/2624>

Commit(s) tested:
	c247e38d78a98f85066e4a61032ee742d08a0579

Author(s) (in the same order as the commits):
	Jan Kratochvil <jan.kratochvil@redhat.com>

Subject:
	PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch64-m64/c2/c247e38d78a98f85066e4a61032ee742d08a0579/>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=2: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=6: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=7: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=9: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=10: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=12: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=13: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=14: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=15: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=16: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=17: wait for stops
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Fedora-x86_64-m32, branch gdb-8.0-branch

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/6946>

Commit(s) tested:
	c247e38d78a98f85066e4a61032ee742d08a0579

Author(s) (in the same order as the commits):
	Jan Kratochvil <jan.kratochvil@redhat.com>

Subject:
	PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m32/c2/c247e38d78a98f85066e4a61032ee742d08a0579/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.ada/win_fu_syms.exp: compilation foo.adb
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: next: setup: continue to breakpoint: run to breakpoint in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: next: setup: unbreak loop in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: next: next
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr1: setup: continue to breakpoint: run to breakpoint in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr1: setup: unbreak loop in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr1: setup: continue to breakpoint: run to breakpoint in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr1: setup: unbreak loop in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr1: continue to sigusr1_handler
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr3: setup: continue to breakpoint: run to breakpoint in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr3: setup: unbreak loop in thread 2
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Ubuntu-AArch32-m32, branch gdb-8.0-branch

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-m32/builds/1246>

Commit(s) tested:
	c247e38d78a98f85066e4a61032ee742d08a0579

Author(s) (in the same order as the commits):
	Jan Kratochvil <jan.kratochvil@redhat.com>

Subject:
	PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-m32/c2/c247e38d78a98f85066e4a61032ee742d08a0579/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/step-over-syscall.exp: clone: displaced=off: single step over clone
PASS -> FAIL: gdb.mi/mi-var-rtti.exp: run to mi-var-rtti.cc:250
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=12: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=18: wait for stops
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch gdb-8.0-branch

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m32/builds/6935>

Commit(s) tested:
	c247e38d78a98f85066e4a61032ee742d08a0579

Author(s) (in the same order as the commits):
	Jan Kratochvil <jan.kratochvil@redhat.com>

Subject:
	PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m32/c2/c247e38d78a98f85066e4a61032ee742d08a0579/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr3: setup: continue to breakpoint: run to breakpoint in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr3: setup: unbreak loop in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr3: continue to sigusr1_handler
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Fedora-x86_64-m64, branch gdb-8.0-branch

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/6982>

Commit(s) tested:
	c247e38d78a98f85066e4a61032ee742d08a0579

Author(s) (in the same order as the commits):
	Jan Kratochvil <jan.kratochvil@redhat.com>

Subject:
	PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m64/c2/c247e38d78a98f85066e4a61032ee742d08a0579/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/process-dies-while-detaching.exp: single-process: continue: detach: continue
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Fedora-i686, branch gdb-8.0-branch

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-2

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/6964>

Commit(s) tested:
	c247e38d78a98f85066e4a61032ee742d08a0579

Author(s) (in the same order as the commits):
	Jan Kratochvil <jan.kratochvil@redhat.com>

Subject:
	PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-i686/c2/c247e38d78a98f85066e4a61032ee742d08a0579/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: step: setup: continue to breakpoint: run to breakpoint in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: step: setup: unbreak loop in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr1: setup: continue to breakpoint: run to breakpoint in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr1: setup: unbreak loop in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr1: continue to sigusr1_handler
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Fedora-x86_64-cc-with-index, branch gdb-8.0-branch

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/6903>

Commit(s) tested:
	c247e38d78a98f85066e4a61032ee742d08a0579

Author(s) (in the same order as the commits):
	Jan Kratochvil <jan.kratochvil@redhat.com>

Subject:
	PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/c2/c247e38d78a98f85066e4a61032ee742d08a0579/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 1: attach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 1: no new threads
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 1: set breakpoint always-inserted on
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 1: break break_fn
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 1: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 1: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 1: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 1: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 1: print seconds_left
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 1: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 1: set breakpoint always-inserted off
new FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 1: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.threads/process-dies-while-detaching.exp: single-process: continue: watchpoint: continue
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Fedora-x86_64-native-gdbserver-m32, branch gdb-8.0-branch

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m32/builds/6931>

Commit(s) tested:
	c247e38d78a98f85066e4a61032ee742d08a0579

Author(s) (in the same order as the commits):
	Jan Kratochvil <jan.kratochvil@redhat.com>

Subject:
	PR gdb/22046: Fix T-stopped detach regression on old Linux kernels

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m32/c2/c247e38d78a98f85066e4a61032ee742d08a0579/>