public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Pass aarch64_debug_reg_state to functions
@ 2015-07-17 14:57 sergiodj+buildbot
  2015-07-17 14:57 ` Failures on AIX-POWER7-plain, branch master sergiodj+buildbot
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: sergiodj+buildbot @ 2015-07-17 14:57 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c67ca4de63fb3018a7e21ec4afe709d4c0dd52c4 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: c67ca4de63fb3018a7e21ec4afe709d4c0dd52c4

Pass aarch64_debug_reg_state to functions
Some functions on handling HW watchpoint in GDB and GDBserver looks the
same except the code getting debug register state from current inferior.
In GDB, we get debug register state like this:

  state = aarch64_get_debug_reg_state (ptid_get_pid (inferior_ptid));

while in GDBserver, we get debug register state like this:

  state = aarch64_get_debug_reg_state ();

This patch is to move two lines above out of some functions, and pass
aarch64_debug_reg_state to these functions, in this way, these functions
are the same, and can be moved to a common place.

gdb:

2015-07-17  Yao Qi  <yao.qi@linaro.org>

	* aarch64-linux-nat.c (aarch64_handle_breakpoint): Add argument
	state and don't call aarch64_get_debug_reg_state.  All callers
	update.
	(aarch64_linux_insert_hw_breakpoint): Call
	aarch64_get_debug_reg_state earlier.
	(aarch64_linux_remove_hw_breakpoint): Likewise.
	(aarch64_handle_aligned_watchpoint): Add argument state and
	don't call aarch64_get_debug_reg_state.  All callers update.
	(aarch64_handle_unaligned_watchpoint): Likewise.
	(aarch64_handle_watchpoint): Add argument state.
	(aarch64_linux_insert_watchpoint): Call aarch64_get_debug_reg_state
	earlier.
	(aarch64_linux_remove_watchpoint): Likewise.

gdb/gdbserver:

2015-07-17  Yao Qi  <yao.qi@linaro.org>

	* linux-aarch64-low.c (aarch64_handle_breakpoint): Add argument state
	and don't aarch64_get_debug_reg_state.  All callers update.
	(aarch64_handle_aligned_watchpoint): Likewise.
	(aarch64_handle_unaligned_watchpoint): Likewise.
	(aarch64_handle_watchpoint): Likewise.
	(aarch64_insert_point): Call aarch64_get_debug_reg_state earlier.
	(aarch64_remove_point): Likewise.


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2015-07-19  5:40 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-17 14:57 [binutils-gdb] Pass aarch64_debug_reg_state to functions sergiodj+buildbot
2015-07-17 14:57 ` Failures on AIX-POWER7-plain, branch master sergiodj+buildbot
2015-07-17 15:08 ` Failures on Fedora-i686, " sergiodj+buildbot
2015-07-17 15:10 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2015-07-17 15:15 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2015-07-17 15:20 ` Failures on Fedora-s390x-m64, " sergiodj+buildbot
2015-07-17 15:26 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2015-07-17 17:04 ` Failures on Debian-i686, " sergiodj+buildbot
2015-07-17 17:21 ` Failures on Debian-i686-native-gdbserver, " sergiodj+buildbot
2015-07-17 17:47 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot
2015-07-17 18:45 ` Failures on Fedora-ppc64be-m64, " sergiodj+buildbot
2015-07-17 19:01 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot
2015-07-17 21:16 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot
2015-07-17 22:34 ` Failures on Debian-x86_64-m64, " sergiodj+buildbot
2015-07-19  5:40 ` Failures on Debian-MIPS-m64, " sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).