public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Improve some comments about msymbol handling
@ 2019-10-01  5:24 gdb-buildbot
  2019-10-01  5:25 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: gdb-buildbot @ 2019-10-01  5:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT c7ee338a2dc3570c830e6897940f3955c5f632b2 ***

commit c7ee338a2dc3570c830e6897940f3955c5f632b2
Author:     Christian Biesinger <cbiesinger@google.com>
AuthorDate: Sun Sep 29 20:15:38 2019 -0500
Commit:     Christian Biesinger <cbiesinger@google.com>
CommitDate: Mon Sep 30 11:21:46 2019 -0500

    Improve some comments about msymbol handling
    
    This just clarifies some comments about the hashtables involved
    in msymbols.
    
    gdb/ChangeLog:
    
    2019-09-29  Christian Biesinger  <cbiesinger@google.com>
    
            * minsyms.h (msymbol_hash): Document that this is a case-insensitive
            hash and why.
            * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
            msymbol_hash, msymbol_demangled_hash>: Improve comments.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 89859ef1df..faac59d255 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2019-09-29  Christian Biesinger  <cbiesinger@google.com>
+
+	* minsyms.h (msymbol_hash): Document that this is a case-insensitive
+	hash and why.
+	* objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
+	msymbol_hash, msymbol_demangled_hash>: Improve comments.
+
 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 
 	* psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
diff --git a/gdb/minsyms.h b/gdb/minsyms.h
index bb43165620..ce4b83d544 100644
--- a/gdb/minsyms.h
+++ b/gdb/minsyms.h
@@ -159,7 +159,8 @@ bool msymbol_is_function (struct objfile *objfile,
 			  minimal_symbol *minsym,
 			  CORE_ADDR *func_address_p = NULL);
 
-/* Compute a hash code for the string argument.  */
+/* Compute a hash code for the string argument.  Unlike htab_hash_string,
+   this is a case-insensitive hash to support "set case-sensitive off".  */
 
 unsigned int msymbol_hash (const char *);
 
diff --git a/gdb/objfiles.h b/gdb/objfiles.h
index 68d36d408e..dbd06c01e2 100644
--- a/gdb/objfiles.h
+++ b/gdb/objfiles.h
@@ -258,10 +258,10 @@ struct objfile_per_bfd_storage
   struct gdbarch *gdbarch = NULL;
 
   /* Hash table for mapping symbol names to demangled names.  Each
-     entry in the hash table is actually two consecutive strings,
-     both null-terminated; the first one is a mangled or linkage
-     name, and the second is the demangled name or just a zero byte
-     if the name doesn't demangle.  */
+     entry in the hash table is a demangled_name_entry struct, storing the
+     language and two consecutive strings, both null-terminated; the first one
+     is a mangled or linkage name, and the second is the demangled name or just
+     a zero byte if the name doesn't demangle.  */
 
   htab_up demangled_names_hash;
 
@@ -305,12 +305,14 @@ struct objfile_per_bfd_storage
 
   bool minsyms_read : 1;
 
-  /* This is a hash table used to index the minimal symbols by name.  */
+  /* This is a hash table used to index the minimal symbols by (mangled)
+     name.  */
 
   minimal_symbol *msymbol_hash[MINIMAL_SYMBOL_HASH_SIZE] {};
 
   /* This hash table is used to index the minimal symbols by their
-     demangled names.  */
+     demangled names.  Uses a language-specific hash function via
+     search_name_hash.  */
 
   minimal_symbol *msymbol_demangled_hash[MINIMAL_SYMBOL_HASH_SIZE] {};
 


^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-10-04 16:56 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01  5:24 [binutils-gdb] Improve some comments about msymbol handling gdb-buildbot
2019-10-01  5:25 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
2019-10-01  7:53 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot
2019-10-04  9:09 ` *** COMPILATION FAILED *** Failures on Fedora-i686, branch master *** BREAKAGE *** gdb-buildbot
2019-10-04  9:35 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2019-10-04  9:35 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-m32, " gdb-buildbot
2019-10-04  9:39 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2019-10-04 10:06 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2019-10-04 10:06 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-m64, " gdb-buildbot
2019-10-04 10:32 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, " gdb-buildbot
2019-10-04 16:56 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master gdb-buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).