public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] s390: Fix gdb.base/all-architectures.exp with --enable-targets=all Date: Tue, 30 Jan 2018 16:50:00 -0000 [thread overview] Message-ID: <c81e88797907fc0698abec09767e49cee33b2bd5@gdb-build> (raw) *** TEST RESULTS FOR COMMIT c81e88797907fc0698abec09767e49cee33b2bd5 *** Author: Philipp Rudo <prudo@linux.vnet.ibm.com> Branch: master Commit: c81e88797907fc0698abec09767e49cee33b2bd5 s390: Fix gdb.base/all-architectures.exp with --enable-targets=all With 7042632bf79 (s390: Hook s390 into OSABI mechanism) assigning a default target description was moved from s390_gdbarch_init to s390_linux_init_abi_*. This causes problems when GDB is built with --enable-targets=all and the user sets an unsupported OSABI, e.g. "set osabi AIX". In this case there is no valid tdesc, and GDB crashes with an internal error. Fix this by reverting parts of 7042632bf79. gdb/ChangeLog: * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and "features/s390x-linux64.c". (_initialize_s390_linux_tdep): Remove initialization of tdescs s390_linux32 and s390x_linux64. (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set default tdesc. * s390-tdep.c: Include "features/s390-linux32.c" and "features/s390x-linux64.c". (s390_tdesc_valid): Add check for tdesc_has_registers. (s390_gdbarch_init): Make sure there is always a valid tdesc. (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and tdesc_s390x_linux64. * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and tdesc_s390x_linux64 to... * s390-tdep.h: ...here.
next reply other threads:[~2018-01-30 16:50 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-30 16:50 sergiodj+buildbot [this message] 2018-01-30 16:50 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot 2018-01-30 17:23 ` Failures on Debian-s390x-m64, " sergiodj+buildbot 2018-01-30 17:29 ` Failures on Fedora-i686, " sergiodj+buildbot 2018-01-30 17:30 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot 2018-01-30 17:37 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot 2018-01-30 17:38 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot 2018-01-30 17:49 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot 2018-01-30 17:50 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot 2018-01-30 17:52 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot 2018-01-30 17:54 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot 2018-01-30 17:57 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot 2018-01-30 19:54 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot 2018-01-30 19:56 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot 2018-01-30 20:26 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot 2018-01-30 20:37 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c81e88797907fc0698abec09767e49cee33b2bd5@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).