public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Document and extend readline-bindable functions
Date: Mon, 25 Nov 2019 18:50:00 -0000	[thread overview]
Message-ID: <c86d74cc7d442414a62752187aa10f49f0ac0de7@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT c86d74cc7d442414a62752187aa10f49f0ac0de7 ***

commit c86d74cc7d442414a62752187aa10f49f0ac0de7
Author:     Tom Tromey <tom@tromey.com>
AuthorDate: Sat Nov 9 11:54:39 2019 -0700
Commit:     Tom Tromey <tom@tromey.com>
CommitDate: Mon Nov 11 16:58:30 2019 -0700

    Document and extend readline-bindable functions
    
    This adds readline-bindable function names to a few gdb functions that
    already had key bindings.  This lets users change the bindings.
    
    This also removes the gdb-command function.  Due to how this function
    is implemented, it doesn't make sense to allow binding it.
    
    Finally, this updates the documentation to reflect these changes.
    
    gdb/ChangeLog
    2019-11-11  Tom Tromey  <tom@tromey.com>
    
            * tui/tui.c (tui_initialize_readline): Add new bindable readline
            functions.
    
    gdb/doc/ChangeLog
    2019-11-11  Tom Tromey  <tom@tromey.com>
    
            * gdb.texinfo (TUI Keys): Document readline function names.
    
    Change-Id: I2233779b7aefe372f19bd03c8f325733c3385e72

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index edd3e9013b..e8104f3e7c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-11  Tom Tromey  <tom@tromey.com>
+
+	* tui/tui.c (tui_initialize_readline): Add new bindable readline
+	functions.
+
 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
 
 	* nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 3c77d4f8b7..0da4c9d839 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,7 @@
+2019-11-11  Tom Tromey  <tom@tromey.com>
+
+	* gdb.texinfo (TUI Keys): Document readline function names.
+
 2019-11-11  Tom Tromey  <tom@tromey.com>
 
 	* gdb.texinfo (Editing): Document operate-and-get-next.
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 05accca477..398167f9bb 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -27621,6 +27621,9 @@ its standard mode, writing on the terminal directly.  When reentering
 the TUI mode, control is given back to the curses windows.
 The screen is then refreshed.
 
+This key binding uses the bindable Readline function
+@code{tui-switch-mode}.
+
 @kindex C-x 1
 @item C-x 1
 Use a TUI layout with only one window.  The layout will
@@ -27629,6 +27632,9 @@ is not active, it will switch to the TUI mode.
 
 Think of this key binding as the Emacs @kbd{C-x 1} binding.
 
+This key binding uses the bindable Readline function
+@code{tui-delete-other-windows}.
+
 @kindex C-x 2
 @item C-x 2
 Use a TUI layout with at least two windows.  When the current
@@ -27638,6 +27644,9 @@ previous layout and the new one.
 
 Think of it as the Emacs @kbd{C-x 2} binding.
 
+This key binding uses the bindable Readline function
+@code{tui-change-windows}.
+
 @kindex C-x o
 @item C-x o
 Change the active window.  The TUI associates several key bindings
@@ -27646,10 +27655,16 @@ gives the focus to the next TUI window.
 
 Think of it as the Emacs @kbd{C-x o} binding.
 
+This key binding uses the bindable Readline function
+@code{tui-other-window}.
+
 @kindex C-x s
 @item C-x s
 Switch in and out of the TUI SingleKey mode that binds single
 keys to @value{GDBN} commands (@pxref{TUI Single Key Mode}).
+
+This key binding uses the bindable Readline function
+@code{next-keymap}.
 @end table
 
 The following key bindings only work in the TUI mode:
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index 1568351784..3f5ab415de 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -330,8 +330,10 @@ tui_initialize_readline (void)
   Keymap tui_ctlx_keymap;
 
   rl_add_defun ("tui-switch-mode", tui_rl_switch_mode, -1);
-  rl_add_defun ("gdb-command", tui_rl_command_key, -1);
   rl_add_defun ("next-keymap", tui_rl_next_keymap, -1);
+  rl_add_defun ("tui-delete-other-windows", tui_rl_delete_other_windows, -1);
+  rl_add_defun ("tui-change-windows", tui_rl_change_windows, -1);
+  rl_add_defun ("tui-other-window", tui_rl_other_window, -1);
 
   tui_keymap = rl_make_bare_keymap ();
 


             reply	other threads:[~2019-11-25 18:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 18:50 gdb-buildbot [this message]
2019-11-25 18:50 ` *** COMPILATION FAILED *** Failures on Fedora-i686, branch master *** BREAKAGE *** gdb-buildbot
2019-11-25 18:54 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2019-11-25 18:55 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-m32, " gdb-buildbot
2019-11-25 18:56 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-m64, " gdb-buildbot
2019-11-25 18:57 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2019-11-25 19:01 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2019-11-25 19:03 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2019-11-25 19:04 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, " gdb-buildbot
2019-11-25 19:06 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c86d74cc7d442414a62752187aa10f49f0ac0de7@gdb-build \
    --to=gdb-buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).