[binutils-gdb] Suppress the "unused function" warning for select_strerror_r

[binutils-gdb] Suppress the "unused function" warning for select_strerror_r

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT cb51113052d534b628c635ac7b86b95fe436d60d ***

commit cb51113052d534b628c635ac7b86b95fe436d60d
Author:     Christian Biesinger <cbiesinger@google.com>
AuthorDate: Tue Dec 10 13:42:40 2019 -0600
Commit:     Christian Biesinger <cbiesinger@google.com>
CommitDate: Tue Dec 10 13:44:21 2019 -0600

    Suppress the "unused function" warning for select_strerror_r
    
    We only ever use one of the two overloads, so to avoid breaking -Werror
    builds, supress the warning.
    
    gdb/ChangeLog:
    
    2019-12-10  Christian Biesinger  <cbiesinger@google.com>
    
            * gdbsupport/safe-strerror.c: Supress the unused function warning
            for select_strerror_r.
    
    Change-Id: I344869a382bb36fe181b5b2a31838d1d20f58169

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a6e299d905..c4e8109b7c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-12-10  Christian Biesinger  <cbiesinger@google.com>
+
+	* gdbsupport/safe-strerror.c: Supress the unused function warning
+	for select_strerror_r.
+
 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 
 	* config.in: Regenerate.
diff --git a/gdb/gdbsupport/safe-strerror.c b/gdb/gdbsupport/safe-strerror.c
index 7425af590f..9973fa6785 100644
--- a/gdb/gdbsupport/safe-strerror.c
+++ b/gdb/gdbsupport/safe-strerror.c
@@ -18,6 +18,7 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "common-defs.h"
+#include "diagnostics.h"
 #include <string.h>
 
 /* There are two different versions of strerror_r; one is GNU-specific, the
@@ -26,6 +27,11 @@
    to solve this for us because IPA does not use Gnulib but uses this
    function.  */
 
+/* We only ever use one of the two overloads, so suppress the warning for
+   an unused function.  */
+DIAGNOSTIC_PUSH
+DIAGNOSTIC_IGNORE_UNUSED_FUNCTION
+
 /* Called if we have a XSI-compliant strerror_r.  */
 static char *
 select_strerror_r (int res, char *buf)
@@ -40,6 +46,8 @@ select_strerror_r (char *res, char *)
   return res;
 }
 
+DIAGNOSTIC_POP
+
 /* Implementation of safe_strerror as defined in common-utils.h.  */
 
 const char *

Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-native-extended-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/5/builds/1344

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        cb51113052d534b628c635ac7b86b95fe436d60d

Subject of commit:
        Suppress the "unused function" warning for select_strerror_r

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/cb/cb51113052d534b628c635ac7b86b95fe436d60d/

*** Diff to previous build ***
==============================================
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
PASS -> UNRESOLVED: gdb.threads/killed.exp: GDB exits after multi-threaded program exits messily
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/cb/cb51113052d534b628c635ac7b86b95fe436d60d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/cb/cb51113052d534b628c635ac7b86b95fe436d60d//xfail.table.gz>

Failures on Fedora-i686, branch master

[gdb-buildbot]

Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/18/builds/1481

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        cb51113052d534b628c635ac7b86b95fe436d60d

Subject of commit:
        Suppress the "unused function" warning for select_strerror_r

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/cb/cb51113052d534b628c635ac7b86b95fe436d60d/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/catch-syscall.exp: multiple targets: insert catch syscall on syscall 1 -- write on i386:x86-64
PASS -> FAIL: gdb.base/step-over-syscall.exp: clone: displaced=off: single step over clone
new KFAIL: gdb.xml/tdesc-arch.exp: set tdesc filename tdesc-arch.xml
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/cb/cb51113052d534b628c635ac7b86b95fe436d60d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/cb/cb51113052d534b628c635ac7b86b95fe436d60d//xfail.table.gz>

Failures on Ubuntu-Aarch64-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/8/builds/1352

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        cb51113052d534b628c635ac7b86b95fe436d60d

Subject of commit:
        Suppress the "unused function" warning for select_strerror_r

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/cb/cb51113052d534b628c635ac7b86b95fe436d60d/

*** Diff to previous build ***
==============================================
new KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/cb/cb51113052d534b628c635ac7b86b95fe436d60d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/cb/cb51113052d534b628c635ac7b86b95fe436d60d//xfail.table.gz>

Failures on Fedora-x86_64-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/3/builds/1538

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        cb51113052d534b628c635ac7b86b95fe436d60d

Subject of commit:
        Suppress the "unused function" warning for select_strerror_r

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/cb/cb51113052d534b628c635ac7b86b95fe436d60d/

*** Diff to previous build ***
==============================================
PASS -> UNRESOLVED: gdb.mi/user-selected-context-sync.exp: mode=non-stop: test_setup: main stop
PASS -> FAIL: gdb.multi/multi-arch-exec.exp: first_arch=1: selected_thread=1: follow_exec_mode=same: continue across exec that changes architecture
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/cb/cb51113052d534b628c635ac7b86b95fe436d60d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/cb/cb51113052d534b628c635ac7b86b95fe436d60d//xfail.table.gz>

Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-native-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/19/builds/1375

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        cb51113052d534b628c635ac7b86b95fe436d60d

Subject of commit:
        Suppress the "unused function" warning for select_strerror_r

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/cb/cb51113052d534b628c635ac7b86b95fe436d60d/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/cb/cb51113052d534b628c635ac7b86b95fe436d60d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/cb/cb51113052d534b628c635ac7b86b95fe436d60d//xfail.table.gz>

Failures on Fedora-x86_64-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/17/builds/1480

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        cb51113052d534b628c635ac7b86b95fe436d60d

Subject of commit:
        Suppress the "unused function" warning for select_strerror_r

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/cb/cb51113052d534b628c635ac7b86b95fe436d60d/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/cb/cb51113052d534b628c635ac7b86b95fe436d60d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/cb/cb51113052d534b628c635ac7b86b95fe436d60d//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/24/builds/1473

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        cb51113052d534b628c635ac7b86b95fe436d60d

Subject of commit:
        Suppress the "unused function" warning for select_strerror_r

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/cb/cb51113052d534b628c635ac7b86b95fe436d60d/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/cb/cb51113052d534b628c635ac7b86b95fe436d60d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/cb/cb51113052d534b628c635ac7b86b95fe436d60d//xfail.table.gz>