public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] gdbserver x86 on win32: call init_target_desc
Date: Fri, 22 Sep 2017 15:58:00 -0000	[thread overview]
Message-ID: <cc4d742f4ce05bf933397a513b953c0feeae0663@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT cc4d742f4ce05bf933397a513b953c0feeae0663 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: cc4d742f4ce05bf933397a513b953c0feeae0663

gdbserver x86 on win32: call init_target_desc

When trying to run gdbserver compiled for x86 win32 under wine, I get:

  $ wine ./gdbserver/gdbserver.exe --once :1234 ./test
  /home/emaisin/src/binutils-gdb/gdb/gdbserver/regcache.c:177: A problem internal to GDBserver has been detected.
  regcache* new_register_cache(const target_desc*): Assertion `tdesc->registers_size != 0' failed.

It seems like on that platform, init_target_desc is never called, so
registers_size is never computed.

My first thought was to call init_target_desc somewhere in win32-low.c,
but it turns out that when using win32 on arm, the target description is
already initialized by the generated code.  My second thought was to
call it in {i386,amd64}_create_target_description, but those functions
are shared with GDB, and init_target_desc is gdbserver-specific.  So I
ended up with the simplest fix, calling it in i386_arch_setup.

Now I hit some other problem:

  $ wine ./gdbserver/gdbserver.exe --once :1234 ./test
  Killing process(es): 39
  No program to debug
  Exiting

but still, I think fixing the tdesc issue this is a step forward.

gdb/gdbserver/ChangeLog:

	* win32-i386-low.c (i386_arch_setup): Call init_target_desc.


             reply	other threads:[~2017-09-22 15:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22 15:58 sergiodj+buildbot [this message]
2017-09-22 15:59 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot
2017-09-22 16:41 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2017-09-22 16:49 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2017-09-22 17:08 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2017-09-22 17:31 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2017-09-22 17:47 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2017-09-22 18:12 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
2017-09-22 18:15 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
2017-09-22 18:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-09-22 19:00 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc4d742f4ce05bf933397a513b953c0feeae0663@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).