[binutils-gdb] Fix GDB build with G++ 4.8

[binutils-gdb] Fix GDB build with G++ 4.8

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT cc536b21677586455973f81ee05257ada8efdcb8 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: cc536b21677586455973f81ee05257ada8efdcb8

Fix GDB build with G++ 4.8

G++ 4.8 trips on:

  In file included from /opt/gcc-4.8/include/c++/4.8.5/algorithm:62:0,
		   from ../../src/gdb/ada-lang.c:65:
  /opt/gcc-4.8/include/c++/4.8.5/bits/stl_algo.h: In instantiation of _RandomAccessIterator std::__unguarded_partition(_RandomAccessIterator, _RandomAccessIterator, const _Tp&) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<ada_exc_info*, std::vector<ada_exc_info> >; _Tp = ada_exc_info]:
  /opt/gcc-4.8/include/c++/4.8.5/bits/stl_algo.h:2283:70:   required from _RandomAccessIterator std::__unguarded_partition_pivot(_RandomAccessIterator, _RandomAccessIterator) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<ada_exc_info*, std::vector<ada_exc_info> >]
  /opt/gcc-4.8/include/c++/4.8.5/bits/stl_algo.h:2315:54:   required from void std::__introsort_loop(_RandomAccessIterator, _RandomAccessIterator, _Size) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<ada_exc_info*, std::vector<ada_exc_info> >; _Size = long int]
  /opt/gcc-4.8/include/c++/4.8.5/bits/stl_algo.h:5461:36:   required from void std::sort(_RAIter, _RAIter) [with _RAIter = __gnu_cxx::__normal_iterator<ada_exc_info*, std::vector<ada_exc_info> >]
  ../../src/gdb/ada-lang.c:13153:61:   required from here
  /opt/gcc-4.8/include/c++/4.8.5/bits/stl_algo.h:2245:19: error: passing const ada_exc_info as this argument of bool ada_exc_info::operator<(const ada_exc_info&) discards qualifiers [-fpermissive]
      while (__pivot < *__last)
		     ^

Seems to be a libstdc++ bug meanwhile fixed by:
  https://gcc.gnu.org/ml/libstdc++/2012-04/msg00074.

In any case, there's no reason these methods can't be const.

gdb/ChangeLog:
2017-10-02  Tom Tromey  <tom@tromey.com>
	    Pedro Alves  <palves@redhat.com>

	* ada-lang.h (ada_exc_info::operator<): Make const.
	(ada_exc_info::operator==): Make const.
	* ada-lang.c (ada_exc_info::operator<, ada_exc_info::operator==):
	Make const.

Failures on Fedora-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	marist-fedora-s390x

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-s390x-m64/builds/6487>

Commit(s) tested:
	cc536b21677586455973f81ee05257ada8efdcb8

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix GDB build with G++ 4.8

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-s390x-m64/cc/cc536b21677586455973f81ee05257ada8efdcb8/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-s390x-m64/xfails/master/xfail;hb=5dbf1b9>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-s390x-m64/xfails/master/xfail.table;hb=5dbf1b9>

Failures on Fedora-x86_64-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-2

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/7473>

Commit(s) tested:
	cc536b21677586455973f81ee05257ada8efdcb8

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix GDB build with G++ 4.8

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m64/cc/cc536b21677586455973f81ee05257ada8efdcb8/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-m64/xfails/master/xfail;hb=37ba07a>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-m64/xfails/master/xfail.table;hb=37ba07a>

Failures on Fedora-x86_64-cc-with-index, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/7390>

Commit(s) tested:
	cc536b21677586455973f81ee05257ada8efdcb8

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix GDB build with G++ 4.8

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/cc/cc536b21677586455973f81ee05257ada8efdcb8/>

*** Diff to previous build ***
============================
new FAIL: gdb.go/methods.exp: setting breakpoint at main.T.Foo
new FAIL: gdb.go/methods.exp: setting breakpoint at
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail;hb=6c0083a>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail.table;hb=6c0083a>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-2

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/7460>

Commit(s) tested:
	cc536b21677586455973f81ee05257ada8efdcb8

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix GDB build with G++ 4.8

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m64/cc/cc536b21677586455973f81ee05257ada8efdcb8/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail;hb=ec1fe2e>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail.table;hb=ec1fe2e>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m32/builds/7422>

Commit(s) tested:
	cc536b21677586455973f81ee05257ada8efdcb8

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix GDB build with G++ 4.8

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m32/cc/cc536b21677586455973f81ee05257ada8efdcb8/>

*** Diff to previous build ***
============================
new FAIL: gdb.go/methods.exp: setting breakpoint at main.T.Foo
new FAIL: gdb.go/methods.exp: setting breakpoint at
new FAIL: gdb.guile/scm-ports.exp: buffered: seek to $sp
new FAIL: gdb.guile/scm-ports.exp: buffered: seek to $sp for restore
new FAIL: gdb.guile/scm-ports.exp: unbuffered: seek to $sp
new FAIL: gdb.guile/scm-ports.exp: unbuffered: seek to $sp for restore
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
new FAIL: gdb.trace/unavailable.exp: unavailable locals: auto locals: ctf: info locals
new FAIL: gdb.trace/unavailable.exp: unavailable locals: register locals: ctf: print locc
new FAIL: gdb.trace/unavailable.exp: unavailable locals: register locals: ctf: print locf
new FAIL: gdb.trace/unavailable.exp: unavailable locals: register locals: ctf: print locd
new FAIL: gdb.trace/unavailable.exp: unavailable locals: register locals: ctf: info locals
new FAIL: gdb.trace/unavailable.exp: unavailable locals: static locals: ctf: info locals
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m32/xfails/master/xfail;hb=8350cae>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m32/xfails/master/xfail.table;hb=8350cae>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m64/builds/7416>

Commit(s) tested:
	cc536b21677586455973f81ee05257ada8efdcb8

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix GDB build with G++ 4.8

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m64/cc/cc536b21677586455973f81ee05257ada8efdcb8/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail;hb=4b5a167>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail.table;hb=4b5a167>

Failures on Fedora-x86_64-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/7433>

Commit(s) tested:
	cc536b21677586455973f81ee05257ada8efdcb8

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix GDB build with G++ 4.8

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m32/cc/cc536b21677586455973f81ee05257ada8efdcb8/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-m32/xfails/master/xfail;hb=a5ade86>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-m32/xfails/master/xfail.table;hb=a5ade86>

Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-extended-gdbserver-m32/builds/1643>

Commit(s) tested:
	cc536b21677586455973f81ee05257ada8efdcb8

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix GDB build with G++ 4.8

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-extended-gdbserver-m32/cc/cc536b21677586455973f81ee05257ada8efdcb8/>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=1: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=13: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=16: wait for stops
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
new FAIL: gdb.threads/queue-signal.exp: determine thread functions
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: next does not change thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: current thread advanced - unlocked
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=1: other threads ran - unlocked
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: set scheduler-locking off
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: set scheduler-locking step
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=step: step to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: set scheduler-locking off
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: set scheduler-locking step
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: set scheduler-locking off
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: set scheduler-locking step
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=step: cmd=next: call_function=1: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: set scheduler-locking off
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=step: step to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: set scheduler-locking off
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: print call_function = 0
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=0: next to increment
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: set scheduler-locking off
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: continue to breakpoint: return to loop
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: find current thread
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: set scheduler-locking on
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: print call_function = 1
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=on: cmd=next: call_function=1: next to increment
new FAIL: gdb.threads/sigstep-threads.exp: continue
new FAIL: gdb.threads/sigstep-threads.exp: step 51
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Ubuntu-AArch32-m32, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-m32/builds/1643>

Commit(s) tested:
	cc536b21677586455973f81ee05257ada8efdcb8

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix GDB build with G++ 4.8

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-m32/cc/cc536b21677586455973f81ee05257ada8efdcb8/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/callfuncs.exp: noproto: finish after stop in call dummy preserves register contents
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-m32/xfails/master/xfail;hb=>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-m32/xfails/master/xfail.table;hb=>