public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] Move declaration of max_user_call_depth to header Date: Thu, 17 Oct 2019 17:24:00 -0000 [thread overview] Message-ID: <cc8dee1f1c67be4155225c6c29dc1245abb89812@gdb-build> (raw) *** TEST RESULTS FOR COMMIT cc8dee1f1c67be4155225c6c29dc1245abb89812 *** commit cc8dee1f1c67be4155225c6c29dc1245abb89812 Author: Christian Biesinger <cbiesinger@google.com> AuthorDate: Wed Oct 9 23:27:33 2019 -0500 Commit: Christian Biesinger <cbiesinger@google.com> CommitDate: Sat Oct 12 14:31:26 2019 -0500 Move declaration of max_user_call_depth to header Also removes an unnecessary declaration of cmdlist in cli-cmds.c. I don't understand why it is there, the definition of cmdlist is at the top of the same file. gdb/ChangeLog: 2019-10-12 Christian Biesinger <cbiesinger@google.com> * cli/cli-cmds.c (max_user_call_depth): Move comment to header. (show_user): Remove declaration of cmdlist. * cli/cli-cmds.h (max_user_call_depth): Declare. * cli/cli-script.c (execute_user_command): Remove declaration of max_user_call_depth. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b898bf77f9..d58a55fb8e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,11 @@ +2019-10-12 Christian Biesinger <cbiesinger@google.com> + + * cli/cli-cmds.c (max_user_call_depth): Move comment to header. + (show_user): Remove declaration of cmdlist. + * cli/cli-cmds.h (max_user_call_depth): Declare. + * cli/cli-script.c (execute_user_command): Remove declaration + of max_user_call_depth. + 2019-10-11 Jim Wilson <jimw@sifive.com> * gdbsupport/print-utils.h (pulongest): Fix comment. diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index 9f7b052d8e..a39ea22604 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -74,7 +74,7 @@ static void ambiguous_line_spec (gdb::array_view<const symtab_and_line> sals, static void filter_sals (std::vector<symtab_and_line> &); \f -/* Limit the call depth of user-defined commands */ +/* See cli-cmds.h. */ unsigned int max_user_call_depth; /* Define all cmd_list_elements. */ @@ -1538,7 +1538,6 @@ static void show_user (const char *args, int from_tty) { struct cmd_list_element *c; - extern struct cmd_list_element *cmdlist; if (args) { diff --git a/gdb/cli/cli-cmds.h b/gdb/cli/cli-cmds.h index 1a8b9a0d50..94ae81475d 100644 --- a/gdb/cli/cli-cmds.h +++ b/gdb/cli/cli-cmds.h @@ -101,6 +101,10 @@ extern struct cmd_list_element *setchecklist; extern struct cmd_list_element *showchecklist; +/* Limit the call depth of user-defined commands */ + +extern unsigned int max_user_call_depth; + /* Exported to gdb/top.c */ void init_cmd_lists (void); diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c index 4fc9c70259..3137955265 100644 --- a/gdb/cli/cli-script.c +++ b/gdb/cli/cli-script.c @@ -449,7 +449,6 @@ void execute_user_command (struct cmd_list_element *c, const char *args) { counted_command_line cmdlines_copy; - extern unsigned int max_user_call_depth; /* Ensure that the user commands can't be deleted while they are executing. */
next reply other threads:[~2019-10-17 17:24 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-17 17:24 gdb-buildbot [this message] 2019-10-17 17:24 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot 2019-10-17 18:51 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot 2019-10-17 19:37 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot 2019-10-25 2:55 ` Failures on Fedora-i686, " gdb-buildbot 2019-10-25 4:35 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cc8dee1f1c67be4155225c6c29dc1245abb89812@gdb-build \ --to=gdb-buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).