public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb/gdb-7.11-branch] Fix PR gdb/19858: GDB doesn't register the JIT libraries on attach
Date: Thu, 31 Mar 2016 19:23:00 -0000	[thread overview]
Message-ID: <cd64cabb8c66a5565fc33bf66a07c08bc767e413@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT cd64cabb8c66a5565fc33bf66a07c08bc767e413 ***

Author: Yichao Yu <yyc1992@gmail.com>
Branch: gdb-7.11-branch
Commit: cd64cabb8c66a5565fc33bf66a07c08bc767e413

Fix PR gdb/19858: GDB doesn't register the JIT libraries on attach

Ref: https://sourceware.org/ml/gdb/2016-03/msg00023.html

GDB currently fails to fetch the list of already-registered JIT
modules on attach.

Nothing is calling jit_inferior_init, which is what is responsible for
walking the JIT object list at init time.

Despite the misleading naming, jit_inferior_created_hook ->
jit_inferior_init is only called when the inferior execs.

This regressed with the fix for PR gdb/13431 (03bef283c2d3):
 https://sourceware.org/ml/gdb-patches/2012-02/msg00023.html which
removed the inferior_created (jit_inferior_created_observer)
observer.

Adding an inferior_created observer back fixes the issue.

In turn, this exposes a bug in jit_breakpoint_re_set_internal as well,
which is returning the wrong result when we already have the
breakpoint at the right address.

gdb/ChangeLog:
2016-03-31  Yichao Yu  <yyc1992@gmail.com>

	PR gdb/19858
	* jit.c (jit_breakpoint_re_set_internal): Return 0 if we already
	got the breakpoint at the right address.
	(jit_inferior_created): New function.
	(_initialize_jit): Install jit_inferior_created as
	inferior_created observer.

Signed-off-by: Pedro Alves <palves@redhat.com>


             reply	other threads:[~2016-03-31 19:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 19:23 sergiodj+buildbot [this message]
2016-03-31 19:25 ` Failures on RHEL-s390x-m64, branch gdb-7.11-branch sergiodj+buildbot
2016-03-31 21:02 ` Failures on AIX-POWER7-plain, " sergiodj+buildbot
2016-03-31 21:35 ` Failures on Debian-i686, " sergiodj+buildbot
2016-03-31 21:49 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot
2016-03-31 23:14 ` Failures on Fedora-i686, " sergiodj+buildbot
2016-03-31 23:18 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2016-03-31 23:18 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2016-03-31 23:30 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-03-31 23:34 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2016-03-31 23:38 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2016-04-01  0:02 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2016-04-01  0:44 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2016-04-01  3:02 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-04-01  6:27 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot
2016-04-01  6:47 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-04-01 11:37 ` Failures on Fedora-ppc64le-cc-with-index, " sergiodj+buildbot
2016-04-01 12:23 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-04-01 12:39 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd64cabb8c66a5565fc33bf66a07c08bc767e413@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).