public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] ubsan: bfin: left shift of negative value
Date: Mon, 16 Dec 2019 23:30:00 -0000 [thread overview]
Message-ID: <cedfc77485dbb566619dc1e2d729ce0a70d1a4ad@gdb-build> (raw)
*** TEST RESULTS FOR COMMIT cedfc77485dbb566619dc1e2d729ce0a70d1a4ad ***
commit cedfc77485dbb566619dc1e2d729ce0a70d1a4ad
Author: Alan Modra <amodra@gmail.com>
AuthorDate: Mon Dec 16 10:31:34 2019 +1030
Commit: Alan Modra <amodra@gmail.com>
CommitDate: Mon Dec 16 17:33:53 2019 +1030
ubsan: bfin: left shift of negative value
* bfin-dis.c (fmtconst, fmtconst_val): Avoid signed overflow.
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 65ef685d07..ca476060e9 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,7 @@
+2019-12-16 Alan Modra <amodra@gmail.com>
+
+ * bfin-dis.c (fmtconst, fmtconst_val): Avoid signed overflow.
+
2019-12-16 Alan Modra <amodra@gmail.com>
* nds32-dis.c (print_insn16, print_insn32): Remove forward decls.
diff --git a/opcodes/bfin-dis.c b/opcodes/bfin-dis.c
index 711f7e1e07..19ce426014 100644
--- a/opcodes/bfin-dis.c
+++ b/opcodes/bfin-dis.c
@@ -128,7 +128,8 @@ fmtconst (const_forms_t cf, TIword x, bfd_vma pc, disassemble_info *outf)
if (constant_formats[cf].pcrel)
x = SIGNEXTEND (x, constant_formats[cf].nbits);
- ea = (x + constant_formats[cf].offset) << constant_formats[cf].scale;
+ ea = x + constant_formats[cf].offset;
+ ea = ea << constant_formats[cf].scale;
if (constant_formats[cf].pcrel)
ea += pc;
@@ -152,17 +153,14 @@ fmtconst (const_forms_t cf, TIword x, bfd_vma pc, disassemble_info *outf)
{
int nb = constant_formats[cf].nbits + 1;
- x = x | (1 << constant_formats[cf].nbits);
+ x = x | (1ul << constant_formats[cf].nbits);
x = SIGNEXTEND (x, nb);
}
else if (constant_formats[cf].issigned)
x = SIGNEXTEND (x, constant_formats[cf].nbits);
- if (constant_formats[cf].offset)
- x += constant_formats[cf].offset;
-
- if (constant_formats[cf].scale)
- x <<= constant_formats[cf].scale;
+ x += constant_formats[cf].offset;
+ x = (unsigned long) x << constant_formats[cf].scale;
if (constant_formats[cf].decimal)
sprintf (buf, "%*li", constant_formats[cf].leading, x);
@@ -186,7 +184,8 @@ fmtconst_val (const_forms_t cf, unsigned int x, unsigned int pc)
if (constant_formats[cf].pcrel)
x = SIGNEXTEND (x, constant_formats[cf].nbits);
- ea = (x + constant_formats[cf].offset) << constant_formats[cf].scale;
+ ea = x + constant_formats[cf].offset;
+ ea = ea << constant_formats[cf].scale;
if (constant_formats[cf].pcrel)
ea += pc;
@@ -197,7 +196,7 @@ fmtconst_val (const_forms_t cf, unsigned int x, unsigned int pc)
if (constant_formats[cf].negative)
{
int nb = constant_formats[cf].nbits + 1;
- x = x | (1u << constant_formats[cf].nbits);
+ x = x | (1ul << constant_formats[cf].nbits);
x = SIGNEXTEND (x, nb);
}
else if (constant_formats[cf].issigned)
next reply other threads:[~2019-12-16 23:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 23:30 gdb-buildbot [this message]
2019-12-16 23:24 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master gdb-buildbot
2019-12-18 16:18 ` Failures on Fedora-i686, " gdb-buildbot
2019-12-18 16:47 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2019-12-18 16:48 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2019-12-18 16:57 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2019-12-18 17:19 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2019-12-18 17:37 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2019-12-18 17:42 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
2019-12-18 17:49 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cedfc77485dbb566619dc1e2d729ce0a70d1a4ad@gdb-build \
--to=gdb-buildbot@sergiodj.net \
--cc=gdb-testers@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).