public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] gdb/x86: Fix write out of mxcsr register for xsave targets Date: Fri, 11 May 2018 22:31:00 -0000 [thread overview] Message-ID: <cf4912ae570ceae019b344785e4eeaf8cf273df3@gdb-build> (raw) *** TEST RESULTS FOR COMMIT cf4912ae570ceae019b344785e4eeaf8cf273df3 *** Author: Andrew Burgess <andrew.burgess@embecosm.com> Branch: master Commit: cf4912ae570ceae019b344785e4eeaf8cf273df3 gdb/x86: Fix write out of mxcsr register for xsave targets In commit: commit 8ee22052f690c007556b97eed59f49350ece5ca9 Author: Andrew Burgess <andrew.burgess@embecosm.com> Date: Thu May 3 17:46:14 2018 +0100 gdb/x86: Handle kernels using compact xsave format in two places FXSAVE_ADDR was used instead of FXSAVE_MXCSR_ADDR to get the address of the mxcsr register within the xsave buffer. This will mean we are potentially accessing the wrong location within the xsave buffer. There are no tests included with this patch. The first mistake would only trigger an issue if/when the user tries to manually set the mxcsr register to a value that matches the random (value off stack) value that is in the xsave buffer, in this case the change by the user will go unnoticed by GDB, and the default value of mxcsr will be preserved. The second mistake only happens on the code path where all x87 registers are being written out of the register cache. I'm not sure how to trigger that code path. gdb/ChangeLog: * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not FXSAVE_ADDR for the mxcsr register.
next reply other threads:[~2018-05-11 22:22 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-11 22:31 sergiodj+buildbot [this message] 2018-05-11 22:27 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot 2018-05-12 0:11 ` Failures on RHEL-s390x-m64, " sergiodj+buildbot 2018-05-12 7:26 ` Failures on Debian-s390x-m64, " sergiodj+buildbot 2018-05-13 14:14 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot 2018-05-13 14:20 ` *** COMPILATION FAILED *** Failures on Fedora-i686, branch master *** BREAKAGE *** sergiodj+buildbot 2018-05-13 18:21 ` Failures on Fedora-x86_64-native-gdbserver-m64, branch master sergiodj+buildbot 2018-05-13 22:52 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, branch master *** BREAKAGE *** sergiodj+buildbot 2018-06-23 22:05 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cf4912ae570ceae019b344785e4eeaf8cf273df3@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).