public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Remove simulator_command declaration, make static
Date: Wed, 27 Nov 2019 04:36:00 -0000	[thread overview]
Message-ID: <d04afd58be9a490ab5ff0ea5ee6020f3d2781002@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT d04afd58be9a490ab5ff0ea5ee6020f3d2781002 ***

commit d04afd58be9a490ab5ff0ea5ee6020f3d2781002
Author:     Simon Marchi <simon.marchi@efficios.com>
AuthorDate: Tue Nov 26 12:12:04 2019 -0500
Commit:     Simon Marchi <simon.marchi@efficios.com>
CommitDate: Tue Nov 26 14:29:20 2019 -0500

    Remove simulator_command declaration, make static
    
    The simulator_command function is not used outside its file, so make it
    static.  Remove the declaration, which is not needed and not even in
    sync with the definition.
    
    gdb/ChangeLog:
    
            * remote-sim.c (simulator_command): Make static, remove
            declaration.
    
    Change-Id: I40bd1e3662f849c4c9970443931ab9ee0ccccea1

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index afb0b65c79..ad0f981975 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
+
+	* remote-sim.c (simulator_command): Make static, remove
+	declaration.
+
 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 
 	* unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
diff --git a/gdb/remote-sim.c b/gdb/remote-sim.c
index 67b4690945..1c40c57252 100644
--- a/gdb/remote-sim.c
+++ b/gdb/remote-sim.c
@@ -69,8 +69,6 @@ static void gdb_os_evprintf_filtered (host_callback *, const char *, va_list);
 static void gdb_os_error (host_callback *, const char *, ...)
      ATTRIBUTE_NORETURN;
 
-void simulator_command (char *args, int from_tty);
-
 /* Naming convention:
 
    sim_* are the interface to the simulator (see remote-sim.h).
@@ -1162,7 +1160,7 @@ gdbsim_target::mourn_inferior ()
 /* Pass the command argument through to the simulator verbatim.  The
    simulator must do any command interpretation work.  */
 
-void
+static void
 simulator_command (const char *args, int from_tty)
 {
   struct sim_inferior_data *sim_data;


             reply	other threads:[~2019-11-27  4:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27  4:36 gdb-buildbot [this message]
2019-11-27  4:36 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master gdb-buildbot
2019-11-29 16:01 ` Failures on Fedora-i686, " gdb-buildbot
2019-11-29 16:15 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2019-11-29 16:18 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2019-11-29 16:53 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2019-11-29 16:58 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2019-11-29 16:59 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d04afd58be9a490ab5ff0ea5ee6020f3d2781002@gdb-build \
    --to=gdb-buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).