[binutils-gdb] Make dwarf_expr_context::stack an std::vector

[binutils-gdb] Make dwarf_expr_context::stack an std::vector

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT d185219da329805075ba5e0e72ec4c89c925cff2 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: d185219da329805075ba5e0e72ec4c89c925cff2

Make dwarf_expr_context::stack an std::vector

Replace the manually managed array with a vector.  It is mostly
straightforward, except maybe one thing in execute_stack_op, in the
handling of DW_OP_fbreg.  When the code stumbles on that opcode while
evaluating an expression, it needs to evaluate a subexpression to find
where the fb reg has been saved.  Rather than creating a new context, it
reuses the current context.  It saves the size of the stack before and
restores the stack to that size after.

I think we can do a little bit better by saving the current stack
locally and installing a new empty stack.  This way, if the
subexpression is malformed and underflows, we'll get an exception.
Before, it would have overwritten the top elements of the top-level
expression.  The evaluation of the top-level expression would have then
resumed with the same stack size, but possibly some corrupted elements.

gdb/ChangeLog:

	* dwarf2expr.h (dwarf_stack_value): Add constructor.
	(dwarf_expr_context) <~dwarf_expr_context>: Define as default.
	<stack>: Change type to std::vector.
	<stack_len, stack_allocated>: Remove.
	<grow_stack>: Remove.
	* dwarf2expr.c (dwarf_expr_context::dwarf_expr_context): Adjust.
	(dwarf_expr_context::~dwarf_expr_context): Remove.
	(dwarf_expr_context::grow_stack): Remove.
	(dwarf_expr_context::push): Adjust.
	(dwarf_expr_context::pop): Adjust.
	(dwarf_expr_context::fetch): Adjust.
	(dwarf_expr_context::fetch_in_stack_memory): Adjust.
	(dwarf_expr_context::stack_empty_p): Adjust.
	(dwarf_expr_context::execute_stack_op): Adjust.

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m32/builds/7180>

Commit(s) tested:
	d185219da329805075ba5e0e72ec4c89c925cff2

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Make dwarf_expr_context::stack an std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m32/d1/d185219da329805075ba5e0e72ec4c89c925cff2/>

*** Diff to previous build ***
============================
new FAIL: gdb.go/methods.exp: setting breakpoint at main.T.Foo
new FAIL: gdb.go/methods.exp: setting breakpoint at
new FAIL: gdb.guile/scm-ports.exp: buffered: seek to $sp
new FAIL: gdb.guile/scm-ports.exp: buffered: seek to $sp for restore
new FAIL: gdb.guile/scm-ports.exp: unbuffered: seek to $sp
new FAIL: gdb.guile/scm-ports.exp: unbuffered: seek to $sp for restore
new FAIL: gdb.trace/unavailable.exp: unavailable locals: auto locals: ctf: info locals
new FAIL: gdb.trace/unavailable.exp: unavailable locals: register locals: ctf: print locc
new FAIL: gdb.trace/unavailable.exp: unavailable locals: register locals: ctf: print locf
new FAIL: gdb.trace/unavailable.exp: unavailable locals: register locals: ctf: print locd
new FAIL: gdb.trace/unavailable.exp: unavailable locals: register locals: ctf: info locals
new FAIL: gdb.trace/unavailable.exp: unavailable locals: static locals: ctf: info locals
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail;hb=a01931e>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail.table;hb=a01931e>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/7221>

Commit(s) tested:
	d185219da329805075ba5e0e72ec4c89c925cff2

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Make dwarf_expr_context::stack an std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m64/d1/d185219da329805075ba5e0e72ec4c89c925cff2/>

*** Diff to previous build ***
============================
new FAIL: gdb.go/methods.exp: setting breakpoint at main.T.Foo
new FAIL: gdb.go/methods.exp: setting breakpoint at
new FAIL: gdb.rust/modules.exp: call f3
new FAIL: gdb.rust/modules.exp: call self::f2
new FAIL: gdb.rust/modules.exp: call self::super::f2
new FAIL: gdb.rust/modules.exp: call super::f2
new FAIL: gdb.rust/modules.exp: call self::super::super::f2
new FAIL: gdb.rust/modules.exp: call super::super::f2
new FAIL: gdb.rust/modules.exp: call ::f2
new FAIL: gdb.rust/modules.exp: call extern modules::mod1::f2
new FAIL: gdb.trace/unavailable.exp: unavailable locals: auto locals: ctf: info locals
new FAIL: gdb.trace/unavailable.exp: unavailable locals: register locals: ctf: print locf
new FAIL: gdb.trace/unavailable.exp: unavailable locals: register locals: ctf: print locd
new FAIL: gdb.trace/unavailable.exp: unavailable locals: register locals: ctf: info locals
new FAIL: gdb.trace/unavailable.exp: unavailable locals: static locals: ctf: info locals
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail;hb=0726e3e>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail.table;hb=0726e3e>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m64/builds/7177>

Commit(s) tested:
	d185219da329805075ba5e0e72ec4c89c925cff2

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Make dwarf_expr_context::stack an std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m64/d1/d185219da329805075ba5e0e72ec4c89c925cff2/>

*** Diff to previous build ***
============================
new FAIL: gdb.go/methods.exp: setting breakpoint at main.T.Foo
new FAIL: gdb.go/methods.exp: setting breakpoint at
new FAIL: gdb.rust/modules.exp: call f3
new FAIL: gdb.rust/modules.exp: call self::f2
new FAIL: gdb.rust/modules.exp: call self::super::f2
new FAIL: gdb.rust/modules.exp: call super::f2
new FAIL: gdb.rust/modules.exp: call self::super::super::f2
new FAIL: gdb.rust/modules.exp: call super::super::f2
new FAIL: gdb.rust/modules.exp: call ::f2
new FAIL: gdb.rust/modules.exp: call extern modules::mod1::f2
new FAIL: gdb.trace/unavailable.exp: unavailable locals: auto locals: ctf: info locals
new FAIL: gdb.trace/unavailable.exp: unavailable locals: register locals: ctf: print locf
new FAIL: gdb.trace/unavailable.exp: unavailable locals: register locals: ctf: print locd
new FAIL: gdb.trace/unavailable.exp: unavailable locals: register locals: ctf: info locals
new FAIL: gdb.trace/unavailable.exp: unavailable locals: static locals: ctf: info locals
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail;hb=a68cb3e>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail.table;hb=a68cb3e>

Failures on Ubuntu-AArch64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-aarch64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-native-gdbserver-m64/builds/2818>

Commit(s) tested:
	d185219da329805075ba5e0e72ec4c89c925cff2

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Make dwarf_expr_context::stack an std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch64-native-gdbserver-m64/d1/d185219da329805075ba5e0e72ec4c89c925cff2/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/callfuncs.exp: gdb function calls preserve register contents
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-native-gdbserver-m64/xfails/master/xfail;hb=a72a46a>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-native-gdbserver-m64/xfails/master/xfail.table;hb=a72a46a>

Failures on Ubuntu-AArch64-m64, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-aarch64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-m64/builds/2825>

Commit(s) tested:
	d185219da329805075ba5e0e72ec4c89c925cff2

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Make dwarf_expr_context::stack an std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch64-m64/d1/d185219da329805075ba5e0e72ec4c89c925cff2/>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=19: wait for stops
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-m64/xfails/master/xfail;hb=d5687a2>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-m64/xfails/master/xfail.table;hb=d5687a2>

Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-extended-gdbserver-m32/builds/1435>

Commit(s) tested:
	d185219da329805075ba5e0e72ec4c89c925cff2

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Make dwarf_expr_context::stack an std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-extended-gdbserver-m32/d1/d185219da329805075ba5e0e72ec4c89c925cff2/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/longjmp.exp: next over patt3
PASS -> FAIL: gdb.base/step-over-syscall.exp: clone: displaced=off: single step over clone
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=10: wait for stops
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Debian-s390x-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-extended-gdbserver-m64/builds/4252>

Commit(s) tested:
	d185219da329805075ba5e0e72ec4c89c925cff2

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Make dwarf_expr_context::stack an std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-native-extended-gdbserver-m64/d1/d185219da329805075ba5e0e72ec4c89c925cff2/>

Failures on Debian-s390x-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-gdbserver-m64/builds/4249>

Commit(s) tested:
	d185219da329805075ba5e0e72ec4c89c925cff2

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Make dwarf_expr_context::stack an std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-native-gdbserver-m64/d1/d185219da329805075ba5e0e72ec4c89c925cff2/>

Failures on Debian-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-m64/builds/4232>

Commit(s) tested:
	d185219da329805075ba5e0e72ec4c89c925cff2

Author(s) (in the same order as the commits):
	Simon Marchi <simon.marchi@ericsson.com>

Subject:
	Make dwarf_expr_context::stack an std::vector

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-m64/d1/d185219da329805075ba5e0e72ec4c89c925cff2/>

*** Diff to previous build ***
============================
KFAIL -> KPASS: gdb.cp/cpexprs.exp: p CV::m
new FAIL: gdb.cp/local-static.exp: c++: print 'S::method
new FAIL: gdb.cp/local-static.exp: c++: print S::method
new FAIL: gdb.cp/local-static.exp: c++: print 'S::static_method
new FAIL: gdb.cp/local-static.exp: c++: print S::static_method
new FAIL: gdb.cp/local-static.exp: c++: print 'S::inline_method
new FAIL: gdb.cp/local-static.exp: c++: print S::inline_method
new FAIL: gdb.cp/local-static.exp: c++: print 'S::static_inline_method
new FAIL: gdb.cp/local-static.exp: c++: print S::static_inline_method
new FAIL: gdb.cp/local-static.exp: c++: print 'S2<int>::method
new FAIL: gdb.cp/local-static.exp: c++: print S2<int>::method
new FAIL: gdb.cp/local-static.exp: c++: print 'S2<int>::static_method
new FAIL: gdb.cp/local-static.exp: c++: print S2<int>::static_method
new FAIL: gdb.cp/local-static.exp: c++: print 'S2<int>::inline_method
new FAIL: gdb.cp/local-static.exp: c++: print S2<int>::inline_method
new FAIL: gdb.cp/local-static.exp: c++: print 'S2<int>::static_inline_method
new FAIL: gdb.cp/local-static.exp: c++: print S2<int>::static_inline_method
new FAIL: gdb.cp/local-static.exp: c++: print free_func
new FAIL: gdb.cp/local-static.exp: c++: print 'free_func
new FAIL: gdb.cp/local-static.exp: c++: print 'free_inline_func
new FAIL: gdb.cp/local-static.exp: c++: print free_inline_func
new FAIL: gdb.cp/local-static.exp: c++: print 'free_func'::FF_s_var_int
new FAIL: gdb.cp/local-static.exp: c++: print free_func::FF_s_var_int
new FAIL: gdb.cp/local-static.exp: c++: print 'free_func::FF_s_var_int'
new FAIL: gdb.cp/local-static.exp: c++: print 'free_func'::FF_s_var_float
new FAIL: gdb.cp/local-static.exp: c++: print free_func::FF_s_var_float
new FAIL: gdb.cp/local-static.exp: c++: print 'free_func::FF_s_var_float'
new FAIL: gdb.cp/local-static.exp: c++: print 'free_func'::FF_s_var_aggregate
new FAIL: gdb.cp/local-static.exp: c++: print free_func::FF_s_var_aggregate
new FAIL: gdb.cp/local-static.exp: c++: print 'free_func::FF_s_var_aggregate'
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.