public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix comment for 'gdb_dlopen'
@ 2020-03-11 23:24 gdb-buildbot
  2020-03-11 23:24 ` Failures on Fedora-i686, branch master gdb-buildbot
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: gdb-buildbot @ 2020-03-11 23:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT d7592e974706637058867b02626c52a30ef0a2ee ***

commit d7592e974706637058867b02626c52a30ef0a2ee
Author:     Sergio Durigan Junior <sergiodj@redhat.com>
AuthorDate: Tue Feb 25 15:50:16 2020 -0500
Commit:     Sergio Durigan Junior <sergiodj@redhat.com>
CommitDate: Fri Feb 28 11:04:28 2020 -0500

    Fix comment for 'gdb_dlopen'
    
    The 'gdb_dlopen' function doesn't return NULL if the shlib load
    fails; it actually throws an error.  This patch updates the comment
    to reflect this.
    
    gdbsupport/ChangeLog:
    2020-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
    
            * gdb-dlfcn.h (gdb_dlopen): Update comment.

diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog
index d01966ed1d..88f2b821b5 100644
--- a/gdbsupport/ChangeLog
+++ b/gdbsupport/ChangeLog
@@ -1,3 +1,7 @@
+2020-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
+
+	* gdb-dlfcn.h (gdb_dlopen): Update comment.
+
 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	* configure: Regenerate.
diff --git a/gdbsupport/gdb-dlfcn.h b/gdbsupport/gdb-dlfcn.h
index 258cfebbc3..9e72a53dc0 100644
--- a/gdbsupport/gdb-dlfcn.h
+++ b/gdbsupport/gdb-dlfcn.h
@@ -32,8 +32,8 @@ struct dlclose_deleter
 typedef std::unique_ptr<void, dlclose_deleter> gdb_dlhandle_up;
 
 /* Load the dynamic library file named FILENAME, and return a handle
-   for that dynamic library.  Return NULL if the loading fails for any
-   reason.  */
+   for that dynamic library.  Throw an error if the loading fails for
+   any reason.  */
 
 gdb_dlhandle_up gdb_dlopen (const char *filename);
 


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2020-03-14 16:58 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 23:24 [binutils-gdb] Fix comment for 'gdb_dlopen' gdb-buildbot
2020-03-11 23:24 ` Failures on Fedora-i686, branch master gdb-buildbot
2020-03-11 23:53 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2020-03-12  0:04 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2020-03-12  0:55 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2020-03-12  1:58 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2020-03-12  2:17 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2020-03-13  8:28 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot
2020-03-13 10:16 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot
2020-03-13 17:02 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
2020-03-14 16:58 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).