Re: ☠ Buildbot (Sourceware): binutils-gdb-autoregen - failed 'git diff ...' (failure) (master)

[Mark Wielaard <mark@klomp.org>]

Hi Nick,

On Thu, 2024-06-13 at 14:18 +0000, builder@sourceware.org wrote:
> A failed build has been detected on builder binutils-gdb-autoregen while building binutils-gdb.
> 
> Full details are available at:
>     https://builder.sourceware.org/buildbot/#/builders/270/builds/2447
> 
> Build state: failed 'git diff ...' (failure)
> Revision: e8e10743f7b207b21a1efb0cc9e42487080db013
> Worker: bb3
> Build Reason: (unknown)
> Blamelist: Maciej W. Rozycki <macro@redhat.com>, Nick Clifton <nickc@redhat.com>
> 
> Steps:
> 
> - 0: worker_preparation ( success )
> 
> - 1: git checkout ( success )
>     Logs:
>         - stdio: https://builder.sourceware.org/buildbot/#/builders/270/builds/2447/steps/1/logs/stdio
> 
> - 2: autoregen.py ( success )
>     Logs:
>         - stdio: https://builder.sourceware.org/buildbot/#/builders/270/builds/2447/steps/2/logs/stdio
> 
> - 3: git diff ( failure )
>     Logs:
>         - stdio: https://builder.sourceware.org/buildbot/#/builders/270/builds/2447/steps/3/logs/stdio
> 

It looks like not all autotool files were correctly regenerated.

> diff --git a/ld/config.in b/ld/config.in
> index 5f57a61def1..f7c9da3d02a 100644
> --- a/ld/config.in
> +++ b/ld/config.in
> @@ -31,6 +31,10 @@
>     when a .note-GNU-stack section is missing. */
>  #undef DEFAULT_LD_EXECSTACK
>  
> +/* Define to 1 if you want to enable --rosegment in the ELF linker by default.
> +   */
> +#undef DEFAULT_LD_ROSEGMENT
> +
>  /* The default method for DT_TEXTREL check in ELF linker. */
>  #undef DEFAULT_LD_TEXTREL_CHECK
>  
> @@ -49,10 +53,6 @@
>     default. */
>  #undef DEFAULT_LD_Z_MARK_PLT
>  
> -/* Define to 1 if you want to enable --rosegment in the ELF linker by
> -   default. */
> -#undef DEFAULT_LD_ROSEGMENT
> -
>  /* Define to 1 if you want to enable -z relro in ELF linker by default. */
>  #undef DEFAULT_LD_Z_RELRO
>  

I think the autoregen bot is right, DEFAULT_LD_ROSEGMENT should sort
before DEFAULT_LD_TEXTREL_CHECK.

> diff --git a/ld/configure b/ld/configure
> index 83ea68f8e4b..4e8de840418 100755
> --- a/ld/configure
> +++ b/ld/configure
> @@ -11683,7 +11683,7 @@ else
>    lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
>    lt_status=$lt_dlunknown
>    cat > conftest.$ac_ext <<_LT_EOF
> -#line 11684 "configure"
> +#line 11686 "configure"
>  #include "confdefs.h"
>  
>  #if HAVE_DLFCN_H
> @@ -11789,7 +11789,7 @@ else
>    lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
>    lt_status=$lt_dlunknown
>    cat > conftest.$ac_ext <<_LT_EOF
> -#line 11790 "configure"
> +#line 11792 "configure"
>  #include "confdefs.h"
>  
>  #if HAVE_DLFCN_H
> 

Here I am not completely clear what happened. Did you use different
autoconf version?

Cheers,

Mark