public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/testsuite: Fix minor bug in skip_btrace*tests procs
@ 2019-11-28  5:17 gdb-buildbot
  2019-11-28  5:17 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: gdb-buildbot @ 2019-11-28  5:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT dcdec67858b1db5a91c1947569d6085310bfabe6 ***

commit dcdec67858b1db5a91c1947569d6085310bfabe6
Author:     Andrew Burgess <andrew.burgess@embecosm.com>
AuthorDate: Mon Nov 18 18:08:50 2019 +0000
Commit:     Andrew Burgess <andrew.burgess@embecosm.com>
CommitDate: Thu Nov 28 00:28:58 2019 +0000

    gdb/testsuite: Fix minor bug in skip_btrace*tests procs
    
    The two guard functions skip_btrace_tests and skip_btrace_pt_tests
    have a minor bug, if the check function fails to compile then surely
    we should skip the btrace tests - currently we return 0 to indicate
    don't skip.
    
    gdb/testsuite/ChangeLog:
    
            * lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to
            compile.
            (skip_btrace_pt_tests): Likewise.
    
    Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 86f2130c26..6b520e1f11 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2019-11-28  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+	* lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to
+	compile.
+	(skip_btrace_pt_tests): Likewise.
+
 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	* gdb.fortran/info-modules.exp: Compile source files in correct
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 828c91dd9e..4682f5d2f8 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2942,7 +2942,7 @@ gdb_caching_proc skip_btrace_tests {
     # Compile a test program.
     set src { int main() { return 0; } }
     if {![gdb_simple_compile $me $src executable]} {
-        return 0
+        return 1
     }
 
     # No error message, compilation succeeded so now run it via gdb.
@@ -2993,7 +2993,7 @@ gdb_caching_proc skip_btrace_pt_tests {
     # Compile a test program.
     set src { int main() { return 0; } }
     if {![gdb_simple_compile $me $src executable]} {
-        return 0
+        return 1
     }
 
     # No error message, compilation succeeded so now run it via gdb.


^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-01  9:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-28  5:17 [binutils-gdb] gdb/testsuite: Fix minor bug in skip_btrace*tests procs gdb-buildbot
2019-11-28  5:17 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
2019-11-28  5:34 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot
2019-12-01  9:08 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2019-12-01  9:09 ` Failures on Fedora-i686, " gdb-buildbot
2019-12-01  9:46 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2019-12-01  9:50 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).