[binutils-gdb] remote: Make readahead_cache a C++ class

[binutils-gdb] remote: Make readahead_cache a C++ class

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT dd194f6b36727987dc7f0d707512bd886982099c ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: dd194f6b36727987dc7f0d707512bd886982099c

remote: Make readahead_cache a C++ class

The idea here is eliminate the get_remote_state calls from within
readahead_cache_invalidate, readahead_cache_invalidate_fd,
remote_hostio_pread_from_cache by making those functions be class
methods instead.  Later on we'll have one readahead_cache instance per
remote connection, and this change makes that easier.

gdb/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

	* remote.c (struct readahead_cache) <invalidate, invalidate_fd,
	pread>: New method declarations.
	(remote_target::open_1): Adjust.
	(readahead_cache_invalidate): Rename to ...
	(readahead_cache::invalidate): ... this, and adjust to be a class
	method.
	(readahead_cache_invalidate_fd): Rename to ...
	(readahead_cache::invalidate_fd): ... this, and adjust to be a
	class method.
	(remote_hostio_pwrite): Adjust.
	(remote_hostio_pread_from_cache): Rename to ...
	(readahead_cache::pread): ... this, and adjust to be a class
	method.
	(remote_hostio_close): Adjust.

Failures on Fedora-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	marist-fedora-s390x

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-s390x-m64/builds/8589>

Commit(s) tested:
	dd194f6b36727987dc7f0d707512bd886982099c

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	remote: Make readahead_cache a C++ class

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-s390x-m64/dd/dd194f6b36727987dc7f0d707512bd886982099c/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-s390x-m64/xfails/master/xfail?id=b916c04>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-s390x-m64/xfails/master/xfail.table?id=b916c04>

Failures on RHEL-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	rhel-7_1-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/RHEL-s390x-m64/builds/7264>

Commit(s) tested:
	dd194f6b36727987dc7f0d707512bd886982099c

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	remote: Make readahead_cache a C++ class

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/RHEL-s390x-m64/dd/dd194f6b36727987dc7f0d707512bd886982099c/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/RHEL-s390x-m64/xfails/master/xfail?id=6da72a5>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/RHEL-s390x-m64/xfails/master/xfail.table?id=6da72a5>

Failures on Debian-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-m64/builds/5393>

Commit(s) tested:
	dd194f6b36727987dc7f0d707512bd886982099c

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	remote: Make readahead_cache a C++ class

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-m64/dd/dd194f6b36727987dc7f0d707512bd886982099c/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail?id=6c960dc>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail.table?id=6c960dc>

Failures on Debian-s390x-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-gdbserver-m64/builds/5441>

Commit(s) tested:
	dd194f6b36727987dc7f0d707512bd886982099c

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	remote: Make readahead_cache a C++ class

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-native-gdbserver-m64/dd/dd194f6b36727987dc7f0d707512bd886982099c/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-gdbserver-m64/xfails/master/xfail?id=91933c9>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-gdbserver-m64/xfails/master/xfail.table?id=91933c9>

Failures on Fedora-i686, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/9807>

Commit(s) tested:
	dd194f6b36727987dc7f0d707512bd886982099c

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	remote: Make readahead_cache a C++ class

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-i686/dd/dd194f6b36727987dc7f0d707512bd886982099c/>

*** Diff to previous build ***
============================
new FAIL: gdb.base/catch-syscall.exp: multiple targets: insert catch syscall on syscall 1 -- write on i386:x86-64
new FAIL: gdb.base/info-os.exp: continue to breakpoint: Set breakpoint here
new FAIL: gdb.base/info-os.exp: get shared memory key
new FAIL: gdb.base/info-os.exp: get shared memory ID
new FAIL: gdb.base/info-os.exp: get semaphore key
new FAIL: gdb.base/info-os.exp: get semaphore ID
new FAIL: gdb.base/info-os.exp: get message queue key
new FAIL: gdb.base/info-os.exp: get message queue ID
new FAIL: gdb.base/info-os.exp: get socket port number
new FAIL: gdb.base/info-os.exp: get process list
new FAIL: gdb.python/py-finish-breakpoint2.exp: set FinishBP after the exception
new FAIL: gdb.python/py-finish-breakpoint2.exp: check FinishBreakpoint in catch
new FAIL: gdb.python/py-finish-breakpoint2.exp: check finish BP removal
new FAIL: gdb.python/py-finish-breakpoint2.exp: continue to second exception
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-i686/xfails/master/xfail?id=b24bdf1>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-i686/xfails/master/xfail.table?id=b24bdf1>

*** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, branch master *** BREAKAGE ***

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-w64-mingw32/builds/1720>

Commit(s) tested:
	dd194f6b36727987dc7f0d707512bd886982099c

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	remote: Make readahead_cache a C++ class

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-w64-mingw32/dd/dd194f6b36727987dc7f0d707512bd886982099c/>

*** Failed to compiled GDB.  ***
============================

+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

../../binutils-gdb/bfd/archive.c:1685:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_archive_bsd44_construct_extended_name_table':
../../binutils-gdb/bfd/archive.c:1729:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_generic_write_ar_hdr':
../../binutils-gdb/bfd/archive.c:1741:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_bsd44_write_ar_hdr':
../../binutils-gdb/bfd/archive.c:1784:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_noarchive_write_ar_hdr':
../../binutils-gdb/bfd/archive.c:1790:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/bfd.c: In function '_bfd_error_handler':
../../binutils-gdb/bfd/bfd.c:1167:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function 'bfd_generic_stat_arch_elt':
../../binutils-gdb/bfd/archive.c:1963:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/bfd.c: In function 'bfd_assert':
../../binutils-gdb/bfd/bfd.c:1418:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/bfd.c: In function '_bfd_abort':
../../binutils-gdb/bfd/bfd.c:1438:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function 'bfd_dont_truncate_arname':
../../binutils-gdb/bfd/archive.c:2000:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function 'bfd_bsd_truncate_arname':
../../binutils-gdb/bfd/bfd.c: In function '_bfd_get_gp_value':
../../binutils-gdb/bfd/bfd.c:1612:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c:2023:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/bfd.c: In function '_bfd_set_gp_value':
../../binutils-gdb/bfd/bfd.c:1628:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function 'bfd_gnu_truncate_arname':
../../binutils-gdb/bfd/archive.c:2060:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_noarchive_truncate_arname':
../../binutils-gdb/bfd/archive.c:2067:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_write_archive_contents':
../../binutils-gdb/bfd/archive.c:2226:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
cc1: all warnings being treated as errors
../../binutils-gdb/bfd/archive.c: In function '_bfd_compute_and_write_armap':
../../binutils-gdb/bfd/archive.c:2382:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_bsd_write_armap':
../../binutils-gdb/bfd/archive.c:2538:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
make[4]: *** [Makefile:1501: bfd.lo] Error 1
../../binutils-gdb/bfd/archive.c: In function '_bfd_archive_bsd_update_armap_timestamp':
../../binutils-gdb/bfd/archive.c:2593:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_coff_write_armap':
../../binutils-gdb/bfd/archive.c:2746:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_noarchive_write_armap':
../../binutils-gdb/bfd/archive.c:2757:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_archive_close_and_cleanup':
../../binutils-gdb/bfd/archive.c:2815:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
cc1: all warnings being treated as errors
make[4]: *** [Makefile:1501: archive.lo] Error 1
make[4]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-mingw32/build/bfd'
make[3]: *** [Makefile:1544: all-recursive] Error 1
make[2]: *** [Makefile:1077: all] Error 2
make[1]: *** [Makefile:2696: all-bfd] Error 2
make: *** [Makefile:857: all] Error 2
make[3]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-mingw32/build/bfd'
make[2]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-mingw32/build/bfd'
make[1]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-mingw32/build'
============================

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-2

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/9812>

Commit(s) tested:
	dd194f6b36727987dc7f0d707512bd886982099c

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	remote: Make readahead_cache a C++ class

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m64/dd/dd194f6b36727987dc7f0d707512bd886982099c/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail?id=d3d9c05>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail.table?id=d3d9c05>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m64/builds/9766>

Commit(s) tested:
	dd194f6b36727987dc7f0d707512bd886982099c

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	remote: Make readahead_cache a C++ class

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m64/dd/dd194f6b36727987dc7f0d707512bd886982099c/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/info-os.exp: continue to breakpoint: Set breakpoint here
PASS -> FAIL: gdb.base/info-os.exp: get shared memory key
PASS -> FAIL: gdb.base/info-os.exp: get shared memory ID
PASS -> FAIL: gdb.base/info-os.exp: get semaphore key
PASS -> FAIL: gdb.base/info-os.exp: get semaphore ID
PASS -> FAIL: gdb.base/info-os.exp: get message queue key
PASS -> FAIL: gdb.base/info-os.exp: get message queue ID
PASS -> FAIL: gdb.base/info-os.exp: get socket port number
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail?id=a5e321e>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail.table?id=a5e321e>

Failures on Fedora-x86_64-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/9826>

Commit(s) tested:
	dd194f6b36727987dc7f0d707512bd886982099c

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	remote: Make readahead_cache a C++ class

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m64/dd/dd194f6b36727987dc7f0d707512bd886982099c/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/multiple-successive-infcall.exp: thread=4: testing if call get_value
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m64/xfails/master/xfail?id=370beeb>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m64/xfails/master/xfail.table?id=370beeb>

Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-extended-gdbserver-m32/builds/3584>

Commit(s) tested:
	dd194f6b36727987dc7f0d707512bd886982099c

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	remote: Make readahead_cache a C++ class

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-extended-gdbserver-m32/dd/dd194f6b36727987dc7f0d707512bd886982099c/>

*** Diff to previous build ***
============================
new KFAIL: gdb.base/step-over-syscall.exp: clone: displaced=on: single step over clone
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=3: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=9: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=17: wait for stops
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/3565>

Commit(s) tested:
	dd194f6b36727987dc7f0d707512bd886982099c

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	remote: Make readahead_cache a C++ class

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/dd/dd194f6b36727987dc7f0d707512bd886982099c/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail?id=>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail.table?id=>