From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130710 invoked by alias); 2 Dec 2019 23:34:56 -0000 Mailing-List: contact gdb-testers-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-testers-owner@sourceware.org Received: (qmail 130689 invoked by uid 89); 2 Dec 2019 23:34:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: kwanyin.sergiodj.net Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (158.69.185.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Dec 2019 23:34:54 +0000 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [binutils-gdb] Fix build breakage with --disable-tui From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Message-Id: Date: Mon, 02 Dec 2019 23:34:00 -0000 X-SW-Source: 2019-q4/txt/msg03761.txt.bz2 *** TEST RESULTS FOR COMMIT de2396d07844ca39a1893a11ead375acf2556890 *** commit de2396d07844ca39a1893a11ead375acf2556890 Author: Tom Tromey AuthorDate: Mon Dec 2 16:12:19 2019 -0700 Commit: Tom Tromey CommitDate: Mon Dec 2 16:12:19 2019 -0700 Fix build breakage with --disable-tui An earlier patch introduced a unit test for tui_copy_source_line. However if the TUI is not built (as is apparently the case on some of the buildbot builders), then this will fail to link. This patch fixes the problem. Tested by rebuilding with the TUI disabled. gdb/ChangeLog 2019-12-02 Tom Tromey * unittests/tui-selftests.c (run_tests): Make conditional. (_initialize_tui_selftest): Make conditional. Change-Id: I964811c7635be24cf6c53920e74e920914503674 diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 0c31ddd1d3..59825d3268 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-12-02 Tom Tromey + + * unittests/tui-selftests.c (run_tests): Make conditional. + (_initialize_tui_selftest): Make conditional. + 2019-12-02 Christian Biesinger * aix-thread.c (debug_aix_thread): Change type to bool. diff --git a/gdb/unittests/tui-selftests.c b/gdb/unittests/tui-selftests.c index 3a5d34fe48..95c12e3f5d 100644 --- a/gdb/unittests/tui-selftests.c +++ b/gdb/unittests/tui-selftests.c @@ -21,6 +21,8 @@ #include "gdbsupport/selftest.h" #include "tui/tui-winsource.h" +#ifdef TUI + namespace selftests { namespace tui { @@ -41,8 +43,12 @@ run_tests () } /* namespace tui*/ } /* namespace selftests */ +#endif /* TUI */ + void _initialize_tui_selftest () { +#ifdef TUI selftests::register_test ("tui", selftests::tui::run_tests); +#endif }