public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] btrace, gdbserver: remove the to_supports_btrace target method
Date: Fri, 09 Feb 2018 14:47:00 -0000	[thread overview]
Message-ID: <de6242d3075700ec4b73bdee583dc216f3a0b046@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT de6242d3075700ec4b73bdee583dc216f3a0b046 ***

Author: Markus Metzger <markus.t.metzger@intel.com>
Branch: master
Commit: de6242d3075700ec4b73bdee583dc216f3a0b046

btrace, gdbserver: remove the to_supports_btrace target method

Remove the to_supports_btrace target method and instead rely on detecting errors
when trying to enable recording.  This will also provide a suitable error
message explaining why recording is not possible.

For remote debugging, gdbserver will now always advertise branch tracing related
packets.  When talking to an older GDB, this will cause GDB to try to enable
branch tracing and gdbserver to report a suitable error message every time.

An older gdbserver will not advertise branch tracing related packets if the
one-time check failed, so a newer GDB with this patch will fail to enable branch
tracing at remote_enable_btrace() rather than at btrace_enable().  The error
message is the same in both cases so there should be no user-visible change.

gdb/
	* btrace.c (btrace_enable): Remove target_supports_btrace call.
	* nat/linux-btrace.c (perf_event_pt_event_type): Move.
	(kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
	(linux_supports_pt, linux_supports_btrace): Remove.
	(linux_enable_bts): Call cpu_supports_bts.
	* nat/linux-btrace.h (linux_supports_btrace): Remove.
	* remote.c (remote_supports_btrace): Remove.
	(init_remote_ops): Remove remote_supports_btrace.
	* target-delegates.c: Regenerated.
	* target.c (target_supports_btrace): Remove.
	* target.h (target_ops) <to_supports_btrace>: Remove
	(target_supports_btrace): Remove.
	* x86-linux-nat.c (x86_linux_create_target): Remove
	linux_supports_btrace.

gdbserver/
	* linux-low.c (linux_target_ops): Remove linux_supports_btrace.
	* nto-low.c (nto_target_ops): Remove NULL for supports_btrace.
	* spu-low.c (spu_target_ops): Likewise.
	* win32-low.c (win32_target_ops): Likewise.
	* server.c (supported_btrace_packets): Report packets unconditionally.
	* target.h (target_ops) <supports_btrace>: Remove.
	(target_supports_btrace): Remove.


             reply	other threads:[~2018-02-09 14:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09 14:47 sergiodj+buildbot [this message]
2018-02-09 14:47 ` Failures on RHEL-s390x-m64, branch master sergiodj+buildbot
2018-02-09 17:09 ` Failures on Fedora-s390x-m64, " sergiodj+buildbot
2018-02-09 18:47 ` Failures on Debian-s390x-m64, " sergiodj+buildbot
2018-02-09 19:03 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2018-02-09 19:34 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2018-02-09 19:34 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2018-02-09 19:56 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-02-09 19:58 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2018-02-09 19:59 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2018-02-09 20:17 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2018-02-09 20:27 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2018-02-09 22:04 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2018-02-10 13:30 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot
2018-02-10 15:07 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-02-10 15:30 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
2018-02-10 15:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de6242d3075700ec4b73bdee583dc216f3a0b046@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).