public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Avoid copying in lookup_name_info
@ 2020-04-14 11:25 gdb-buildbot
2020-04-14 11:25 ` Failures on Fedora-i686, branch master gdb-buildbot
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: gdb-buildbot @ 2020-04-14 11:25 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT e0802d59969339502203ad8e0d161b5f93beca73 ***
commit e0802d59969339502203ad8e0d161b5f93beca73
Author: Tom Tromey <tromey@adacore.com>
AuthorDate: Wed Apr 1 07:47:13 2020 -0600
Commit: Tom Tromey <tromey@adacore.com>
CommitDate: Wed Apr 1 07:47:13 2020 -0600
Avoid copying in lookup_name_info
lookup_name_info always copies the name that is passed in. However,
normally a copy is not needed. This patch changes this class to avoid
copying. This required changing the "name" method to return something
else; I chose a gdb::string_view, to avoid excessive calls to strlen
in the code using the lookup_name_info. However, as this class does
not allow an arbitrary string_view, I've also added a c_str method
that guarantees a \0-terminated result -- a pedantic difference but
one that respects the string_view contract, IMO.
gdb/ChangeLog
2020-04-01 Tom Tromey <tromey@adacore.com>
* symtab.h (class lookup_name_info) <lookup_name_info>: Change
"name" parameter to rvalue reference. Initialize m_name_holder.
<lookup_name_info>: New overloads.
<name>: Return gdb::string_view.
<c_str>: New method.
<make_ignore_params>: Update.
<search_name_hash>: Update.
<language_lookup_name>: Return const char *.
<m_name>: Change type.
* symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
(demangle_for_lookup_info::demangle_for_lookup_info): Update.
(lookup_name_info::match_any): Update.
* psymtab.c (match_partial_symbol, lookup_partial_symbol):
Update.
* minsyms.c (linkage_name_str): Update.
* language.c (default_symbol_name_matcher): Update.
* dwarf2/read.c (mapped_index_base::find_name_components_bounds):
Update.
* ada-lang.c (ada_fold_name): Change parameter to string_view.
(ada_lookup_name_info::ada_lookup_name_info): Update.
(literal_symbol_name_matcher): Update.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7c1d84c330..8afad21c9e 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,27 @@
+2020-04-01 Tom Tromey <tromey@adacore.com>
+
+ * symtab.h (class lookup_name_info) <lookup_name_info>: Change
+ "name" parameter to rvalue reference. Initialize m_name_holder.
+ <lookup_name_info>: New overloads.
+ <name>: Return gdb::string_view.
+ <c_str>: New method.
+ <make_ignore_params>: Update.
+ <search_name_hash>: Update.
+ <language_lookup_name>: Return const char *.
+ <m_name>: Change type.
+ * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
+ (demangle_for_lookup_info::demangle_for_lookup_info): Update.
+ (lookup_name_info::match_any): Update.
+ * psymtab.c (match_partial_symbol, lookup_partial_symbol):
+ Update.
+ * minsyms.c (linkage_name_str): Update.
+ * language.c (default_symbol_name_matcher): Update.
+ * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
+ Update.
+ * ada-lang.c (ada_fold_name): Change parameter to string_view.
+ (ada_lookup_name_info::ada_lookup_name_info): Update.
+ (literal_symbol_name_matcher): Update.
+
2020-04-01 Tom Tromey <tromey@adacore.com>
* psymtab.c (psymtab_search_name): Remove function.
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 565299a5ca..029a7912a0 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -1016,17 +1016,17 @@ ada_encode (const char *decoded)
to next call. */
static char *
-ada_fold_name (const char *name)
+ada_fold_name (gdb::string_view name)
{
static char *fold_buffer = NULL;
static size_t fold_buffer_size = 0;
- int len = strlen (name);
+ int len = name.size ();
GROW_VECT (fold_buffer, fold_buffer_size, len + 1);
if (name[0] == '\'')
{
- strncpy (fold_buffer, name + 1, len - 2);
+ strncpy (fold_buffer, name.data () + 1, len - 2);
fold_buffer[len - 2] = '\000';
}
else
@@ -5657,8 +5657,8 @@ add_nonlocal_symbols (struct obstack *obstackp,
if (num_defns_collected (obstackp) == 0 && global && !is_wild_match)
{
const char *name = ada_lookup_name (lookup_name);
- lookup_name_info name1 (std::string ("<_ada_") + name + '>',
- symbol_name_match_type::FULL);
+ std::string bracket_name = std::string ("<_ada_") + name + '>';
+ lookup_name_info name1 (bracket_name, symbol_name_match_type::FULL);
for (objfile *objfile : current_program_space->objfiles ())
{
@@ -13946,14 +13946,16 @@ do_exact_match (const char *symbol_search_name,
ada_lookup_name_info::ada_lookup_name_info (const lookup_name_info &lookup_name)
{
- const std::string &user_name = lookup_name.name ();
+ gdb::string_view user_name = lookup_name.name ();
if (user_name[0] == '<')
{
if (user_name.back () == '>')
- m_encoded_name = user_name.substr (1, user_name.size () - 2);
+ m_encoded_name
+ = user_name.substr (1, user_name.size () - 2).to_string ();
else
- m_encoded_name = user_name.substr (1, user_name.size () - 1);
+ m_encoded_name
+ = user_name.substr (1, user_name.size () - 1).to_string ();
m_encoded_p = true;
m_verbatim_p = true;
m_wild_match_p = false;
@@ -13963,19 +13965,19 @@ ada_lookup_name_info::ada_lookup_name_info (const lookup_name_info &lookup_name)
{
m_verbatim_p = false;
- m_encoded_p = user_name.find ("__") != std::string::npos;
+ m_encoded_p = user_name.find ("__") != gdb::string_view::npos;
if (!m_encoded_p)
{
- const char *folded = ada_fold_name (user_name.c_str ());
+ const char *folded = ada_fold_name (user_name);
const char *encoded = ada_encode_1 (folded, false);
if (encoded != NULL)
m_encoded_name = encoded;
else
- m_encoded_name = user_name;
+ m_encoded_name = user_name.to_string ();
}
else
- m_encoded_name = user_name;
+ m_encoded_name = user_name.to_string ();
/* Handle the 'package Standard' special case. See description
of m_standard_p. */
@@ -14022,12 +14024,12 @@ literal_symbol_name_matcher (const char *symbol_search_name,
const lookup_name_info &lookup_name,
completion_match_result *comp_match_res)
{
- const std::string &name = lookup_name.name ();
+ gdb::string_view name_view = lookup_name.name ();
- int cmp = (lookup_name.completion_mode ()
- ? strncmp (symbol_search_name, name.c_str (), name.size ())
- : strcmp (symbol_search_name, name.c_str ()));
- if (cmp == 0)
+ if (lookup_name.completion_mode ()
+ ? (strncmp (symbol_search_name, name_view.data (),
+ name_view.size ()) == 0)
+ : symbol_search_name == name_view)
{
if (comp_match_res != NULL)
comp_match_res->set_match (symbol_search_name);
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 1ec5c1e582..6ee33fcd6e 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -3681,7 +3681,7 @@ mapped_index_base::find_name_components_bounds
= this->name_components_casing == case_sensitive_on ? strcmp : strcasecmp;
const char *lang_name
- = lookup_name_without_params.language_lookup_name (lang).c_str ();
+ = lookup_name_without_params.language_lookup_name (lang);
/* Comparison function object for lower_bound that matches against a
given symbol name. */
diff --git a/gdb/language.c b/gdb/language.c
index 454c6dc45a..c13fd1a406 100644
--- a/gdb/language.c
+++ b/gdb/language.c
@@ -699,14 +699,14 @@ default_symbol_name_matcher (const char *symbol_search_name,
const lookup_name_info &lookup_name,
completion_match_result *comp_match_res)
{
- const std::string &name = lookup_name.name ();
+ gdb::string_view name = lookup_name.name ();
completion_match_for_lcd *match_for_lcd
= (comp_match_res != NULL ? &comp_match_res->match_for_lcd : NULL);
strncmp_iw_mode mode = (lookup_name.completion_mode ()
? strncmp_iw_mode::NORMAL
: strncmp_iw_mode::MATCH_PARAMS);
- if (strncmp_iw_with_mode (symbol_search_name, name.c_str (), name.size (),
+ if (strncmp_iw_with_mode (symbol_search_name, name.data (), name.size (),
mode, language_minimal, match_for_lcd) == 0)
{
if (comp_match_res != NULL)
diff --git a/gdb/minsyms.c b/gdb/minsyms.c
index e238355dc1..d2ac8172ee 100644
--- a/gdb/minsyms.c
+++ b/gdb/minsyms.c
@@ -467,7 +467,7 @@ linkage_name_str (const lookup_name_info &lookup_name)
if (current_language->la_language == language_ada)
return lookup_name.ada ().lookup_name ().c_str ();
- return lookup_name.name ().c_str ();
+ return lookup_name.c_str ();
}
/* See minsyms.h. */
diff --git a/gdb/psymtab.c b/gdb/psymtab.c
index d5e61f88dc..d3569ff013 100644
--- a/gdb/psymtab.c
+++ b/gdb/psymtab.c
@@ -578,8 +578,7 @@ match_partial_symbol (struct objfile *objfile,
gdb_assert (center < top);
enum language lang = (*center)->ginfo.language ();
- const char *lang_ln
- = name.language_lookup_name (lang).c_str ();
+ const char *lang_ln = name.language_lookup_name (lang);
if (ordered_compare ((*center)->ginfo.search_name (),
lang_ln) >= 0)
@@ -658,7 +657,7 @@ lookup_partial_symbol (struct objfile *objfile,
internal_error (__FILE__, __LINE__,
_("failed internal consistency check"));
if (strcmp_iw_ordered ((*center)->ginfo.search_name (),
- lookup_name.name ().c_str ()) >= 0)
+ lookup_name.c_str ()) >= 0)
{
top = center;
}
diff --git a/gdb/symtab.c b/gdb/symtab.c
index f300d759e0..680280105f 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -1790,7 +1790,7 @@ demangle_for_lookup_info::demangle_for_lookup_info
if (lookup_name.ignore_parameters () && lang == language_cplus)
{
gdb::unique_xmalloc_ptr<char> without_params
- = cp_remove_params_if_any (lookup_name.name ().c_str (),
+ = cp_remove_params_if_any (lookup_name.c_str (),
lookup_name.completion_mode ());
if (without_params != NULL)
@@ -1803,9 +1803,9 @@ demangle_for_lookup_info::demangle_for_lookup_info
}
if (lookup_name.match_type () == symbol_name_match_type::SEARCH_NAME)
- m_demangled_name = lookup_name.name ();
+ m_demangled_name = lookup_name.c_str ();
else
- m_demangled_name = demangle_for_lookup (lookup_name.name ().c_str (),
+ m_demangled_name = demangle_for_lookup (lookup_name.c_str (),
lang, storage);
}
@@ -1816,7 +1816,7 @@ lookup_name_info::match_any ()
{
/* Lookup any symbol that "" would complete. I.e., this matches all
symbol names. */
- static const lookup_name_info lookup_name ({}, symbol_name_match_type::FULL,
+ static const lookup_name_info lookup_name ("", symbol_name_match_type::FULL,
true);
return lookup_name;
diff --git a/gdb/symtab.h b/gdb/symtab.h
index 18be5d51b8..77f60e6c24 100644
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -185,29 +185,58 @@ private:
class lookup_name_info final
{
public:
- /* Create a new object. */
- lookup_name_info (std::string name,
+ /* We delete this overload so that the callers are required to
+ explicitly handle the lifetime of the name. */
+ lookup_name_info (std::string &&name,
+ symbol_name_match_type match_type,
+ bool completion_mode = false,
+ bool ignore_parameters = false) = delete;
+
+ /* This overload requires that NAME have a lifetime at least as long
+ as the lifetime of this object. */
+ lookup_name_info (const std::string &name,
+ symbol_name_match_type match_type,
+ bool completion_mode = false,
+ bool ignore_parameters = false)
+ : m_match_type (match_type),
+ m_completion_mode (completion_mode),
+ m_ignore_parameters (ignore_parameters),
+ m_name (name)
+ {}
+
+ /* This overload requires that NAME have a lifetime at least as long
+ as the lifetime of this object. */
+ lookup_name_info (const char *name,
symbol_name_match_type match_type,
bool completion_mode = false,
bool ignore_parameters = false)
: m_match_type (match_type),
m_completion_mode (completion_mode),
m_ignore_parameters (ignore_parameters),
- m_name (std::move (name))
+ m_name (name)
{}
/* Getters. See description of each corresponding field. */
symbol_name_match_type match_type () const { return m_match_type; }
bool completion_mode () const { return m_completion_mode; }
- const std::string &name () const { return m_name; }
+ gdb::string_view name () const { return m_name; }
const bool ignore_parameters () const { return m_ignore_parameters; }
+ /* Like the "name" method but guarantees that the returned string is
+ \0-terminated. */
+ const char *c_str () const
+ {
+ /* Actually this is always guaranteed due to how the class is
+ constructed. */
+ return m_name.data ();
+ }
+
/* Return a version of this lookup name that is usable with
comparisons against symbols have no parameter info, such as
psymbols and GDB index symbols. */
lookup_name_info make_ignore_params () const
{
- return lookup_name_info (m_name, m_match_type, m_completion_mode,
+ return lookup_name_info (c_str (), m_match_type, m_completion_mode,
true /* ignore params */);
}
@@ -218,27 +247,27 @@ class lookup_name_info final
if (!m_demangled_hashes_p[lang])
{
m_demangled_hashes[lang]
- = ::search_name_hash (lang, language_lookup_name (lang).c_str ());
+ = ::search_name_hash (lang, language_lookup_name (lang));
m_demangled_hashes_p[lang] = true;
}
return m_demangled_hashes[lang];
}
/* Get the search name for searches in language LANG. */
- const std::string &language_lookup_name (language lang) const
+ const char *language_lookup_name (language lang) const
{
switch (lang)
{
case language_ada:
- return ada ().lookup_name ();
+ return ada ().lookup_name ().c_str ();
case language_cplus:
- return cplus ().lookup_name ();
+ return cplus ().lookup_name ().c_str ();
case language_d:
- return d ().lookup_name ();
+ return d ().lookup_name ().c_str ();
case language_go:
- return go ().lookup_name ();
+ return go ().lookup_name ().c_str ();
default:
- return m_name;
+ return m_name.data ();
}
}
@@ -287,7 +316,7 @@ private:
symbol_name_match_type m_match_type;
bool m_completion_mode;
bool m_ignore_parameters;
- std::string m_name;
+ gdb::string_view m_name;
/* Language-specific info. These fields are filled lazily the first
time a lookup is done in the corresponding language. They're
^ permalink raw reply [flat|nested] 9+ messages in thread
* Failures on Fedora-i686, branch master
2020-04-14 11:25 [binutils-gdb] Avoid copying in lookup_name_info gdb-buildbot
@ 2020-04-14 11:25 ` gdb-buildbot
2020-04-14 11:38 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: gdb-buildbot @ 2020-04-14 11:25 UTC (permalink / raw)
To: gdb-testers
Buildername:
Fedora-i686
Worker:
fedora-x86-64-2
Full Build URL:
https://gdb-buildbot.osci.io/#builders/18/builds/2716
Author:
Tom Tromey <tromey@adacore.com>
Commit tested:
e0802d59969339502203ad8e0d161b5f93beca73
Subject of commit:
Avoid copying in lookup_name_info
Testsuite logs (gdb.sum, gdb.log and others):
https://gdb-buildbot.osci.io/results/Fedora-i686/e0/e0802d59969339502203ad8e0d161b5f93beca73/
*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/reread-readsym.exp: source reread-readsym.gdb 2
PASS -> FAIL: gdb.fortran/vla-sizeof.exp: print sizeof non-allocated indexed vla1
==============================================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://gdb-buildbot.osci.io/results/Fedora-i686/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.gz>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://gdb-buildbot.osci.io/results/Fedora-i686/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.table.gz>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Failures on Fedora-x86_64-cc-with-index, branch master
2020-04-14 11:25 [binutils-gdb] Avoid copying in lookup_name_info gdb-buildbot
2020-04-14 11:25 ` Failures on Fedora-i686, branch master gdb-buildbot
@ 2020-04-14 11:38 ` gdb-buildbot
2020-04-14 12:17 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: gdb-buildbot @ 2020-04-14 11:38 UTC (permalink / raw)
To: gdb-testers
Buildername:
Fedora-x86_64-cc-with-index
Worker:
fedora-x86-64-1
Full Build URL:
https://gdb-buildbot.osci.io/#builders/20/builds/2663
Author:
Tom Tromey <tromey@adacore.com>
Commit tested:
e0802d59969339502203ad8e0d161b5f93beca73
Subject of commit:
Avoid copying in lookup_name_info
Testsuite logs (gdb.sum, gdb.log and others):
https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/e0/e0802d59969339502203ad8e0d161b5f93beca73/
*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: no threads left
PASS -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: only inferior 1 left
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 4th stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 4th stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: first thread: print i3
==============================================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.gz>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.table.gz>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Failures on Fedora-x86_64-m32, branch master
2020-04-14 11:25 [binutils-gdb] Avoid copying in lookup_name_info gdb-buildbot
2020-04-14 11:25 ` Failures on Fedora-i686, branch master gdb-buildbot
2020-04-14 11:38 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
@ 2020-04-14 12:17 ` gdb-buildbot
2020-04-14 12:27 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: gdb-buildbot @ 2020-04-14 12:17 UTC (permalink / raw)
To: gdb-testers
Buildername:
Fedora-x86_64-m32
Worker:
fedora-x86-64-2
Full Build URL:
https://gdb-buildbot.osci.io/#builders/17/builds/2712
Author:
Tom Tromey <tromey@adacore.com>
Commit tested:
e0802d59969339502203ad8e0d161b5f93beca73
Subject of commit:
Avoid copying in lookup_name_info
Testsuite logs (gdb.sum, gdb.log and others):
https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/e0/e0802d59969339502203ad8e0d161b5f93beca73/
*** Diff to previous build ***
==============================================
new FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Private-Anonymous: no binary: loading /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-private-anon.gcore
new FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Shared-Anonymous: no binary: loading /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-shared-anon.gcore
new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for DoNotDump: loading /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/dont-dump.gcore
new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for non-Shared-Anonymous: loading /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-shared-anon.gcore
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.gz>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.table.gz>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Failures on Fedora-x86_64-m64, branch master
2020-04-14 11:25 [binutils-gdb] Avoid copying in lookup_name_info gdb-buildbot
` (2 preceding siblings ...)
2020-04-14 12:17 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
@ 2020-04-14 12:27 ` gdb-buildbot
2020-04-14 13:15 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: gdb-buildbot @ 2020-04-14 12:27 UTC (permalink / raw)
To: gdb-testers
Buildername:
Fedora-x86_64-m64
Worker:
fedora-x86-64-1
Full Build URL:
https://gdb-buildbot.osci.io/#builders/3/builds/2772
Author:
Tom Tromey <tromey@adacore.com>
Commit tested:
e0802d59969339502203ad8e0d161b5f93beca73
Subject of commit:
Avoid copying in lookup_name_info
Testsuite logs (gdb.sum, gdb.log and others):
https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/e0/e0802d59969339502203ad8e0d161b5f93beca73/
*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-arch-exec.exp: first_arch=1: selected_thread=1: follow_exec_mode=new: continue across exec that changes architecture
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print j
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.gz>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.table.gz>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master
2020-04-14 11:25 [binutils-gdb] Avoid copying in lookup_name_info gdb-buildbot
` (3 preceding siblings ...)
2020-04-14 12:27 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
@ 2020-04-14 13:15 ` gdb-buildbot
2020-04-14 13:28 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: gdb-buildbot @ 2020-04-14 13:15 UTC (permalink / raw)
To: gdb-testers
Buildername:
Fedora-x86_64-native-extended-gdbserver-m32
Worker:
fedora-x86-64-2
Full Build URL:
https://gdb-buildbot.osci.io/#builders/4/builds/2608
Author:
Tom Tromey <tromey@adacore.com>
Commit tested:
e0802d59969339502203ad8e0d161b5f93beca73
Subject of commit:
Avoid copying in lookup_name_info
Testsuite logs (gdb.sum, gdb.log and others):
https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/e0/e0802d59969339502203ad8e0d161b5f93beca73/
*** Diff to previous build ***
==============================================
new FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Private-Anonymous: no binary: loading /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64-native-extended-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-private-anon.gcore
new FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Shared-Anonymous: no binary: loading /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64-native-extended-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-shared-anon.gcore
new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for DoNotDump: loading /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64-native-extended-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/dont-dump.gcore
new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for non-Shared-Anonymous: loading /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64-native-extended-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-shared-anon.gcore
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: print re_run_var_2
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
new FAIL: gdb.threads/attach-into-signal.exp: threaded: thread apply 2 print $_siginfo.si_signo
FAIL -> UNRESOLVED: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: inferior 1 exited
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
new KFAIL: gdb.threads/watchthreads2.exp: gdb can drop watchpoints in multithreaded app
PASS -> FAIL: gdb.trace/mi-tsv-changed.exp: create delete modify: tvariable $tvar3 modified
==============================================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.gz>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.table.gz>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master
2020-04-14 11:25 [binutils-gdb] Avoid copying in lookup_name_info gdb-buildbot
` (4 preceding siblings ...)
2020-04-14 13:15 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
@ 2020-04-14 13:28 ` gdb-buildbot
2020-04-17 4:58 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2020-04-17 23:29 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
7 siblings, 0 replies; 9+ messages in thread
From: gdb-buildbot @ 2020-04-14 13:28 UTC (permalink / raw)
To: gdb-testers
Buildername:
Fedora-x86_64-native-extended-gdbserver-m64
Worker:
fedora-x86-64-1
Full Build URL:
https://gdb-buildbot.osci.io/#builders/2/builds/2609
Author:
Tom Tromey <tromey@adacore.com>
Commit tested:
e0802d59969339502203ad8e0d161b5f93beca73
Subject of commit:
Avoid copying in lookup_name_info
Testsuite logs (gdb.sum, gdb.log and others):
https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/e0/e0802d59969339502203ad8e0d161b5f93beca73/
*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.linespec/explicit.exp: complete unique label name reversed: cmd complete "b -label top -function myfunction"
PASS -> FAIL: gdb.linespec/explicit.exp: complete unique label name reversed: tab complete "b -label top -function myfunction"
PASS -> FAIL: gdb.multi/multi-term-settings.exp: inf1_how=attach: inf2_how=attach: stop with control-c
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
new FAIL: gdb.threads/attach-into-signal.exp: threaded: thread apply 2 print $_siginfo.si_signo
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i22
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print j
==============================================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.gz>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.table.gz>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Failures on Fedora-x86_64-native-gdbserver-m32, branch master
2020-04-14 11:25 [binutils-gdb] Avoid copying in lookup_name_info gdb-buildbot
` (5 preceding siblings ...)
2020-04-14 13:28 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
@ 2020-04-17 4:58 ` gdb-buildbot
2020-04-17 23:29 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
7 siblings, 0 replies; 9+ messages in thread
From: gdb-buildbot @ 2020-04-17 4:58 UTC (permalink / raw)
To: gdb-testers
Buildername:
Fedora-x86_64-native-gdbserver-m32
Worker:
fedora-x86-64-3
Full Build URL:
https://gdb-buildbot.osci.io/#builders/24/builds/2611
Author:
Tom Tromey <tromey@adacore.com>
Commit tested:
e0802d59969339502203ad8e0d161b5f93beca73
Subject of commit:
Avoid copying in lookup_name_info
Testsuite logs (gdb.sum, gdb.log and others):
https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/e0/e0802d59969339502203ad8e0d161b5f93beca73/
*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: run to foo
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
==============================================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.gz>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.table.gz>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Failures on Fedora-x86_64-native-gdbserver-m64, branch master
2020-04-14 11:25 [binutils-gdb] Avoid copying in lookup_name_info gdb-buildbot
` (6 preceding siblings ...)
2020-04-17 4:58 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
@ 2020-04-17 23:29 ` gdb-buildbot
7 siblings, 0 replies; 9+ messages in thread
From: gdb-buildbot @ 2020-04-17 23:29 UTC (permalink / raw)
To: gdb-testers
Buildername:
Fedora-x86_64-native-gdbserver-m64
Worker:
fedora-x86-64-4
Full Build URL:
https://gdb-buildbot.osci.io/#builders/22/builds/2609
Author:
Tom Tromey <tromey@adacore.com>
Commit tested:
e0802d59969339502203ad8e0d161b5f93beca73
Subject of commit:
Avoid copying in lookup_name_info
Testsuite logs (gdb.sum, gdb.log and others):
https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/e0/e0802d59969339502203ad8e0d161b5f93beca73/
*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print j
new KFAIL: gdb.threads/watchthreads2.exp: gdb can drop watchpoints in multithreaded app
==============================================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.gz>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/e0/e0802d59969339502203ad8e0d161b5f93beca73//xfail.table.gz>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-04-17 23:29 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14 11:25 [binutils-gdb] Avoid copying in lookup_name_info gdb-buildbot
2020-04-14 11:25 ` Failures on Fedora-i686, branch master gdb-buildbot
2020-04-14 11:38 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2020-04-14 12:17 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2020-04-14 12:27 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2020-04-14 13:15 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2020-04-14 13:28 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2020-04-17 4:58 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2020-04-17 23:29 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).