public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Remove some includes of readline.h
Date: Wed, 06 Nov 2019 15:31:00 -0000 [thread overview]
Message-ID: <e0eac551da0afeec8ec17f457e4e1da1756e0aab@gdb-build> (raw)
*** TEST RESULTS FOR COMMIT e0eac551da0afeec8ec17f457e4e1da1756e0aab ***
commit e0eac551da0afeec8ec17f457e4e1da1756e0aab
Author: Tom Tromey <tom@tromey.com>
AuthorDate: Sun Oct 27 15:50:54 2019 -0600
Commit: Tom Tromey <tom@tromey.com>
CommitDate: Wed Nov 6 07:29:43 2019 -0700
Remove some includes of readline.h
I went through most of the spots that include readline.h and, when
appropriate, either removed the include or changed it to include
tilde.h.
Note that remote-sim.c and bsd-kvm.c could probably include tilde.h
instead, but I did not change these. I think I can't build the
latter, and I didn't want to set up a sim build for the former.
Tested by rebuilding.
gdb/ChangeLog
2019-11-06 Tom Tromey <tom@tromey.com>
* tui/tui-interp.c: Don't include readline.h.
* tui/tui-hooks.c: Don't include readline.h.
* symmisc.c: Include tilde.h, not readline.h.
* symfile.c: Include tilde.h, not readline.h.
* source.c: Include tilde.h, not readline.h.
* solib.c: Include tilde.h, not readline.h.
* psymtab.c: Include tilde.h, not readline.h.
* exec.c: Include tilde.h, not readline.h.
* corelow.c: Include tilde.h, not readline.h.
* cli/cli-dump.c: Include tilde.h, not readline.h.
* cli/cli-cmds.c: Don't include readline.h.
Change-Id: I60487a190c43128b800ef77517d1ab42957571d7
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e886480d62..048c2dd484 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,17 @@
+2019-11-06 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-interp.c: Don't include readline.h.
+ * tui/tui-hooks.c: Don't include readline.h.
+ * symmisc.c: Include tilde.h, not readline.h.
+ * symfile.c: Include tilde.h, not readline.h.
+ * source.c: Include tilde.h, not readline.h.
+ * solib.c: Include tilde.h, not readline.h.
+ * psymtab.c: Include tilde.h, not readline.h.
+ * exec.c: Include tilde.h, not readline.h.
+ * corelow.c: Include tilde.h, not readline.h.
+ * cli/cli-dump.c: Include tilde.h, not readline.h.
+ * cli/cli-cmds.c: Don't include readline.h.
+
2019-11-05 Tom Tromey <tom@tromey.com>
* tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c
index 4e58ddc6d6..409240c118 100644
--- a/gdb/cli/cli-cmds.c
+++ b/gdb/cli/cli-cmds.c
@@ -19,7 +19,6 @@
#include "defs.h"
#include "arch-utils.h"
-#include "readline/readline.h"
#include "readline/tilde.h"
#include "completer.h"
#include "target.h" /* For baud_rate, remote_debug and remote_timeout. */
diff --git a/gdb/cli/cli-dump.c b/gdb/cli/cli-dump.c
index 74e0057d4a..7c4f63be06 100644
--- a/gdb/cli/cli-dump.c
+++ b/gdb/cli/cli-dump.c
@@ -26,7 +26,7 @@
#include "completer.h"
#include <ctype.h>
#include "target.h"
-#include "readline/readline.h"
+#include "readline/tilde.h"
#include "gdbcore.h"
#include "cli/cli-utils.h"
#include "gdb_bfd.h"
diff --git a/gdb/corelow.c b/gdb/corelow.c
index b32fa955fd..fa1661ee61 100644
--- a/gdb/corelow.c
+++ b/gdb/corelow.c
@@ -35,7 +35,7 @@
#include "regset.h"
#include "symfile.h"
#include "exec.h"
-#include "readline/readline.h"
+#include "readline/tilde.h"
#include "solib.h"
#include "filenames.h"
#include "progspace.h"
diff --git a/gdb/exec.c b/gdb/exec.c
index 6bdf9abb3e..efc504eca4 100644
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -38,7 +38,7 @@
#include "source.h"
#include <fcntl.h>
-#include "readline/readline.h"
+#include "readline/tilde.h"
#include "gdbcore.h"
#include <ctype.h>
diff --git a/gdb/psymtab.c b/gdb/psymtab.c
index df10a756fd..67e3e36aa9 100644
--- a/gdb/psymtab.c
+++ b/gdb/psymtab.c
@@ -28,7 +28,7 @@
#include "gdbtypes.h"
#include "ui-out.h"
#include "command.h"
-#include "readline/readline.h"
+#include "readline/tilde.h"
#include "gdb_regex.h"
#include "dictionary.h"
#include "language.h"
diff --git a/gdb/solib.c b/gdb/solib.c
index 17d0c4cea2..400fddedb6 100644
--- a/gdb/solib.c
+++ b/gdb/solib.c
@@ -39,7 +39,7 @@
#include "exec.h"
#include "solist.h"
#include "observable.h"
-#include "readline/readline.h"
+#include "readline/tilde.h"
#include "remote.h"
#include "solib.h"
#include "interps.h"
diff --git a/gdb/source.c b/gdb/source.c
index 9f53d654f3..d9cd5f32ca 100644
--- a/gdb/source.c
+++ b/gdb/source.c
@@ -40,7 +40,7 @@
#include "filenames.h" /* for DOSish file names */
#include "completer.h"
#include "ui-out.h"
-#include "readline/readline.h"
+#include "readline/tilde.h"
#include "gdbsupport/enum-flags.h"
#include "gdbsupport/scoped_fd.h"
#include <algorithm>
diff --git a/gdb/symfile.c b/gdb/symfile.c
index c5d226ec0d..e6b34bc6b7 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -44,7 +44,7 @@
#include "completer.h"
#include "bcache.h"
#include "hashtab.h"
-#include "readline/readline.h"
+#include "readline/tilde.h"
#include "block.h"
#include "observable.h"
#include "exec.h"
diff --git a/gdb/symmisc.c b/gdb/symmisc.c
index c91ad5e5f4..24ee255f6b 100644
--- a/gdb/symmisc.c
+++ b/gdb/symmisc.c
@@ -36,7 +36,7 @@
#include "typeprint.h"
#include "gdbcmd.h"
#include "source.h"
-#include "readline/readline.h"
+#include "readline/tilde.h"
#include "psymtab.h"
diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c
index 2555da7f1a..bb96f4d9bb 100644
--- a/gdb/tui/tui-hooks.c
+++ b/gdb/tui/tui-hooks.c
@@ -49,11 +49,6 @@
#include "gdb_curses.h"
-/* This redefines CTRL if it is not already defined, so it must come
- after terminal state releated include files like <term.h> and
- "gdb_curses.h". */
-#include "readline/readline.h"
-
static void
tui_new_objfile_hook (struct objfile* objfile)
{
diff --git a/gdb/tui/tui-interp.c b/gdb/tui/tui-interp.c
index ea562acb6c..bc8fde363b 100644
--- a/gdb/tui/tui-interp.c
+++ b/gdb/tui/tui-interp.c
@@ -26,7 +26,6 @@
#include "ui-out.h"
#include "cli-out.h"
#include "tui/tui-data.h"
-#include "readline/readline.h"
#include "tui/tui-win.h"
#include "tui/tui.h"
#include "tui/tui-io.h"
next reply other threads:[~2019-11-06 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 15:31 gdb-buildbot [this message]
2019-11-06 15:31 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master gdb-buildbot
2019-11-22 21:23 ` Failures on Fedora-i686, " gdb-buildbot
2019-11-22 21:34 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2019-11-22 22:13 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2019-11-22 22:20 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2019-11-22 23:16 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2019-11-23 0:04 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0eac551da0afeec8ec17f457e4e1da1756e0aab@gdb-build \
--to=gdb-buildbot@sergiodj.net \
--cc=gdb-testers@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).