[binutils-gdb] gdb: Don't print a newline in language la_print_typedef methods

[binutils-gdb] gdb: Don't print a newline in language la_print_typedef methods

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT e170989694aecb458d1bbb6a1db6bb712ced707d ***

commit e170989694aecb458d1bbb6a1db6bb712ced707d
Author:     Andrew Burgess <andrew.burgess@embecosm.com>
AuthorDate: Tue Sep 24 23:01:14 2019 +0100
Commit:     Andrew Burgess <andrew.burgess@embecosm.com>
CommitDate: Thu Oct 31 23:02:59 2019 +0000

    gdb: Don't print a newline in language la_print_typedef methods
    
    When calling the language la_print_typedef method, don't include a
    newline at the end, instead print the newline from the users of
    la_print_typedef.
    
    This change will be useful in a later commit when the output from
    la_print_typedef will be placed into an MI output field, in which case
    the trailing newline is not required.
    
    There should be no user visible changes after this commit.
    
    gdb/ChangeLog:
    
            * ada-typeprint.c (ada_print_typedef): Don't print newline at the
            end.
            * c-typeprint.c (c_print_typedef): Likewise.
            * f-typeprint.c (f_print_typedef): Likewise.
            * m2-typeprint.c (m2_print_typedef): Likewise.
            * p-typeprint.c (pascal_print_typedef): Likewise.
            * rust-lang.c (rust_print_typedef): Likewise.
            * symtab.c (print_symbol_info): Print a newline after calling
            typedef_print.
    
    Change-Id: I6e697ea1ec0eadaa31aefaea959b2055188d680d

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2bd67260dc..381147b321 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,15 @@
+2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+	* ada-typeprint.c (ada_print_typedef): Don't print newline at the
+	end.
+	* c-typeprint.c (c_print_typedef): Likewise.
+	* f-typeprint.c (f_print_typedef): Likewise.
+	* m2-typeprint.c (m2_print_typedef): Likewise.
+	* p-typeprint.c (pascal_print_typedef): Likewise.
+	* rust-lang.c (rust_print_typedef): Likewise.
+	* symtab.c (print_symbol_info): Print a newline after calling
+	typedef_print.
+
 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	* symtab.c (info_module_cmdlist): New variable.
diff --git a/gdb/ada-typeprint.c b/gdb/ada-typeprint.c
index be379254aa..f89dd23ed8 100644
--- a/gdb/ada-typeprint.c
+++ b/gdb/ada-typeprint.c
@@ -945,5 +945,4 @@ ada_print_typedef (struct type *type, struct symbol *new_symbol,
 {
   type = ada_check_typedef (type);
   ada_print_type (type, "", stream, 0, 0, &type_print_raw_options);
-  fprintf_filtered (stream, "\n");
 }
diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c
index 1a37c4edfb..e0f1714da1 100644
--- a/gdb/c-typeprint.c
+++ b/gdb/c-typeprint.c
@@ -211,7 +211,7 @@ c_print_typedef (struct type *type,
 		 SYMBOL_LINKAGE_NAME (new_symbol)) != 0
       || TYPE_CODE (SYMBOL_TYPE (new_symbol)) == TYPE_CODE_TYPEDEF)
     fprintf_filtered (stream, " %s", SYMBOL_PRINT_NAME (new_symbol));
-  fprintf_filtered (stream, ";\n");
+  fprintf_filtered (stream, ";");
 }
 
 /* If TYPE is a derived type, then print out derivation information.
diff --git a/gdb/f-typeprint.c b/gdb/f-typeprint.c
index 0093aebddc..027bcdde0f 100644
--- a/gdb/f-typeprint.c
+++ b/gdb/f-typeprint.c
@@ -54,7 +54,6 @@ f_print_typedef (struct type *type, struct symbol *new_symbol,
 {
   type = check_typedef (type);
   f_print_type (type, "", stream, 0, 0, &type_print_raw_options);
-  fprintf_filtered (stream, "\n");
 }
 
 /* LEVEL is the depth to indent lines by.  */
diff --git a/gdb/m2-typeprint.c b/gdb/m2-typeprint.c
index 3c1a8d2aed..e81a9e5688 100644
--- a/gdb/m2-typeprint.c
+++ b/gdb/m2-typeprint.c
@@ -170,7 +170,7 @@ m2_print_typedef (struct type *type, struct symbol *new_symbol,
   else
     fprintf_filtered (stream, "<builtin> = ");
   type_print (type, "", stream, 0);
-  fprintf_filtered (stream, ";\n");
+  fprintf_filtered (stream, ";");
 }
 
 /* m2_type_name - if a, type, has a name then print it.  */
diff --git a/gdb/p-typeprint.c b/gdb/p-typeprint.c
index fadc44eaee..da30d4a3ac 100644
--- a/gdb/p-typeprint.c
+++ b/gdb/p-typeprint.c
@@ -101,7 +101,7 @@ pascal_print_typedef (struct type *type, struct symbol *new_symbol,
   fprintf_filtered (stream, "type ");
   fprintf_filtered (stream, "%s = ", SYMBOL_PRINT_NAME (new_symbol));
   type_print (type, "", stream, 0);
-  fprintf_filtered (stream, ";\n");
+  fprintf_filtered (stream, ";");
 }
 
 /* If TYPE is a derived type, then print out derivation information.
diff --git a/gdb/rust-lang.c b/gdb/rust-lang.c
index cef0a9cb09..838d9019ad 100644
--- a/gdb/rust-lang.c
+++ b/gdb/rust-lang.c
@@ -831,7 +831,7 @@ rust_print_typedef (struct type *type,
   type = check_typedef (type);
   fprintf_filtered (stream, "type %s = ", SYMBOL_PRINT_NAME (new_symbol));
   type_print (type, "", stream, 0);
-  fprintf_filtered (stream, ";\n");
+  fprintf_filtered (stream, ";");
 }
 
 /* la_print_type implementation for Rust.  */
diff --git a/gdb/symtab.c b/gdb/symtab.c
index 72a54ec1ca..2c934b9c22 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -4774,10 +4774,8 @@ print_symbol_info (enum search_domain kind,
       if (TYPE_CODE (SYMBOL_TYPE (sym)) == TYPE_CODE_TYPEDEF)
 	typedef_print (SYMBOL_TYPE (sym), sym, gdb_stdout);
       else
-	{
-	  type_print (SYMBOL_TYPE (sym), "", gdb_stdout, -1);
-	  printf_filtered ("\n");
-	}
+	type_print (SYMBOL_TYPE (sym), "", gdb_stdout, -1);
+      printf_filtered ("\n");
     }
   /* variable, func, or typedef-that-is-c++-class.  */
   else if (kind < TYPES_DOMAIN

Failures on Ubuntu-Aarch64-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/8/builds/1092

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        e170989694aecb458d1bbb6a1db6bb712ced707d

Subject of commit:
        gdb: Don't print a newline in language la_print_typedef methods

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/e1/e170989694aecb458d1bbb6a1db6bb712ced707d/

*** Diff to previous build ***
==============================================
new KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
new KFAIL: gdb.xml/tdesc-arch.exp: set tdesc filename tdesc-arch.xml
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/e1/e170989694aecb458d1bbb6a1db6bb712ced707d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/e1/e170989694aecb458d1bbb6a1db6bb712ced707d//xfail.table.gz>

Failures on Fedora-i686, branch master

[gdb-buildbot]

Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/18/builds/1225

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        e170989694aecb458d1bbb6a1db6bb712ced707d

Subject of commit:
        gdb: Don't print a newline in language la_print_typedef methods

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/e1/e170989694aecb458d1bbb6a1db6bb712ced707d/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.cp/cpcompletion.exp: expression with namespace: cmd complete "p Test_NS"
PASS -> FAIL: gdb.cp/cpcompletion.exp: expression with namespace: tab complete "p Test_NS"
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/e1/e170989694aecb458d1bbb6a1db6bb712ced707d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/e1/e170989694aecb458d1bbb6a1db6bb712ced707d//xfail.table.gz>

Failures on Fedora-x86_64-cc-with-index, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/20/builds/1170

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        e170989694aecb458d1bbb6a1db6bb712ced707d

Subject of commit:
        gdb: Don't print a newline in language la_print_typedef methods

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/e1/e170989694aecb458d1bbb6a1db6bb712ced707d/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/e1/e170989694aecb458d1bbb6a1db6bb712ced707d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/e1/e170989694aecb458d1bbb6a1db6bb712ced707d//xfail.table.gz>

Failures on Fedora-x86_64-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/17/builds/1224

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        e170989694aecb458d1bbb6a1db6bb712ced707d

Subject of commit:
        gdb: Don't print a newline in language la_print_typedef methods

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/e1/e170989694aecb458d1bbb6a1db6bb712ced707d/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.cp/cpcompletion.exp: expression with namespace: cmd complete "p Test_NS:"
PASS -> FAIL: gdb.cp/cpcompletion.exp: expression with namespace: tab complete "p Test_NS::"
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/e1/e170989694aecb458d1bbb6a1db6bb712ced707d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/e1/e170989694aecb458d1bbb6a1db6bb712ced707d//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/2/builds/1222

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        e170989694aecb458d1bbb6a1db6bb712ced707d

Subject of commit:
        gdb: Don't print a newline in language la_print_typedef methods

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/e1/e170989694aecb458d1bbb6a1db6bb712ced707d/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/e1/e170989694aecb458d1bbb6a1db6bb712ced707d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/e1/e170989694aecb458d1bbb6a1db6bb712ced707d//xfail.table.gz>

*** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, branch master *** BREAKAGE ***

[gdb-buildbot]

Buildername:
        Fedora-x86_64-w64-mingw32

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/23/builds/1011

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        e170989694aecb458d1bbb6a1db6bb712ced707d

Subject of commit:
        gdb: Don't print a newline in language la_print_typedef methods

*** FAILED to build GDB -- compile gdb ***
==============================================

+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

  CXX    corefile.o
  CXX    corelow.o
  CXX    cp-abi.o
  YACC   cp-name-parser.c
  CXX    cp-namespace.o
  CXX    cp-support.o
  CXX    cp-valprint.o
  CXX    cris-linux-tdep.o
  CXX    cris-tdep.o
  CXX    csky-linux-tdep.o
  CXX    csky-tdep.o
  CXX    ctfread.o
  YACC   d-exp.c
  CXX    d-lang.o
  CXX    d-namespace.o
  CXX    d-valprint.o
  CXX    dbxread.o
  CXX    dcache.o
  CXX    debug.o
  CXX    demangle.o
  CXX    dicos-tdep.o
  CXX    dictionary.o
  CXX    disasm-selftests.o
  CXX    disasm.o
  CXX    dtrace-probe.o
  CXX    dummy-frame.o
  CXX    dwarf-index-cache.o
  CXX    dwarf-index-common.o
  CXX    dwarf-index-write.o
  CXX    dwarf2-frame-tailcall.o
  CXX    dwarf2-frame.o
  CXX    dwarf2expr.o
  CXX    dwarf2loc.o
  CXX    dwarf2read.o
  CXX    elfread.o
  CXX    eval.o
  CXX    event-loop.o
  CXX    event-top.o
  CXX    exceptions.o
  CXX    exec.o
  CXX    expprint.o
  CXX    extension.o
  YACC   f-exp.c
  CXX    f-lang.o
  CXX    f-typeprint.o
  CXX    f-valprint.o
  CXX    fbsd-tdep.o
  CXX    filename-seen-cache.o
  CXX    filesystem.o
  CXX    findcmd.o
  CXX    findvar.o
  CXX    frame-base.o
  CXX    frame-unwind.o
  CXX    frame.o
  CXX    frv-linux-tdep.o
  CXX    frv-tdep.o
  CXX    ft32-tdep.o
  CXX    gcore.o
  CXX    gdb_bfd.o
  CXX    gdb_obstack.o
  CXX    gdb_regex.o
  CXX    gdbarch-selftests.o
  CXX    gdbarch.o
  CXX    gdbsupport/agent.o
  CXX    gdbsupport/btrace-common.o
  CXX    gdbsupport/buffer.o
  CXX    gdbsupport/cleanups.o
  CXX    gdbsupport/common-debug.o
  CXX    gdbsupport/common-exceptions.o
  CXX    gdbsupport/common-inferior.o
  CXX    gdbsupport/common-regcache.o
  CXX    gdbsupport/common-utils.o
  CXX    gdbsupport/environ.o
  CXX    gdbsupport/errors.o
  CXX    gdbsupport/fileio.o
  CXX    gdbsupport/filestuff.o
  CXX    gdbsupport/format.o
  CXX    gdbsupport/gdb-dlfcn.o
  CXX    gdbsupport/gdb_tilde_expand.o
  CXX    gdbsupport/gdb_vecs.o
  CXX    gdbsupport/job-control.o
  CXX    gdbsupport/mingw-strerror.o
  CXX    gdbsupport/netstuff.o
../../binutils-gdb/gdb/gdbsupport/mingw-strerror.c:32:1: error: ambiguating new declaration of 'char* safe_strerror(int)'
 safe_strerror (int errnum)
 ^~~~~~~~~~~~~
In file included from ../../binutils-gdb/gdb/gdbsupport/common-defs.h:122,
                 from ../../binutils-gdb/gdb/gdbsupport/mingw-strerror.c:20:
../../binutils-gdb/gdb/gdbsupport/common-utils.h:113:20: note: old declaration 'const char* safe_strerror(int)'
 extern const char *safe_strerror (int);
                    ^~~~~~~~~~~~~
make[2]: *** [Makefile:1642: gdbsupport/mingw-strerror.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64-mingw32/build/gdb'
make[1]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64-mingw32/build'
make[1]: *** [Makefile:8917: all-gdb] Error 2
make: *** [Makefile:859: all] Error 2
program finished with exit code 2
elapsedTime=366.250735
==============================================

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/22/builds/1220

Author:
        Andrew Burgess <andrew.burgess@embecosm.com>

Commit tested:
        e170989694aecb458d1bbb6a1db6bb712ced707d

Subject of commit:
        gdb: Don't print a newline in language la_print_typedef methods

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/e1/e170989694aecb458d1bbb6a1db6bb712ced707d/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/e1/e170989694aecb458d1bbb6a1db6bb712ced707d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/e1/e170989694aecb458d1bbb6a1db6bb712ced707d//xfail.table.gz>