[binutils-gdb] Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

[binutils-gdb] Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT e20773049fde7b9a123fda4485259fc06249b22f ***

Author: tromey <tromey@138bc75d-0d04-0410-961f-82ee72b054a4>
Branch: master
Commit: e20773049fde7b9a123fda4485259fc06249b22f

Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

When a node is removed from a splay tree, the splay tree was
not using the function splay_tree_delete_key_fn to release the key.
This was causing a leak, fixed by Tom Tromey.

This patch fixes another key leak, that happens when a key equal to
a key already present is inserted.  In such a case, we have to release
the old KEY.
Note that this is based on the assumption that the caller always
allocates a new KEY when doing an insert.

Also, clarify the documentation about when the release functions are
called.

2019-02-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

	* splay-tree.h (splay_tree_delete_key_fn): Update comment.
	(splay_tree_delete_value_fn): Likewise.

libiberty/ChangeLog
2019-02-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

	* splay-tree.c (splay_tree_insert): Also release old KEY in case
	of insertion of a key equal to an already present key.
	(splay_tree_new_typed_alloc): Update comment.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@268793 138bc75d-0d04-0410-961f-82ee72b054a4

Failures on RHEL-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	rhel-7_1-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/RHEL-s390x-m64/builds/9226>

Commit(s) tested:
	e20773049fde7b9a123fda4485259fc06249b22f

Author(s) (in the same order as the commits):
	tromey <tromey@138bc75d-0d04-0410-961f-82ee72b054a4>

Subject:
	Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/RHEL-s390x-m64/e2/e20773049fde7b9a123fda4485259fc06249b22f/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/RHEL-s390x-m64/xfails/master/xfail?id=10f9d4c6>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/RHEL-s390x-m64/xfails/master/xfail.table?id=10f9d4c6>

Failures on Fedora-i686, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-2

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/12005>

Commit(s) tested:
	e20773049fde7b9a123fda4485259fc06249b22f

Author(s) (in the same order as the commits):
	tromey <tromey@138bc75d-0d04-0410-961f-82ee72b054a4>

Subject:
	Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-i686/e2/e20773049fde7b9a123fda4485259fc06249b22f/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.python/py-mi-var-info-path-expression.exp: -var-list-children c1
PASS -> FAIL: gdb.python/py-mi-var-info-path-expression.exp: -var-list-children c1.car
PASS -> FAIL: gdb.python/py-mi-var-info-path-expression.exp: -var-list-children c1.car.atom
PASS -> FAIL: gdb.python/py-mi-var-info-path-expression.exp: -var-list-children c1.cdr
PASS -> UNRESOLVED: gdb.python/py-mi-var-info-path-expression.exp: load python file
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-i686/xfails/master/xfail?id=d61c6318>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-i686/xfails/master/xfail.table?id=d61c6318>

Failures on Debian-s390x-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-extended-gdbserver-m64/builds/7529>

Commit(s) tested:
	e20773049fde7b9a123fda4485259fc06249b22f

Author(s) (in the same order as the commits):
	tromey <tromey@138bc75d-0d04-0410-961f-82ee72b054a4>

Subject:
	Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-native-extended-gdbserver-m64/e2/e20773049fde7b9a123fda4485259fc06249b22f/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-extended-gdbserver-m64/xfails/master/xfail?id=d3f5d138>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-extended-gdbserver-m64/xfails/master/xfail.table?id=d3f5d138>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/11959>

Commit(s) tested:
	e20773049fde7b9a123fda4485259fc06249b22f

Author(s) (in the same order as the commits):
	tromey <tromey@138bc75d-0d04-0410-961f-82ee72b054a4>

Subject:
	Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m64/e2/e20773049fde7b9a123fda4485259fc06249b22f/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail?id=4e2b4faf>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail.table?id=4e2b4faf>

Failures on Debian-s390x-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-gdbserver-m64/builds/7386>

Commit(s) tested:
	e20773049fde7b9a123fda4485259fc06249b22f

Author(s) (in the same order as the commits):
	tromey <tromey@138bc75d-0d04-0410-961f-82ee72b054a4>

Subject:
	Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-native-gdbserver-m64/e2/e20773049fde7b9a123fda4485259fc06249b22f/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-gdbserver-m64/xfails/master/xfail?id=4205eb66>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-gdbserver-m64/xfails/master/xfail.table?id=4205eb66>

Failures on Fedora-x86_64-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/12090>

Commit(s) tested:
	e20773049fde7b9a123fda4485259fc06249b22f

Author(s) (in the same order as the commits):
	tromey <tromey@138bc75d-0d04-0410-961f-82ee72b054a4>

Subject:
	Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m64/e2/e20773049fde7b9a123fda4485259fc06249b22f/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m64/xfails/master/xfail?id=7925b7ab>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m64/xfails/master/xfail.table?id=7925b7ab>

Failures on Debian-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-m64/builds/7344>

Commit(s) tested:
	e20773049fde7b9a123fda4485259fc06249b22f

Author(s) (in the same order as the commits):
	tromey <tromey@138bc75d-0d04-0410-961f-82ee72b054a4>

Subject:
	Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-m64/e2/e20773049fde7b9a123fda4485259fc06249b22f/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail?id=c2bcd45a>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail.table?id=c2bcd45a>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-2

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m64/builds/11923>

Commit(s) tested:
	e20773049fde7b9a123fda4485259fc06249b22f

Author(s) (in the same order as the commits):
	tromey <tromey@138bc75d-0d04-0410-961f-82ee72b054a4>

Subject:
	Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m64/e2/e20773049fde7b9a123fda4485259fc06249b22f/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.fortran/derived-type-function.exp: Print rectangle structure with members' name
PASS -> FAIL: gdb.fortran/derived-type-function.exp: continue to breakpoint: bp
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail?id=437abd84>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail.table?id=437abd84>

Failures on Fedora-x86_64-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/11758>

Commit(s) tested:
	e20773049fde7b9a123fda4485259fc06249b22f

Author(s) (in the same order as the commits):
	tromey <tromey@138bc75d-0d04-0410-961f-82ee72b054a4>

Subject:
	Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m32/e2/e20773049fde7b9a123fda4485259fc06249b22f/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m32/xfails/master/xfail?id=9bc56703>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m32/xfails/master/xfail.table?id=9bc56703>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m32/builds/11686>

Commit(s) tested:
	e20773049fde7b9a123fda4485259fc06249b22f

Author(s) (in the same order as the commits):
	tromey <tromey@138bc75d-0d04-0410-961f-82ee72b054a4>

Subject:
	Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m32/e2/e20773049fde7b9a123fda4485259fc06249b22f/>