public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] Don't redefine upload/download/file in gdbserver-base Date: Thu, 08 Mar 2018 23:13:00 -0000 [thread overview] Message-ID: <e4fe3756763773940b003159649f224a5ac42ee0@gdb-build> (raw) *** TEST RESULTS FOR COMMIT e4fe3756763773940b003159649f224a5ac42ee0 *** Author: Simon Marchi <simon.marchi@polymtl.ca> Branch: master Commit: e4fe3756763773940b003159649f224a5ac42ee0 Don't redefine upload/download/file in gdbserver-base Before patch Make native gdbserver boards no longer be "remote" (in DejaGnu terms) 739b3f1d8ff7072dcc66240c25b026c6433bda1a the local gdbserver boards (except native-extended-gdbserver...) were considered as remote by DejaGNU. To avoid DejaGNU trying to use ssh/scp to download the files to the target (which is actually local), the gdbserver-base.exp file defined some _download, _upload and _file board operations to override the default behavior, and instead just use local operations. The same patch also changed remote-stdio-gdbserver.exp to make it inherit from gdbserver-base.exp. Since then, this board (which is actually remote) uses the overrides with local file operations. As a result, files are never actually copied to the target. I think we can simply remove the overrides from gdbserver-base.exp. Because all boards should be properly considered local or remote by DejaGNU, it should by default use the right method for transferring files. gdb/testsuite/ChangeLog: PR gdb/22841 * boards/gdbserver-base.exp (${board}_file, ${board}_download, ${board}_upload): Remove.
next reply other threads:[~2018-03-08 23:13 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-08 23:13 sergiodj+buildbot [this message] 2018-03-08 23:13 ` Failures on Debian-s390x-m64, branch master sergiodj+buildbot 2018-03-08 23:27 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot 2018-03-08 23:27 ` Failures on Fedora-i686, " sergiodj+buildbot 2018-03-08 23:39 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot 2018-03-08 23:41 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot 2018-03-08 23:48 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot 2018-03-08 23:58 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot 2018-03-09 12:37 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot 2018-03-09 12:56 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot 2018-03-09 13:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot 2018-03-09 13:34 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e4fe3756763773940b003159649f224a5ac42ee0@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).