public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Simplify gdb.reverse/until-reverse.c
@ 2016-03-30 16:17 sergiodj+buildbot
  2016-03-30 16:39 ` Failures on AIX-POWER7-plain, branch master sergiodj+buildbot
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: sergiodj+buildbot @ 2016-03-30 16:17 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT e6359af3fdda6b9265565ecbd213763244ed8594 ***

Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: e6359af3fdda6b9265565ecbd213763244ed8594

Simplify gdb.reverse/until-reverse.c

Nowadays, functions fprintf, printf and malloc are executed in
gdb.reverse/until-reverse.c, so that it takes much time to record
instructions inside them.  This may cause timeout, and we had several
fixes to bump the timeout,

 https://sourceware.org/ml/gdb-patches/2012-02/msg00038.html
 https://sourceware.org/ml/gdb-patches/2015-08/msg00186.html

also I still see this on arm-linux,

 continue
 Continuing.
 Do you want to auto delete previous execution log entries when record/replay buffer becomes full (record full stop-at-limit)?([y] or n) n
 Process record: stopped by user.

 Program stopped.
 0xf77021e6 in __linkin_atfork (newp=0xf7751748 <atfork_mem>) at ../nptl/sysdeps/unix/sysv/linux/register-atfork.c:117
 117     ../nptl/sysdeps/unix/sysv/linux/register-atfork.c: No such file or directory.
 (gdb) FAIL: gdb.reverse/until-precsave.exp: run to end of main (got interactive prompt)

however, I can't figure out how these functions (fprintf, printf and
malloc) are related to the test itself.  marker1 is a function from
shared library too so we don't need these complicated libc functions
at all.  IMO, recording the instructions in these libc functions has
nothing to do with the test itself except slow down the test.  This
patch is to remove the usage of fprintf and printf, and also move
malloc to a dead code path.

gdb/testsuite:

2016-03-30  Yao Qi  <yao.qi@linaro.org>

	* gdb.reverse/until-precsave.exp: Match function name only.
	* gdb.reverse/until-reverse.c (main): Don't call fprintf nor printf.
	Move malloc to a condition block.
	* gdb.reverse/until-reverse.exp: Match function name only.


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-03-30 20:07 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-30 16:17 [binutils-gdb] Simplify gdb.reverse/until-reverse.c sergiodj+buildbot
2016-03-30 16:39 ` Failures on AIX-POWER7-plain, branch master sergiodj+buildbot
2016-03-30 17:09 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot
2016-03-30 17:24 ` Failures on Debian-x86_64-m64, " sergiodj+buildbot
2016-03-30 18:17 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-03-30 19:05 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2016-03-30 20:41 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).