public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@redhat.com To: gdb-testers@sourceware.org Subject: [binutils-gdb] xtensa: fix localized symbol refcounting with --gc-sections Date: Thu, 14 May 2015 04:11:00 -0000 [thread overview] Message-ID: <e6c9a083ec5ae7a45bd71682b26aae1939849388@kwanyin> (raw) *** TEST RESULTS FOR COMMIT e6c9a083ec5ae7a45bd71682b26aae1939849388 *** Author: Max Filippov <jcmvbkbc@gmail.com> Branch: master Commit: e6c9a083ec5ae7a45bd71682b26aae1939849388 xtensa: fix localized symbol refcounting with --gc-sections elf_xtensa_gc_sweep_hook doesn't correctly unreference symbols that were made local, that results in link failure with the following message: BFD (GNU Binutils) 2.24 internal error, aborting at elf32-xtensa.c line 3372 in elf_xtensa_finish_dynamic_sections elf_xtensa_gc_sweep_hook determines symbol reference type (PLT or GOT) by relocation type. Relocation types are not changed when symbol becomes local, but its PLT references are added to GOT references and plt.refcount is set to 0. Such symbol cannot be unreferences in the elf_xtensa_gc_sweep_hook and its extra references make calculated GOT relocations section size not match number of GOT relocations. Fix it by treating PLT reference as GOT reference when plt.refcount is not positive. 2015-05-14 Max Filippov <jcmvbkbc@gmail.com> bfd/ * elf32-xtensa.c (elf_xtensa_gc_sweep_hook): Treat PLT reference as GOT reference when plt.refcount is not positive.
next reply other threads:[~2015-05-14 4:11 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-14 4:11 sergiodj+buildbot [this message] 2015-05-14 4:22 ` Failures on Fedora-ppc64be-cc-with-index, branch master sergiodj+buildbot 2015-05-14 4:40 ` Failures on Fedora-s390x-m64, " sergiodj+buildbot 2015-05-14 4:44 ` Failures on Fedora-ppc64be-m64, " sergiodj+buildbot 2015-05-14 4:52 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot 2015-05-14 6:17 ` Failures on Debian-i686, " sergiodj+buildbot 2015-05-14 6:33 ` Failures on Debian-i686-native-gdbserver, " sergiodj+buildbot 2015-05-14 7:29 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot 2015-05-14 17:20 ` Failures on Fedora-i686, " sergiodj+buildbot 2015-05-14 17:43 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot 2015-05-14 18:07 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot 2015-05-14 18:27 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot 2015-05-14 18:57 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e6c9a083ec5ae7a45bd71682b26aae1939849388@kwanyin \ --to=sergiodj+buildbot@redhat.com \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).