public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] microblaze-tdep: Add ATTRIBUTE_PRINTF to microblaze_debug
Date: Thu, 21 Sep 2017 12:52:00 -0000	[thread overview]
Message-ID: <ebe48ba0856dcccaa7a60d873c61e6f1f96f5887@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT ebe48ba0856dcccaa7a60d873c61e6f1f96f5887 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: ebe48ba0856dcccaa7a60d873c61e6f1f96f5887

microblaze-tdep: Add ATTRIBUTE_PRINTF to microblaze_debug

I am getting this warning with clang:

/home/emaisin/src/binutils-gdb/gdb/microblaze-tdep.c:94:28: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
       vprintf_unfiltered (fmt, args);
                           ^~~

Adding ATTRIBUTE_PRINTF to microblaze_debug gets rid of it.  Strangely,
gcc doesn't warn about non-literal format strings when calling vprintf
(or a vprintf-style function, like vprintf_unfiltered).  I filed this
gcc bug:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82206

gdb/ChangeLog:

	* microblaze-tdep.c (microblaze_debug): Add ATTRIBUTE_PRINTF.


             reply	other threads:[~2017-09-21 12:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-21 12:52 sergiodj+buildbot [this message]
2017-09-21 13:01 ` Failures on Fedora-i686, branch master sergiodj+buildbot
2017-09-21 13:07 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2017-09-21 13:09 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2017-09-21 13:11 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
2017-09-21 13:19 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2017-09-21 13:35 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2017-09-21 13:35 ` Failures on Fedora-s390x-m64, " sergiodj+buildbot
2017-09-21 13:37 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
2017-09-21 13:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-09-21 14:01 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebe48ba0856dcccaa7a60d873c61e6f1f96f5887@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).