[binutils-gdb] gdb: Handle requests to print source lines backward

[binutils-gdb] gdb: Handle requests to print source lines backward

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT ec98a4ad5bfcba33deb5cb786c023082adbbfb46 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: ec98a4ad5bfcba33deb5cb786c023082adbbfb46

gdb: Handle requests to print source lines backward

...by which I mean from high line number to low, not, actually
backward character by character!

Commit:

  commit 62f29fda90cf1d5a1899f57ef78452471c707fd6
  Date:   Tue Oct 9 22:21:05 2018 -0600

      Highlight source code using GNU Source Highlight

introduced a regression in the test gdb.linespec/explicit.exp, in
which a request is made to GDB to print a reverse sequence of lines,
from +10 to -10 from the current line number.  The expected behaviour
is that GDB prints nothing.  The above commit changed this so that GDB
now prints:

  Line number 32 out of range; /path/to/gdb/testsuite/gdb.linespec/explicit.c has 71 lines.

which is a little confusing.

This commit fixes the regression, and restores the behaviour that GDB
prints nothing.

While I was passing I noticed a call to `back` on a std::string that I
was concerned could be empty if the request for source lines returns
an empty string.  I don't know if it would be possible for a request
for lines to return an empty string, I guess it should be impossible,
in which case, maybe this should be an assertion, but adding a `empty`
check, seems like an easy and cheap safety net.

gdb/ChangeLog:

	* source.c (print_source_lines_base): Handle requests to print
	reverse line number sequences, and guard against empty lines
	string.

Failures on RHEL-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	rhel-7_1-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/RHEL-s390x-m64/builds/9051>

Commit(s) tested:
	ec98a4ad5bfcba33deb5cb786c023082adbbfb46

Author(s) (in the same order as the commits):
	Andrew Burgess <andrew.burgess@embecosm.com>

Subject:
	gdb: Handle requests to print source lines backward

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/RHEL-s390x-m64/ec/ec98a4ad5bfcba33deb5cb786c023082adbbfb46/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/RHEL-s390x-m64/xfails/master/xfail?id=0f95abf1>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/RHEL-s390x-m64/xfails/master/xfail.table?id=0f95abf1>

Failures on Debian-s390x-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-extended-gdbserver-m64/builds/7357>

Commit(s) tested:
	ec98a4ad5bfcba33deb5cb786c023082adbbfb46

Author(s) (in the same order as the commits):
	Andrew Burgess <andrew.burgess@embecosm.com>

Subject:
	gdb: Handle requests to print source lines backward

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-native-extended-gdbserver-m64/ec/ec98a4ad5bfcba33deb5cb786c023082adbbfb46/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-extended-gdbserver-m64/xfails/master/xfail?id=80f3ecfc>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-extended-gdbserver-m64/xfails/master/xfail.table?id=80f3ecfc>

Failures on Fedora-i686, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/11798>

Commit(s) tested:
	ec98a4ad5bfcba33deb5cb786c023082adbbfb46

Author(s) (in the same order as the commits):
	Andrew Burgess <andrew.burgess@embecosm.com>

Subject:
	gdb: Handle requests to print source lines backward

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-i686/ec/ec98a4ad5bfcba33deb5cb786c023082adbbfb46/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/list.exp: list line 1 with unlimited listsize
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-i686/xfails/master/xfail?id=a7b926fb>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-i686/xfails/master/xfail.table?id=a7b926fb>

Failures on Debian-s390x-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-gdbserver-m64/builds/7214>

Commit(s) tested:
	ec98a4ad5bfcba33deb5cb786c023082adbbfb46

Author(s) (in the same order as the commits):
	Andrew Burgess <andrew.burgess@embecosm.com>

Subject:
	gdb: Handle requests to print source lines backward

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-native-gdbserver-m64/ec/ec98a4ad5bfcba33deb5cb786c023082adbbfb46/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-gdbserver-m64/xfails/master/xfail?id=808ebe15>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-gdbserver-m64/xfails/master/xfail.table?id=808ebe15>

Failures on Fedora-x86_64-cc-with-index, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/11712>

Commit(s) tested:
	ec98a4ad5bfcba33deb5cb786c023082adbbfb46

Author(s) (in the same order as the commits):
	Andrew Burgess <andrew.burgess@embecosm.com>

Subject:
	gdb: Handle requests to print source lines backward

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/ec/ec98a4ad5bfcba33deb5cb786c023082adbbfb46/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/list.exp: list line 1 with unlimited listsize
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail?id=01ef4ed5>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail.table?id=01ef4ed5>

Failures on Debian-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-m64/builds/7170>

Commit(s) tested:
	ec98a4ad5bfcba33deb5cb786c023082adbbfb46

Author(s) (in the same order as the commits):
	Andrew Burgess <andrew.burgess@embecosm.com>

Subject:
	gdb: Handle requests to print source lines backward

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-m64/ec/ec98a4ad5bfcba33deb5cb786c023082adbbfb46/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail?id=628a9f58>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail.table?id=628a9f58>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-2

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m32/builds/11477>

Commit(s) tested:
	ec98a4ad5bfcba33deb5cb786c023082adbbfb46

Author(s) (in the same order as the commits):
	Andrew Burgess <andrew.burgess@embecosm.com>

Subject:
	gdb: Handle requests to print source lines backward

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m32/ec/ec98a4ad5bfcba33deb5cb786c023082adbbfb46/>

Failures on Fedora-x86_64-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/11857>

Commit(s) tested:
	ec98a4ad5bfcba33deb5cb786c023082adbbfb46

Author(s) (in the same order as the commits):
	Andrew Burgess <andrew.burgess@embecosm.com>

Subject:
	gdb: Handle requests to print source lines backward

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m64/ec/ec98a4ad5bfcba33deb5cb786c023082adbbfb46/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/list.exp: list line 1 with unlimited listsize
PASS -> FAIL: gdb.server/server-run.exp: continue to main
PASS -> UNRESOLVED: gdb.server/server-run.exp: loaded dynamic linker
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m64/xfails/master/xfail?id=08dc9573>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m64/xfails/master/xfail.table?id=08dc9573>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/11749>

Commit(s) tested:
	ec98a4ad5bfcba33deb5cb786c023082adbbfb46

Author(s) (in the same order as the commits):
	Andrew Burgess <andrew.burgess@embecosm.com>

Subject:
	gdb: Handle requests to print source lines backward

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m64/ec/ec98a4ad5bfcba33deb5cb786c023082adbbfb46/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/list.exp: list line 1 with unlimited listsize
new UNRESOLVED: gdb.cp/rvalue-ref-overload.exp: couldn't run to marker1
new UNRESOLVED: gdb.cp/rvalue-ref-overload.exp: delete all breakpoints in delete_breakpoints
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail?id=88011867>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail.table?id=88011867>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m64/builds/11715>

Commit(s) tested:
	ec98a4ad5bfcba33deb5cb786c023082adbbfb46

Author(s) (in the same order as the commits):
	Andrew Burgess <andrew.burgess@embecosm.com>

Subject:
	gdb: Handle requests to print source lines backward

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m64/ec/ec98a4ad5bfcba33deb5cb786c023082adbbfb46/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/list.exp: list line 1 with unlimited listsize
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail?id=cd3e69a0>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail.table?id=cd3e69a0>

Failures on Fedora-x86_64-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-2

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/11550>

Commit(s) tested:
	ec98a4ad5bfcba33deb5cb786c023082adbbfb46

Author(s) (in the same order as the commits):
	Andrew Burgess <andrew.burgess@embecosm.com>

Subject:
	gdb: Handle requests to print source lines backward

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m32/ec/ec98a4ad5bfcba33deb5cb786c023082adbbfb46/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/list.exp: list line 1 with unlimited listsize
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m32/xfails/master/xfail?id=d08a785f>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m32/xfails/master/xfail.table?id=d08a785f>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m32/builds/11483>

Commit(s) tested:
	ec98a4ad5bfcba33deb5cb786c023082adbbfb46

Author(s) (in the same order as the commits):
	Andrew Burgess <andrew.burgess@embecosm.com>

Subject:
	gdb: Handle requests to print source lines backward

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m32/ec/ec98a4ad5bfcba33deb5cb786c023082adbbfb46/>

*** Diff to previous build ***
============================
new FAIL: gdb.base/corefile.exp: core-file warning-free
PASS -> FAIL: gdb.base/list.exp: list line 1 with unlimited listsize
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail?id=cca6bb5f>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail.table?id=cca6bb5f>

Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu16-aarch64

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-Aarch64-native-extended-gdbserver-m64/builds/405>

Commit(s) tested:
	ec98a4ad5bfcba33deb5cb786c023082adbbfb46

Author(s) (in the same order as the commits):
	Andrew Burgess <andrew.burgess@embecosm.com>

Subject:
	gdb: Handle requests to print source lines backward

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/ec/ec98a4ad5bfcba33deb5cb786c023082adbbfb46/>

Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu16-aarch64

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-Aarch64-native-gdbserver-m64/builds/4774>

Commit(s) tested:
	ec98a4ad5bfcba33deb5cb786c023082adbbfb46

Author(s) (in the same order as the commits):
	Andrew Burgess <andrew.burgess@embecosm.com>

Subject:
	gdb: Handle requests to print source lines backward

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-Aarch64-native-gdbserver-m64/ec/ec98a4ad5bfcba33deb5cb786c023082adbbfb46/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.ada/packed_array.exp: ptype &var
PASS -> FAIL: gdb.ada/print_chars.exp: print WC
PASS -> FAIL: gdb.ada/watch_minus_l.exp: continue with watch -location
new FAIL: gdb.base/argv0-symlink.exp: set print repeats unlimited
FAIL -> UNRESOLVED: gdb.base/commands.exp: breakpoint_command_test: cannot run to factorial
new FAIL: gdb.base/commands.exp: breakpoint_command_test: info breakpoints
PASS -> FAIL: gdb.base/condbreak.exp: break *main if
PASS -> FAIL: gdb.base/ena-dis-br.exp: continue until exit at no stop at ignored & disabled break marker1
new FAIL: gdb.base/funcargs.exp: setting breakpoint at call0a
new UNRESOLVED: gdb.base/maint.exp: check index cache stats
PASS -> FAIL: gdb.cp/bool.exp: print return_true
PASS -> FAIL: gdb.cp/ref-params.exp: print value of a Child in main
PASS -> FAIL: gdb.cp/templates.exp: ptype T5<int>
PASS -> FAIL: gdb.mi/mi-frame-regs.exp: do_fixed_varobj_test: create varobj for 'global_zero + $pc' in frame 0
PASS -> FAIL: gdb.mi/mi-until.exp: until line number
PASS -> FAIL: gdb.mi/mi-until.exp: until line number:file
new FAIL: gdb.opt/inline-cmds.exp: mi: breakpoint hit
new FAIL: gdb.opt/inline-cmds.exp: mi: mi runto main
new FAIL: gdb.opt/inline-cmds.exp: mi: set breakpoint
new KFAIL: gdb.opt/inline-cmds.exp: next to second func1
PASS -> FAIL: gdb.reverse/recvmsg-reverse.exp: check recvmsg record - rdata
PASS -> FAIL: gdb.reverse/recvmsg-reverse.exp: reverse to marker1
new UNRESOLVED: gdb.threads/continue-pending-after-query.exp: iter 6: info breakpoints
new UNRESOLVED: gdb.threads/continue-pending-after-query.exp: iter 8: info breakpoints
new UNRESOLVED: gdb.trace/tfind.exp: current target does not support trace
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Ubuntu-Aarch64-native-gdbserver-m64/xfails/master/xfail?id=22175446>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Ubuntu-Aarch64-native-gdbserver-m64/xfails/master/xfail.table?id=22175446>