public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] libctf: bfd-open: mark the bfd as cacheable
Date: Tue, 08 Oct 2019 12:35:00 -0000	[thread overview]
Message-ID: <edc8bbe90b82f1fa4f3f261b5c97503867e9aba4@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT edc8bbe90b82f1fa4f3f261b5c97503867e9aba4 ***

commit edc8bbe90b82f1fa4f3f261b5c97503867e9aba4
Author:     Nick Alcock <nick.alcock@oracle.com>
AuthorDate: Fri Jul 26 21:52:11 2019 +0100
Commit:     Nick Alcock <nick.alcock@oracle.com>
CommitDate: Thu Oct 3 17:04:55 2019 +0100

    libctf: bfd-open: mark the bfd as cacheable
    
    Without this, the FD is only closed when the CTF file is, leading to
    running out of fds on (e.g.) very large links.
    
    New in v3.
    
    libctf/
            * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.

diff --git a/libctf/ChangeLog b/libctf/ChangeLog
index 9637cf37af..852ad6267c 100644
--- a/libctf/ChangeLog
+++ b/libctf/ChangeLog
@@ -1,3 +1,7 @@
+2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
+
+	* ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
+
 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 
 	* ctf-impl.h (includes): Include <sys/param.h> here.
diff --git a/libctf/ctf-open-bfd.c b/libctf/ctf-open-bfd.c
index 6fbbde8852..1083c87608 100644
--- a/libctf/ctf-open-bfd.c
+++ b/libctf/ctf-open-bfd.c
@@ -312,6 +312,7 @@ ctf_fdopen (int fd, const char *filename, const char *target, int *errp)
 		   bfd_errmsg (bfd_get_error()));
       return (ctf_set_open_errno (errp, ECTF_FMT));
     }
+  bfd_set_cacheable (abfd, 1);
 
   if (!bfd_check_format (abfd, bfd_object))
     {


             reply	other threads:[~2019-10-08 12:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08 12:35 gdb-buildbot [this message]
2019-10-08 12:35 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
2019-10-08 15:08 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot
2019-10-11 14:16 ` Failures on Fedora-i686, " gdb-buildbot
2019-10-11 15:03 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2019-10-11 15:28 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2019-10-11 15:58 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2019-10-11 16:13 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2019-10-11 16:46 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=edc8bbe90b82f1fa4f3f261b5c97503867e9aba4@gdb-build \
    --to=gdb-buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).