public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Deduplicate require_running macros and move them up
Date: Fri, 15 Sep 2017 17:29:00 -0000	[thread overview]
Message-ID: <f8a4e1192032044cdae544848865636f6e07a925@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT f8a4e1192032044cdae544848865636f6e07a925 ***

Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: f8a4e1192032044cdae544848865636f6e07a925

Deduplicate require_running macros and move them up

I find it very confusing to define the require_running in the middle of
the file, and re-define it to something else later in the middle of the
same file.  I think it would be better if those macros had different
names so that we know exactly what they do.

gdb/gdbserver/ChangeLog:

	* server.c (require_running): Rename to ...
	(require_running_or_return): ... this ...
	(require_running_or_break): ... and this.
	(handle_query, process_serial_event): Adjust.


             reply	other threads:[~2017-09-15 17:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-15 17:29 sergiodj+buildbot [this message]
2017-09-15 17:29 ` Failures on Fedora-x86_64-m64, branch master sergiodj+buildbot
2017-09-15 17:53 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2017-09-15 18:23 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2017-09-15 19:07 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
2017-09-15 19:09 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot
2017-09-15 19:43 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-09-15 19:49 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot
2017-09-26 13:09 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2017-09-27 15:16 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2017-09-27 17:04 ` Failures on Debian-s390x-m64, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8a4e1192032044cdae544848865636f6e07a925@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).