public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@redhat.com
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Replace breakpoint_reinsert_addr by get_next_pcs operation in GDBServer
Date: Fri, 18 Dec 2015 16:58:00 -0000	[thread overview]
Message-ID: <fa5308bdcc4967861d1277b45205c2623b154a64@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT fa5308bdcc4967861d1277b45205c2623b154a64 ***

Author: Antoine Tremblay <antoine.tremblay@ericsson.com>
Branch: master
Commit: fa5308bdcc4967861d1277b45205c2623b154a64

Replace breakpoint_reinsert_addr by get_next_pcs operation in GDBServer

This patch in preparation for software single step support on ARM. It refactors
breakpoint_reinsert_addr into get_next_pcs so that multiple location can be
returned.

When software single stepping there can be multiple possible next addresses
because we're stepping over a conditional branch instruction, for example.

The operation get_next_pcs handles that by returning a vector of all the
possible next addresses.

Software breakpoints are installed at each location returned.

No regressions, tested on ubuntu 14.04 ARMv7 and x86.
With gdbserver-{native,extended} / { -marm -mthumb }

gdb/gdbserver/ChangeLog:

	* linux-aarch64-low.c (the_low_targets): Rename
	breakpoint_reinsert_addr to get_next_pcs.
	* linux-arm-low.c (the_low_targets): Likewise.
	* linux-bfin-low.c (the_low_targets): Likewise.
	* linux-cris-low.c (the_low_targets): Likewise.
	* linux-crisv32-low.c (the_low_targets): Likewise.
	* linux-low.c (can_software_single_step): Likewise.
	(install_software_single_step_breakpoints): New function.
	(start_step_over): Use install_software_single_step_breakpoints.
	* linux-low.h: New CORE_ADDR vector.
	(struct linux_target_ops) Rename breakpoint_reinsert_addr to
	get_next_pcs.
	* linux-mips-low.c (the_low_targets): Likewise.
	* linux-nios2-low.c (the_low_targets): Likewise.
	* linux-sparc-low.c (the_low_targets): Likewise.


             reply	other threads:[~2015-12-18 16:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 16:58 sergiodj+buildbot [this message]
2015-12-18 16:53 ` Failures on Debian-s390x-native-gdbserver-m64, branch master sergiodj+buildbot
2015-12-18 17:09 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2015-12-18 17:11 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2015-12-18 17:16 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2015-12-18 17:16 ` Failures on AIX-POWER7-plain, " sergiodj+buildbot
2015-12-18 17:18 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2015-12-18 17:22 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2015-12-19 18:24 ` Failures on Debian-i686, " sergiodj+buildbot
2015-12-19 19:04 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot
2015-12-19 22:25 ` Failures on Debian-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2015-12-20 18:46 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
2015-12-21 13:42 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot
2015-12-21 13:58 ` Failures on Fedora-ppc64le-cc-with-index, " sergiodj+buildbot
2015-12-21 14:08 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa5308bdcc4967861d1277b45205c2623b154a64@gdb-build \
    --to=sergiodj+buildbot@redhat.com \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).