public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Fix qualified name lookup for Rust
Date: Fri, 19 Jan 2018 22:47:00 -0000	[thread overview]
Message-ID: <fcfcc376969c4d7a6d20827c47b584db389a32b9@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT fcfcc376969c4d7a6d20827c47b584db389a32b9 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: fcfcc376969c4d7a6d20827c47b584db389a32b9

Fix qualified name lookup for Rust

In https://github.com/rust-lang/rust/pull/46457, "m4b" pointed out
that the Rust support in gdb doesn't properly handle the lookup of
qualified names.

In particular, as shown in the test case in this patch, something like
"::NAME" should be found in the global scope, but is not.

This turns out to happen because rust_lookup_symbol_nonlocal does not
search the global scope unless the name in question is unqualified.
However, lookup_symbol_aux does not search the global scope, and
appears to search the static scope only as a fallback (I wonder if
this is needed?).

This patch fixes the problem by changing rust_lookup_symbol_nonlocal
to search the static and global blocks in more cases.

Regression tested against various versions of the rust compiler on
Fedora 26 x86-64.  (Note that there are unrelated failures with newer
versions of rustc; I will be addressing those separately.)

2018-01-19  Tom Tromey  <tom@tromey.com>

	* rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
	symbols in the static and global blocks.

2018-01-19  Tom Tromey  <tom@tromey.com>

	* gdb.rust/modules.rs (TWENTY_THREE): New global.
	* gdb.rust/modules.exp: Add ::-qualified lookup test.


             reply	other threads:[~2018-01-19 22:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19 22:47 sergiodj+buildbot [this message]
2018-01-19 22:47 ` Failures on RHEL-s390x-m64, branch master sergiodj+buildbot
2018-01-19 22:48 ` Failures on Debian-s390x-m64, " sergiodj+buildbot
2018-01-19 22:52 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2018-01-19 23:02 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2018-01-19 23:08 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-01-19 23:11 ` Failures on Fedora-i686, " sergiodj+buildbot
2018-01-19 23:16 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2018-01-19 23:16 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2018-01-19 23:26 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2018-01-19 23:34 ` Failures on Fedora-s390x-m64, " sergiodj+buildbot
2018-01-20  1:57 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot
2018-01-20 21:25 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-01-20 21:57 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot
2018-01-20 22:46 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcfcc376969c4d7a6d20827c47b584db389a32b9@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).