public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Make dwarf2_evaluate_property parameter const
Date: Sun, 05 Apr 2020 17:48:46 -0400	[thread overview]
Message-ID: <fe26d3a34a223a86fddb59ed70a621a13940a088@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT fe26d3a34a223a86fddb59ed70a621a13940a088 ***

commit fe26d3a34a223a86fddb59ed70a621a13940a088
Author:     Tom Tromey <tromey@adacore.com>
AuthorDate: Fri Mar 20 13:04:56 2020 -0600
Commit:     Tom Tromey <tromey@adacore.com>
CommitDate: Fri Mar 20 13:06:22 2020 -0600

    Make dwarf2_evaluate_property parameter const
    
    dwarf2_evaluate_property should not modify its "addr_stack"
    parameter's contents.  This patch makes this part of the API, by
    marking it const.
    
    gdb/ChangeLog
    2020-03-20  Tom Tromey  <tromey@adacore.com>
    
            * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
            const.
            * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
            const.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 393b0d278d..186660bf9f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2020-03-20  Tom Tromey  <tromey@adacore.com>
+
+	* dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
+	const.
+	* dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
+	const.
+
 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
 
 	* ptrace.m4: Don't check for ptrace declaration.
diff --git a/gdb/dwarf2/loc.c b/gdb/dwarf2/loc.c
index 5155cff60d..6440335ccb 100644
--- a/gdb/dwarf2/loc.c
+++ b/gdb/dwarf2/loc.c
@@ -2453,7 +2453,7 @@ dwarf2_locexpr_baton_eval (const struct dwarf2_locexpr_baton *dlbaton,
 bool
 dwarf2_evaluate_property (const struct dynamic_prop *prop,
 			  struct frame_info *frame,
-			  struct property_addr_info *addr_stack,
+			  const struct property_addr_info *addr_stack,
 			  CORE_ADDR *value)
 {
   if (prop == NULL)
@@ -2542,7 +2542,7 @@ dwarf2_evaluate_property (const struct dynamic_prop *prop,
       {
 	struct dwarf2_property_baton *baton
 	  = (struct dwarf2_property_baton *) prop->data.baton;
-	struct property_addr_info *pinfo;
+	const struct property_addr_info *pinfo;
 	struct value *val;
 
 	for (pinfo = addr_stack; pinfo != NULL; pinfo = pinfo->next)
diff --git a/gdb/dwarf2/loc.h b/gdb/dwarf2/loc.h
index 98a7d8a606..a59d3f998f 100644
--- a/gdb/dwarf2/loc.h
+++ b/gdb/dwarf2/loc.h
@@ -96,7 +96,7 @@ struct property_addr_info
 
 bool dwarf2_evaluate_property (const struct dynamic_prop *prop,
 			       struct frame_info *frame,
-			       struct property_addr_info *addr_stack,
+			       const struct property_addr_info *addr_stack,
 			       CORE_ADDR *value);
 
 /* A helper for the compiler interface that compiles a single dynamic


             reply	other threads:[~2020-04-05 21:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-05 21:48 gdb-buildbot [this message]
2020-04-05 21:48 ` Failures on Fedora-i686, branch master gdb-buildbot
2020-04-05 22:12 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2020-04-05 22:55 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2020-04-05 22:56 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2020-04-05 23:46 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2020-04-10  5:07 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
2020-04-11  2:20 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot
2020-04-11  4:08 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe26d3a34a223a86fddb59ed70a621a13940a088@gdb-build \
    --to=gdb-buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).