From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15029 invoked by alias); 12 Nov 2012 09:37:35 -0000 Received: (qmail 15020 invoked by uid 22791); 12 Nov 2012 09:37:34 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Nov 2012 09:37:30 +0000 Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAC9bSwt087055 for ; Mon, 12 Nov 2012 10:37:28 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms16.u-strasbg.fr [130.79.204.116]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAC9bSnB002168 for ; Mon, 12 Nov 2012 10:37:28 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAC9bR8S029613 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Mon, 12 Nov 2012 10:37:27 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Subject: New ARI web page, generated using script inside CVS tree in gdb/contrib/ari directory Date: Mon, 12 Nov 2012 09:37:00 -0000 Message-ID: <002701cdc0b9$542d2560$fc877020$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00007.txt.bz2 Recently, an in-tree version of the scripts used to generate the ARI web-page was added to gdb CVS repository. The original ARI page is at: http://sourceware.org/gdb/current/ari/ while the new page is temporarily at: http://sourceware.org/gdb/current/ari/test/ The main advantage of this in-tree version is that it is easier to adapt to changes inside CVS tree. If you look for instance in the first link, you will see that there are 13 regressions listed in the 'Critical' section. This list was easily reduced to 4 in the second link, because lots of those regression are simply related to changes in the sources, especially code moves from gdb to gdb/common sub-directory. Out of the 4 remaining critical issues Critical Things previously eliminated but returned. This should always be empty. BUG Total Description 1) strerror 10 Do not use strerror(), instead use safe_strerror() 2) xasprintf 2 Do not use xasprintf(), instead use xstrprintf 3) stat.h 1 Do not include stat.h or sys/stat.h, instead include gdb_stat.h 4) wait.h 1 Do not include wait.h or sys/wait.h, instead include gdb_wait.h 2) will be solved as soon as the [RFA] Fix New ARI warning Tue Nov 6 01:58:48 UTC 2012 gets approved. 3) and 4) are all related to the fact that gdb_stat.h and gdb_wait.h headers are still in gdb directory, which force the use of direct system include headers in sources in gdb/common sub-directory. Those can probably be solved easily by moving the two headers also to gdb/common. But before sending a patch, I would like to know if this is the right direction to go to... 1) is a little bit more tricky because safe_strerror is declared in utils.h header, but implemented in two files: posix-hdep.c and mingw-hdep.c Should I extract the declaration into a gdb/common/gdb_strerror.h and extract the two functions into gdb/common/posix-strerror.c and gdb/common/mingw-strerror.c? Finally, a few broader questions regarding ARI: Should we add rules about gdb_XXX.h headers stating that if gdb_XXX.h header exists and shadows an existing system header, no gdb C source file should include XXX.h system header directly. I would tend to find such a rule logical, but it would probably force us to more most of these headers into gdb/common subdirectory, and I don't really know if this trend is really accepted by the global maintainers. Also, I would find as a logical consequence that also gdbserver subdirectory should follow the ARI rules. This is done quite easily by removing the -name gdbserver -prune -o line from gdb_find.sh script in gdb/contrib./ari but is a rather important change that should be discussed fully. Any comments most welcome, Pierre Muller as ARI maintainer. Pierre Muller as ARI maintainer