From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6B2D93858CDA for ; Tue, 27 Sep 2022 07:58:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6B2D93858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664265529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Yl8OOumh06fJkl6dUTs/GDik8xSD9KRxrWtcWdsruc=; b=enW88NxbxcPvGcQLK8CYDmx3fXVd+daI3r4/hj0UNPqS21bzDlIf33g9kgPAitHo86HiCO 5Bn+ijqyRKocrLn2k7WjIiAWO99xvoPj0D3k6Ls6J5v8qJh83sIwyXayH1un1JIS99+AOl EPs/0ejmt1gOEDQzneb7FWATiFwo3J4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-617-9ourutvINjq0jiwpm-qOcQ-1; Tue, 27 Sep 2022 03:58:48 -0400 X-MC-Unique: 9ourutvINjq0jiwpm-qOcQ-1 Received: by mail-wm1-f69.google.com with SMTP id b5-20020a05600c4e0500b003b499f99aceso8245011wmq.1 for ; Tue, 27 Sep 2022 00:58:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=1Yl8OOumh06fJkl6dUTs/GDik8xSD9KRxrWtcWdsruc=; b=i8sqxxVHnaSigGIrV+iYNkEkFQx6sOCbefrZu6Kt41FrmoSS4eKmy+x7i41lvH0qHW qKl5A03uDaxqby7UE6oWoLf0YMb1qV9UEDm/J1CNknPoIRD4lKgbXMjBTY+p7ngB5tgx xjnDSNHouovjWKTQtH+d6eFeVH5nvVWfOyGlNyE3i5rROcN1XQKGMFZlkjZs8Q2BnGXB JQdxB+G82F90kcyN3qD9CwItQNzlxM407fQCsI3A3Rqg1WLhtrA9VNC88kk6wmMbsXNZ /2/lUKW0xFiUMbQOcqfsll/aIlxHXaD1OLec71g2ZGpqR6577J84b342XNumRQJcbJ/z TZKg== X-Gm-Message-State: ACrzQf1LKDwfz+Xv0MKVfx+mSYHXoOrVx4CGAHNctDdelqMA+CTmbAxm PPQjifqYDrhO5Nwzqgfiael7pavwxIZmMAjv89YZZjrDT9SMZu3Gya5jMx8XDVRr+LckKufoVMw 2adz7tJyYxcs= X-Received: by 2002:a05:600c:4f11:b0:3b4:bf6c:4566 with SMTP id l17-20020a05600c4f1100b003b4bf6c4566mr1643614wmq.34.1664265526712; Tue, 27 Sep 2022 00:58:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4n9Vp97r96XM9fV/JurSQ4BNkb6D9T+0VlBufF4lqt4BGUWNff+auAh/rBCgaaDx/Box6WVA== X-Received: by 2002:a05:600c:4f11:b0:3b4:bf6c:4566 with SMTP id l17-20020a05600c4f1100b003b4bf6c4566mr1643607wmq.34.1664265526479; Tue, 27 Sep 2022 00:58:46 -0700 (PDT) Received: from [192.168.0.45] (ip-62-245-66-121.bb.vodafone.cz. [62.245.66.121]) by smtp.gmail.com with ESMTPSA id w6-20020adfd4c6000000b00223b8168b15sm1060484wrk.66.2022.09.27.00.58.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 00:58:45 -0700 (PDT) Message-ID: <08d732c8-2c5e-c9d6-5d37-7a740bf73255@redhat.com> Date: Tue, 27 Sep 2022 09:58:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: Proposal: Add review tags to patch review workflow. To: Simon Marchi , gdb@sourceware.org References: <453759b1-1ddf-1aff-a033-6183b84a4a4d@simark.ca> From: Bruno Larsen In-Reply-To: <453759b1-1ddf-1aff-a033-6183b84a4a4d@simark.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26/09/2022 15:55, Simon Marchi wrote: > > On 2022-09-21 07:04, Bruno Larsen via Gdb wrote: >> TL;DR: I want to introduce the usage of 3 new review tags to the GDB patch review workflow. They are: Reviewed-by, Approved-by and Tested-by. > Hi Bruno, > > I completely agree with the proposal. I really like the fact that it > makes communication less ambiguous. Following some process (or changing > the process) can feel a bit heavy for long-timers, but I think it makes > things much clearer for newcomers. > > Assuming we will go through with this proposal, it will need to be > documented on the wiki so we can easily refer people to the procedure. > Probably the ContributionChecklist page? > > https://sourceware.org/gdb/wiki/ContributionChecklist > > Will you be able to take care of this when needed (do you have write > access to the wiki)? Hi Simon, Thanks for the reply! I don't have write access to the wiki (In fact, I just created my account on it), can you give me the necessary permissions, or do I need to ask someone else? (in case it is the latter, who?) Cheers, Bruno