From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20912 invoked by alias); 22 Apr 2003 20:06:21 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 20905 invoked from network); 22 Apr 2003 20:06:20 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 22 Apr 2003 20:06:20 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h3MK6KD20347 for ; Tue, 22 Apr 2003 16:06:20 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h3MK6Kq24099; Tue, 22 Apr 2003 16:06:20 -0400 Received: from localhost.localdomain (vpn50-16.rdu.redhat.com [172.16.50.16]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h3MK6Jk01066; Tue, 22 Apr 2003 16:06:19 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h3MK6EJ22478; Tue, 22 Apr 2003 13:06:14 -0700 Date: Tue, 22 Apr 2003 20:06:00 -0000 From: Kevin Buettner Message-Id: <1030422200614.ZM22477@localhost.localdomain> In-Reply-To: David Taylor "macros, debug information, and parse_macro_definition" (Apr 22, 12:40pm) References: <200304221640.h3MGelj05733@mailhub.lss.emc.com> To: David Taylor , gdb@sources.redhat.com Subject: Re: macros, debug information, and parse_macro_definition MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-04/txt/msg00259.txt.bz2 On Apr 22, 12:40pm, David Taylor wrote: > As a result, at some point I will need to call a function which will > either be identical to or 99% identical to parse_macro_definition. > So, I'd like to propose that the function parse_macro_definition be > made non static and that it and its support functions (copy_string, > dwarf2_macro_malformed_definition_complaint, consume_improper_spaces > -- all three of which are called *ONLY* by parse_macro_defintion) be > moved to another file -- since they are not DWARF specific anymore. > > Any objections? File name? No objections from me... > My inclination is to move them to macrotab.c since the function > parse_macro_defintion calls functions within that file and can be > thought of as a thin veneer above the functions macro_define_object > and macro_define_function. > > Comments? Sounds reasonable to me. Kevin