From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb@sources.redhat.com
Subject: Re: frame.c assertion failure
Date: Thu, 08 May 2003 05:49:00 -0000 [thread overview]
Message-ID: <1030508054934.ZM4408@localhost.localdomain> (raw)
In-Reply-To: Andrew Cagney <ac131313@redhat.com> "Re: frame.c assertion failure" (May 7, 8:22pm)
On May 7, 8:22pm, Andrew Cagney wrote:
> The legacy mips target is calling get_frame_type() on a frame that
> hasn't yet had it's type initialized. I can think of:
>
> -- Tweaking the below if to also test !legacy_frame_p().
>
> > enum frame_type
> > get_frame_type (struct frame_info *frame)
> ...
> > if (frame->unwind == NULL)
This works. Here's the patch:
* frame.c (get_frame_type): Don't attempt to lazily initialize
frame's unwinder for legacy frames.
Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.111
diff -u -p -r1.111 frame.c
--- frame.c 5 May 2003 18:33:10 -0000 1.111
+++ frame.c 8 May 2003 05:45:52 -0000
@@ -2069,7 +2069,7 @@ get_frame_type (struct frame_info *frame
if (!DEPRECATED_USE_GENERIC_DUMMY_FRAMES
&& deprecated_frame_in_dummy (frame))
return DUMMY_FRAME;
- if (frame->unwind == NULL)
+ if (frame->unwind == NULL && !legacy_frame_p (current_gdbarch))
{
/* Initialize the frame's unwinder because it is that which
provides the frame's type. */
Okay?
next prev parent reply other threads:[~2003-05-08 5:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-07 22:25 Kevin Buettner
2003-05-07 23:40 ` Kevin Buettner
2003-05-08 0:03 ` Andrew Cagney
2003-05-08 0:22 ` Andrew Cagney
2003-05-08 5:49 ` Kevin Buettner [this message]
2003-05-08 14:05 ` Andrew Cagney
2003-05-08 15:39 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030508054934.ZM4408@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=ac131313@redhat.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).