From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-13721-listarch-gdb=sources.redhat.com@sources.redhat.com>
Received: (qmail 5276 invoked by alias); 8 May 2003 05:49:42 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 5265 invoked from network); 8 May 2003 05:49:42 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 8 May 2003 05:49:42 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h485ngH32245
	for <gdb@sources.redhat.com>; Thu, 8 May 2003 01:49:42 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h485nfI10938;
	Thu, 8 May 2003 01:49:41 -0400
Received: from localhost.localdomain (vpn50-18.rdu.redhat.com [172.16.50.18])
	by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h485nej06770;
	Thu, 8 May 2003 01:49:40 -0400
Received: (from kev@localhost)
	by localhost.localdomain (8.11.6/8.11.6) id h485nZ504409;
	Wed, 7 May 2003 22:49:35 -0700
Date: Thu, 08 May 2003 05:49:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-Id: <1030508054934.ZM4408@localhost.localdomain>
In-Reply-To: Andrew Cagney <ac131313@redhat.com>
        "Re: frame.c assertion failure" (May  7,  8:22pm)
References: <1030507222547.ZM32134@localhost.localdomain> 
	<1030507234012.ZM557@localhost.localdomain> 
	<3EB99EB1.8090205@redhat.com>  <3EB9A330.50601@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>
Subject: Re: frame.c assertion failure
Cc: gdb@sources.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2003-05/txt/msg00104.txt.bz2

On May 7,  8:22pm, Andrew Cagney wrote:

> The legacy mips target is calling get_frame_type() on a frame that 
> hasn't yet had it's type initialized.  I can think of:
> 
> -- Tweaking the below if to also test !legacy_frame_p().
> 
> > enum frame_type
> > get_frame_type (struct frame_info *frame)
> ...
> >   if (frame->unwind == NULL)

This works.  Here's the patch:

	* frame.c (get_frame_type): Don't attempt to lazily initialize
	frame's unwinder for legacy frames.

Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.111
diff -u -p -r1.111 frame.c
--- frame.c	5 May 2003 18:33:10 -0000	1.111
+++ frame.c	8 May 2003 05:45:52 -0000
@@ -2069,7 +2069,7 @@ get_frame_type (struct frame_info *frame
   if (!DEPRECATED_USE_GENERIC_DUMMY_FRAMES
       && deprecated_frame_in_dummy (frame))
     return DUMMY_FRAME;
-  if (frame->unwind == NULL)
+  if (frame->unwind == NULL && !legacy_frame_p (current_gdbarch))
     {
       /* Initialize the frame's unwinder because it is that which
          provides the frame's type.  */

Okay?