From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6907 invoked by alias); 8 May 2003 15:39:35 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 6880 invoked from network); 8 May 2003 15:39:34 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 8 May 2003 15:39:34 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h48FdXH26611 for ; Thu, 8 May 2003 11:39:33 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h48FdWI09261; Thu, 8 May 2003 11:39:32 -0400 Received: from localhost.localdomain (vpn50-18.rdu.redhat.com [172.16.50.18]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h48FdWj16971; Thu, 8 May 2003 11:39:32 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h48FdQq06588; Thu, 8 May 2003 08:39:26 -0700 Date: Thu, 08 May 2003 15:39:00 -0000 From: Kevin Buettner Message-Id: <1030508153926.ZM6587@localhost.localdomain> In-Reply-To: Andrew Cagney "Re: frame.c assertion failure" (May 8, 10:05am) References: <1030507222547.ZM32134@localhost.localdomain> <1030507234012.ZM557@localhost.localdomain> <3EB99EB1.8090205@redhat.com> <3EB9A330.50601@redhat.com> <1030508054934.ZM4408@localhost.localdomain> <3EBA6443.9020308@redhat.com> To: Andrew Cagney Subject: Re: frame.c assertion failure Cc: gdb@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-05/txt/msg00108.txt.bz2 On May 8, 10:05am, Andrew Cagney wrote: > Don't forget a comment :-) [...] > > Okay? > > yup. It's in. This is what I committed... * frame.c (get_frame_type): Don't attempt to lazily initialize frame's unwinder for legacy frames. Index: frame.c =================================================================== RCS file: /cvs/src/src/gdb/frame.c,v retrieving revision 1.111 diff -u -p -r1.111 frame.c --- frame.c 5 May 2003 18:33:10 -0000 1.111 +++ frame.c 8 May 2003 15:32:59 -0000 @@ -2069,7 +2069,12 @@ get_frame_type (struct frame_info *frame if (!DEPRECATED_USE_GENERIC_DUMMY_FRAMES && deprecated_frame_in_dummy (frame)) return DUMMY_FRAME; - if (frame->unwind == NULL) + + /* Some legacy code, e.g, mips_init_extra_frame_info() wants + to determine the frame's type prior to it being completely + initialized. Don't attempt to lazily initialize ->unwind for + legacy code. It will be initialized in legacy_get_prev_frame(). */ + if (frame->unwind == NULL && !legacy_frame_p (current_gdbarch)) { /* Initialize the frame's unwinder because it is that which provides the frame's type. */