* [PATCH/RFA] sim autoconf conversion fallout
@ 2005-01-16 19:26 Mark Kettenis
2005-01-18 20:07 ` Andrew Cagney
0 siblings, 1 reply; 6+ messages in thread
From: Mark Kettenis @ 2005-01-16 19:26 UTC (permalink / raw)
To: gdb-patches; +Cc: gdb
There still a lot of breakage in the sim tree:
* Several simulators no longer build because the common directory
isn't configured. AFAICT all similators need that directory, so I
propose the attached patch.
* The --enable-sim option is essentially a no-op now, since all
simulators are built unconditionally if gdb is configured for a
matching target. Why has the option been retained while all the
logic that used it is gone? Why was the logic removed in the first
place?
* In the past several simulators were only built when compiling with
gcc. That code was ripped out. Why?
The result of these problems is that gdb cannot be built on many, many
systems anymore. After the attached patch has been applied, my
immediate concern the ERC32 SPARC V7 simulator. The simulator is
currently broken (and has been for quite some time I guess and even
before that it only built on i386 and sparc hosts). As a result GDB
won't build for any sparc*-*-* target. Is there any interest in
retaining this simulator? If so, we should at least but some of the
removed logic back. Otherwise, I propose we remove the ERC32
simulator.
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* configure.ac: Always configure the common subdirectory.
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/sim/configure.ac,v
retrieving revision 1.2
diff -u -p -r1.2 configure.ac
--- configure.ac 12 Jan 2005 16:23:11 -0000 1.2
+++ configure.ac 16 Jan 2005 19:25:53 -0000
@@ -33,6 +33,8 @@ yes | no) ;;
*) AC_MSG_ERROR(bad value ${enableval} given for --enable-sim option) ;;
esac])
+AC_CONFIG_SUBDIRS(common)
+
# WHEN ADDING ENTRIES TO THIS MATRIX:
# Make sure that the left side always has two dashes. Otherwise you
@@ -42,13 +44,11 @@ esac])
if test "${enable_sim}" != no; then
testsuite=no
- common=no
igen=no
case "${target}" in
arm*-*-* | thumb*-*-* | strongarm*-*-* | xscale-*-*)
AC_CONFIG_SUBDIRS(arm)
testsuite=yes
- common=yes
;;
d10v-*-*)
AC_CONFIG_SUBDIRS(d10v)
@@ -56,27 +56,22 @@ if test "${enable_sim}" != no; then
frv-*-*)
AC_CONFIG_SUBDIRS(frv)
testsuite=yes
- common=yes
;;
h8300*-*-*)
AC_CONFIG_SUBDIRS(h8300)
testsuite=yes
- common=yes
;;
m32r-*-*)
AC_CONFIG_SUBDIRS(m32r)
testsuite=yes
- common=yes
;;
m68hc11-*-*|m6811-*-*)
AC_CONFIG_SUBDIRS(m68hc11)
testsuite=yes
- common=yes
;;
mcore-*-*)
AC_CONFIG_SUBDIRS(mcore)
testsuite=yes
- common=yes
;;
mips*-*-*)
AC_CONFIG_SUBDIRS(mips)
@@ -90,15 +85,12 @@ if test "${enable_sim}" != no; then
sh*-*-*)
AC_CONFIG_SUBDIRS(sh)
testsuite=yes
- common=yes
;;
powerpc*-*-* )
AC_CONFIG_SUBDIRS(ppc)
- common=yes
;;
v850*-*-* )
AC_CONFIG_SUBDIRS(v850)
- common=yes
;;
sparc*-*-*)
AC_CONFIG_SUBDIRS(erc32)
@@ -107,9 +99,6 @@ if test "${enable_sim}" != no; then
if test "$testsuite" = yes; then
AC_CONFIG_SUBDIRS(testsuite)
fi
- if test "$common" = yes; then
- AC_CONFIG_SUBDIRS(common)
- fi
if test "$igen" = yes; then
AC_CONFIG_SUBDIRS(igen)
fi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH/RFA] sim autoconf conversion fallout
2005-01-16 19:26 [PATCH/RFA] sim autoconf conversion fallout Mark Kettenis
@ 2005-01-18 20:07 ` Andrew Cagney
2005-01-18 20:35 ` Mark Kettenis
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cagney @ 2005-01-18 20:07 UTC (permalink / raw)
To: Mark Kettenis; +Cc: gdb
Mark Kettenis wrote:
> There still a lot of breakage in the sim tree:
Looks under desk, nope, no fire. I guess MIPS, mn10300, and erc32
qualify as "a lot" :-)
> * Several simulators no longer build because the common directory
> isn't configured. AFAICT all similators need that directory, so I
> propose the attached patch.
This problem applied to just two simulators: MIPS and mn10300. I've
fixed the error and confirmed that the MIPS builds.
> * The --enable-sim option is essentially a no-op now, since all
> simulators are built unconditionally if gdb is configured for a
> matching target. Why has the option been retained while all the
> logic that used it is gone? Why was the logic removed in the first
> place?
--enable-sim always was a no-op (unlike --disable-sim). The only
exception was for erc32 and since that doesn't build at all I've now
disabled it.
> * In the past several simulators were only built when compiling with
> gcc. That code was ripped out. Why?
Why not.
From '98 (although I suspect '96):
# The PowerPC simulator uses the GCC extension long long as well as
# ANSI prototypes, so don't enable it for random host compilers
# unless asked to.
hence the test.
Fast forward 7 years - even GCC now assums ISO-C and long-long is a
defacto "standard".
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH/RFA] sim autoconf conversion fallout
2005-01-18 20:07 ` Andrew Cagney
@ 2005-01-18 20:35 ` Mark Kettenis
2005-01-18 21:05 ` Andrew Cagney
0 siblings, 1 reply; 6+ messages in thread
From: Mark Kettenis @ 2005-01-18 20:35 UTC (permalink / raw)
To: cagney; +Cc: gdb
Date: Tue, 18 Jan 2005 15:05:17 -0500
From: Andrew Cagney <cagney@gnu.org>
Mark Kettenis wrote:
> There still a lot of breakage in the sim tree:
Looks under desk, nope, no fire. I guess MIPS, mn10300, and erc32
qualify as "a lot" :-)
I just tried to build a native GDB on mips64-unknown-openbsd3.6 and
sparc64-unknown-freebsd5.3 in a row. Gave me a slightly biased view
of reality ;-). It seems though that d10v is also broken.
> * Several simulators no longer build because the common directory
> isn't configured. AFAICT all similators need that directory, so I
> propose the attached patch.
This problem applied to just two simulators: MIPS and mn10300. I've
fixed the error and confirmed that the MIPS builds.
Thanks for fixing it. However, what's against configuring the common
directory unconditionally? Makes things even simpler ;-).
> * The --enable-sim option is essentially a no-op now, since all
> simulators are built unconditionally if gdb is configured for a
> matching target. Why has the option been retained while all the
> logic that used it is gone? Why was the logic removed in the first
> place?
--enable-sim always was a no-op (unlike --disable-sim). The only
exception was for erc32 and since that doesn't build at all I've now
disabled it.
Ah, I overlooked the "if test "${enable_sim}" != no".
> * In the past several simulators were only built when compiling with
> gcc. That code was ripped out. Why?
Why not.
From '98 (although I suspect '96):
# The PowerPC simulator uses the GCC extension long long as well as
# ANSI prototypes, so don't enable it for random host compilers
# unless asked to.
hence the test.
Fast forward 7 years - even GCC now assums ISO-C and long-long is a
defacto "standard".
With erc32 gone this seems not unreasonable. If "long long" poses a
problem we can always bring over some of the logic from bfd.
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH/RFA] sim autoconf conversion fallout
2005-01-18 20:35 ` Mark Kettenis
@ 2005-01-18 21:05 ` Andrew Cagney
2005-01-19 10:05 ` Richard Earnshaw
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cagney @ 2005-01-18 21:05 UTC (permalink / raw)
To: Mark Kettenis; +Cc: gdb
Mark Kettenis wrote:
>It seems though that d10v is also broken.
Hardly suprising, the d10v is obsolete.
> Thanks for fixing it. However, what's against configuring the common
> directory unconditionally? Makes things even simpler ;-).
Nothing. Once the d10v is gone, that would make sense.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH/RFA] sim autoconf conversion fallout
2005-01-18 21:05 ` Andrew Cagney
@ 2005-01-19 10:05 ` Richard Earnshaw
0 siblings, 0 replies; 6+ messages in thread
From: Richard Earnshaw @ 2005-01-19 10:05 UTC (permalink / raw)
To: Andrew Cagney; +Cc: Mark Kettenis, gdb
On Tue, 2005-01-18 at 21:02, Andrew Cagney wrote:
> Mark Kettenis wrote:
> >It seems though that d10v is also broken.
>
> Hardly suprising, the d10v is obsolete.
>
> > Thanks for fixing it. However, what's against configuring the common
> > directory unconditionally? Makes things even simpler ;-).
>
> Nothing. Once the d10v is gone, that would make sense.
>
> Andrew
May or may not be relevant, but the ARM simulator doesn't build anything
in the common directory.
R.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH/RFA] sim autoconf conversion fallout
@ 2005-01-17 2:28 Paul Schlie
0 siblings, 0 replies; 6+ messages in thread
From: Paul Schlie @ 2005-01-17 2:28 UTC (permalink / raw)
To: Mark Kettenis; +Cc: gdb
Mark Kettenis wrote:
> ...
> * The --enable-sim option is essentially a no-op now, since all
> ...
Nice, might it also be possible to --enable/disable-XXX for
other similar sub-directories within a unified tree, such as:
rda, sid, (and I believe libgloss, which I recall tries to build
although although --without-newlib may have been specified)?
[ or how should this be properly requested? ]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-01-19 10:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-16 19:26 [PATCH/RFA] sim autoconf conversion fallout Mark Kettenis
2005-01-18 20:07 ` Andrew Cagney
2005-01-18 20:35 ` Mark Kettenis
2005-01-18 21:05 ` Andrew Cagney
2005-01-19 10:05 ` Richard Earnshaw
2005-01-17 2:28 Paul Schlie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).