From: Craig Jeffree <craig.jeffree@preston.net>
To: Bob Rossi <bob@brasko.net>
Cc: gdb@sources.redhat.com
Subject: Re: trouble locating source files through relative paths
Date: Wed, 24 Aug 2005 06:55:00 -0000 [thread overview]
Message-ID: <1124866437.3749.75.camel@norman> (raw)
In-Reply-To: <20050823114028.GB27899@white>
On Tue, 2005-08-23 at 07:40 -0400, Bob Rossi wrote:
> I'll look into this.
It looks like find_and_open_source() could be modified to check if
dirname is relative and if so call openp with dirname prepended to
filename instead of modifying the search path.
I think this is what Dave Korn suggested earlier, except he proposes
identifying the relative link before the call to find_and_open_source
and avoiding the split at that point. However, this might result in
checks occuring in multiple places - I haven't looked for this.
I'm not familiar with the gdb source so I'm not sure which solution will
be more appropriate. Putting the fix in find_and_open_source() would be
more self contained, however this might affect other clients of
find_and_open_source() in ways I haven't considered.
Cheers,
Craig.
next prev parent reply other threads:[~2005-08-24 6:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-19 7:25 Craig Jeffree
2005-08-19 12:43 ` Bob Rossi
2005-08-23 5:04 ` Craig Jeffree
2005-08-23 9:20 ` Dave Korn
2005-08-23 11:31 ` Bob Rossi
2005-08-23 11:40 ` Bob Rossi
2005-08-23 14:49 ` Daniel Jacobowitz
2005-08-23 15:24 ` Bob Rossi
2005-08-24 6:55 ` Craig Jeffree [this message]
2005-08-24 11:24 ` Bob Rossi
2005-08-25 0:07 ` Craig Jeffree
2005-08-25 13:14 ` Bob Rossi
2005-08-25 23:43 ` Craig Jeffree
2005-08-26 2:20 ` Bob Rossi
2005-08-26 3:35 ` Craig Jeffree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1124866437.3749.75.camel@norman \
--to=craig.jeffree@preston.net \
--cc=bob@brasko.net \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).