public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@specifix.com>
To: Jim Blandy <jimb@codesourcery.com>
Cc: Vladimir Prus <ghost@cs.msu.su>, gdb@sources.redhat.com
Subject: Re: Unnecessary thread_db message?
Date: Thu, 18 Oct 2007 05:39:00 -0000	[thread overview]
Message-ID: <1192685758.25099.92.camel@localhost.localdomain> (raw)
In-Reply-To: <m3przdny0a.fsf@codesourcery.com>

On Wed, 2007-10-17 at 16:04 -0700, Jim Blandy wrote:
> Vladimir Prus <ghost at cs.msu.su> writes:
> > Over in linux-thread-db.c, there's code like this:
> >
> > 	void
> > 	check_for_thread_db (void)
> > 	{
> > 	  /* First time through, report that libthread_db was successfuly
> > 	     loaded.  Can't print this in in thread_db_load as, at that stage,
> > 	     the interpreter and it's console haven't started.  */
> > 	
> > 	  if (!already_loaded)
> > 	    {
> > 		printf_unfiltered (_("Using host libthread_db library \"%s\".\n"),
> > 				 library);
> >
> >
> > The printf is totally unconditional. When gdb is started with the --quiet option,
> > this line is the only thing printed. The problem is that this message means nothing
> > to ordinary user -- he does not know what's thread_db is, and possibly has no idea
> > if, say, "/lib/tls/i686/cmov/libthread_db.so.1" is the right library to load.
> > This message seems more like debug print -- so can we print it only when some
> > verbose flag is set?
> 
> At least.  I don't think it should be printed at all --- there could
> be an 'info' subcommand to show this kind of information, but as you
> say, it's not something the user normally cares about.

Yeah, seems like the notification-worthy event would be if it
*fails* to find or connect to the library.  So long as that case
is covered, we could maybe conditionalize this one on info_verbose.

Hey, you ask for verbose, you're gonna get verbose.  Don't see
a reason to eliminate it entirely...




      reply	other threads:[~2007-10-18  5:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-17  7:32 Vladimir Prus
2007-10-17 23:04 ` Jim Blandy
2007-10-18  5:39   ` Michael Snyder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1192685758.25099.92.camel@localhost.localdomain \
    --to=msnyder@specifix.com \
    --cc=gdb@sources.redhat.com \
    --cc=ghost@cs.msu.su \
    --cc=jimb@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).