From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 1F76F3840C0D; Fri, 29 May 2020 13:56:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1F76F3840C0D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mliska@suse.cz X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 040D7AF4F; Fri, 29 May 2020 13:56:50 +0000 (UTC) Subject: Re: Auto update ChangeLog for binutils+gdb commits? To: Tom Tromey Cc: "H.J. Lu" , Simon Marchi , GDB , Binutils References: <891ef86a-a47f-18f2-c6bd-e525719e3768@simark.ca> <9492d857-c259-1429-f1c7-31a6dbf6510f@simark.ca> <1fb47dab-7a52-524b-17a3-672122277a48@suse.cz> <87tuzzaqey.fsf@tromey.com> <87o8q6c3m9.fsf@tromey.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <12ea10a1-59c1-5858-4619-ed3b40121d30@suse.cz> Date: Fri, 29 May 2020 15:56:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87o8q6c3m9.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_SHORT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2020 13:56:53 -0000 On 5/29/20 2:44 PM, Tom Tromey wrote: > Martin> For generation of ChangeLog template, you can use: > Martin> https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=contrib/mklog.py;h=243edbb15c522169709902b27a8558c6e0755107;hb=HEAD > > Can it be used without manual intervention? > Or do I still have to edit in all the function names? One only needs to describe what's purpose of a change. > Could you run it on some recent gdb commits and show the output? Sure: $ git format-patch -1 2b2558bfacba3813863da6728c021eb89fa34677 && ~/Programming/gcc/contrib/mklog.py 00* 0001-Move-DWARF-constant-stringifying-code-to-new-file.patch ChangeLog: * gdb/ChangeLog: * gdb/Makefile.in: * gdb/dwarf2/read.c (dwarf_tag_name): (dwarf_attr_name): (dwarf_form_name): (dwarf_bool_name): (dwarf_type_encoding_name): (dwarf_unknown): * gdb/dwarf2/stringify.c: New file. * gdb/dwarf2/stringify.h: New file. > > Martin> About the merges: it's a pain to make a backport (a.k.a) as you're very likely > Martin> conflict in ChangeLog entries. Having the ChangeLog entries in message one > Martin> can do simple git cherry-pick and it's done. > > This is emphatically not the case for me. > > Martin> About the date-updating: it's also pain to always update a timestamp before > Martin> a patch is installed. > > What I'm saying is that it isn't a pain. It's a single command before > pushing. I can't remember the last time the scripts failed but it's > surely been more than 5 years. > > I write a lot of patches in gdb and I have already filed off as many > annoying parts as I could -- which is why my default stance is not to > want to change. Changing implies that maybe I'd have to redo this work. Sure. You're a skilled GDB developer with long experience. But for newcomers or people without the scripts, this can simplify their workflow. Martin > > Tom >