From: Elena Zannoni <ezannoni@redhat.com>
To: Joern Rennecke <joern.rennecke@superh.com>
Cc: Elena Zannoni <ezannoni@redhat.com>,
Fernando Nasser <fnasser@redhat.com>,
gdb@sources.redhat.com, gdb-patches@sources.redhat.com
Subject: Re: sh-elf disassembly broken (Was: Re: RFC: Moving disassembler_command to cli land and using newer disassembler code)
Date: Mon, 24 Feb 2003 22:11:00 -0000 [thread overview]
Message-ID: <15962.39295.90201.236800@localhost.redhat.com> (raw)
In-Reply-To: <3E5A9781.7B68A30A@superh.com>
Joern Rennecke writes:
> Elena Zannoni wrote:
> >
> > Joern, would something like this work, instead?
> > Index: sh-tdep.c
> > ===================================================================
> > RCS file: /cvs/uberbaum/gdb/sh-tdep.c,v
> > retrieving revision 1.96
> > diff -u -p -r1.96 sh-tdep.c
> > --- sh-tdep.c 3 Feb 2003 14:38:05 -0000 1.96
> > +++ sh-tdep.c 24 Feb 2003 21:48:59 -0000
> > @@ -937,6 +937,7 @@ sh_store_struct_return (CORE_ADDR addr,
> > static int
> > gdb_print_insn_sh (bfd_vma memaddr, disassemble_info *info)
> > {
> > + info->mach = gdbarch_bfd_arch_info (current_gdbarch)->mach;
> > info->endian = TARGET_BYTE_ORDER;
> > return print_insn_sh (memaddr, info);
> > }
> >
>
> It looks like it should work for the way disassembling is used
> right now, but it would mean that we don't honour the setting
> of mach in the input parameter. So if you want to add a command
> that disassembles a region of memory assuming another machine
> setting than the current one, you'd be out of luck.
Oh, I see, I guess you have such a command. In any case, I'll commit
this, so at least it works right now, vanilla flavor.
elena
>
> --
> --------------------------
> SuperH (UK) Ltd.
> 2410 Aztec West / Almondsbury / BRISTOL / BS32 4QX
> T:+44 1454 465658
next prev parent reply other threads:[~2003-02-24 22:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-13 20:20 Joern Rennecke
2003-02-24 20:23 ` Joern Rennecke
2003-02-24 21:49 ` Elena Zannoni
2003-02-24 22:07 ` Joern Rennecke
2003-02-24 22:11 ` Elena Zannoni [this message]
2003-03-07 18:01 ` Joern Rennecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15962.39295.90201.236800@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=fnasser@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=gdb@sources.redhat.com \
--cc=joern.rennecke@superh.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).