From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26214 invoked by alias); 24 Feb 2003 22:11:29 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 26198 invoked from network); 24 Feb 2003 22:11:28 -0000 Received: from unknown (HELO mx1.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 24 Feb 2003 22:11:28 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h1OMBSe13357; Mon, 24 Feb 2003 17:11:28 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h1OMBSq20467; Mon, 24 Feb 2003 17:11:28 -0500 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h1OMBOI14859; Mon, 24 Feb 2003 17:11:24 -0500 Received: by localhost.redhat.com (Postfix, from userid 469) id 3F5C6FF79; Mon, 24 Feb 2003 17:15:27 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15962.39295.90201.236800@localhost.redhat.com> Date: Mon, 24 Feb 2003 22:11:00 -0000 To: Joern Rennecke Cc: Elena Zannoni , Fernando Nasser , gdb@sources.redhat.com, gdb-patches@sources.redhat.com Subject: Re: sh-elf disassembly broken (Was: Re: RFC: Moving disassembler_command to cli land and using newer disassembler code) In-Reply-To: <3E5A9781.7B68A30A@superh.com> References: <3E231F8E.72AA3D4A@superh.com> <3E5A7F58.8C87B17D@superh.com> <15962.37967.484158.441126@localhost.redhat.com> <3E5A9781.7B68A30A@superh.com> X-SW-Source: 2003-02/txt/msg00531.txt.bz2 Joern Rennecke writes: > Elena Zannoni wrote: > > > > Joern, would something like this work, instead? > > Index: sh-tdep.c > > =================================================================== > > RCS file: /cvs/uberbaum/gdb/sh-tdep.c,v > > retrieving revision 1.96 > > diff -u -p -r1.96 sh-tdep.c > > --- sh-tdep.c 3 Feb 2003 14:38:05 -0000 1.96 > > +++ sh-tdep.c 24 Feb 2003 21:48:59 -0000 > > @@ -937,6 +937,7 @@ sh_store_struct_return (CORE_ADDR addr, > > static int > > gdb_print_insn_sh (bfd_vma memaddr, disassemble_info *info) > > { > > + info->mach = gdbarch_bfd_arch_info (current_gdbarch)->mach; > > info->endian = TARGET_BYTE_ORDER; > > return print_insn_sh (memaddr, info); > > } > > > > It looks like it should work for the way disassembling is used > right now, but it would mean that we don't honour the setting > of mach in the input parameter. So if you want to add a command > that disassembles a region of memory assuming another machine > setting than the current one, you'd be out of luck. Oh, I see, I guess you have such a command. In any case, I'll commit this, so at least it works right now, vanilla flavor. elena > > -- > -------------------------- > SuperH (UK) Ltd. > 2410 Aztec West / Almondsbury / BRISTOL / BS32 4QX > T:+44 1454 465658