From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-21017-listarch-gdb=sources.redhat.com@sources.redhat.com>
Received: (qmail 29238 invoked by alias); 26 Mar 2005 14:27:29 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 29172 invoked from network); 26 Mar 2005 14:27:20 -0000
Received: from unknown (HELO cuddles.cambridge.redhat.com) (82.16.12.40)
  by sourceware.org with SMTP; 26 Mar 2005 14:27:20 -0000
Received: from littlepinkcloud.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id j2QERAf2029904;
	Sat, 26 Mar 2005 14:27:11 GMT
Received: (from aph@localhost)
	by littlepinkcloud.com (8.12.8/8.12.8/Submit) id j2QER9gU029900;
	Sat, 26 Mar 2005 14:27:09 GMT
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16965.28989.543273.976317@cuddles.cambridge.redhat.com>
Date: Sat, 26 Mar 2005 14:27:00 -0000
From: Andrew Haley <aph@redhat.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gcc-patches@gcc.gnu.org, binutils@sourceware.org, gdb@sourceware.org
Subject: Re: [PATCH/libiberty] Add missing <sys/types.h> in unlink-if-ordinary.c
In-Reply-To: <200503261421.j2QEL6ll019253@elgar.sibelius.xs4all.nl>
References: <200503261421.j2QEL6ll019253@elgar.sibelius.xs4all.nl>
X-SW-Source: 2005-03/txt/msg00244.txt.bz2

Mark Kettenis writes:
 > One really shouldn't include <sys/stat.h> without <sys/types.h> on
 > BSD-derived systems.  On most modern BSD's it is brought in by
 > <unistd.h> but vax-dec-ultrix4.0 doesn't have one, so things break.
 > The attached patch fixes that.
 > 

You must wrap this in #ifdef HAVE_SYS_TYPES_H

Andrew.


 > 
 > Index: ChangeLog
 > from  Mark Kettenis  <kettenis@gnu.org>
 > 
 > 	* unlink-if-ordinary.c: Include <sys/types.h>.
 > 
 > Index: unlink-if-ordinary.c
 > ===================================================================
 > RCS file: /cvs/src/src/libiberty/unlink-if-ordinary.c,v
 > retrieving revision 1.1
 > diff -u -p -r1.1 unlink-if-ordinary.c
 > --- unlink-if-ordinary.c 1 Mar 2005 14:33:00 -0000 1.1
 > +++ unlink-if-ordinary.c 26 Mar 2005 14:18:20 -0000
 > @@ -39,6 +39,8 @@ was made to unlink the file because it i
 >  #include "config.h"
 >  #endif
 >  
 > +#include <sys/types.h>
 > +
 >  #ifdef HAVE_UNISTD_H
 >  #include <unistd.h>
 >  #endif