From: Bruno Larsen <blarsen@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>, Simon Marchi <simark@simark.ca>
Cc: gdb@sourceware.org
Subject: Re: Proposal: Add review tags to patch review workflow.
Date: Mon, 10 Oct 2022 11:27:03 +0200 [thread overview]
Message-ID: <1c95e1f9-db82-a60e-7d4d-21eaea4435db@redhat.com> (raw)
In-Reply-To: <834jwelc26.fsf@gnu.org>
On 08/10/2022 14:44, Eli Zaretskii wrote:
>> Date: Sat, 8 Oct 2022 07:55:00 -0400
>> Cc: blarsen@redhat.com, gdb@sourceware.org
>> From: Simon Marchi <simark@simark.ca>
>>
>>
>>
>> On 2022-10-08 02:23, Eli Zaretskii wrote:
>>>> Date: Fri, 7 Oct 2022 16:46:23 -0400
>>>> From: Simon Marchi via Gdb <gdb@sourceware.org>
>>>>
>>>> We don't really have a formal process for voting / adopting proposals
>>>> like this. Given there was no negative feedback at all (from what I
>>>> remember), please go ahead and update the wiki. I will try to remember
>>>> to use the tags from now on.
>>> It would help if the new rules for using the tags were posted here as
>>> well, I think. Then, if someone has questions or wants to request
>>> clarifications, they could do that right away, instead of waiting
>>> until the first time they need to use the new rules.
>> They were explained in Bruno's original message, and Bruno will add them
>> to the wiki.
> They were followed by discussion and some changes, AFAIR. Also, the
> original post was quite long, so I hoped for a concise version akin a
> cookbook.
>
As Simon mentioned, there weren't big changes, but here's a quick cookbook:
1. If you have the authority to approve a patch and believe the patch
you are reviewing is ready to be merged, add the following line to your
e-mail (usually at the end): Approved-by: Your Name <your_email@example.com>
2. If you don't have the authority to approve patches, or aren't
convinced that you know enough about the area of code to fully approve a
patch for merging, and haven't found any technical issues (i.e.
non-nitpicks) with the patch, add the following line to your e-mail:
Reviewed-by: Your Name <your_email@example.com>
3. If you aren't sure of the quality of the technical changes, but you
have tested and verified that the patch does not add any regressions,
add the following line to your e-mail: Tested-by: Your Name
<your_name@example.com>
I hope this clears up any confusion!
Cheers,
Bruno
next prev parent reply other threads:[~2022-10-10 9:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 11:04 Bruno Larsen
2022-09-25 22:38 ` Lancelot SIX
2022-09-26 13:55 ` Simon Marchi
2022-09-26 16:42 ` Joel Brobecker
2022-09-27 8:39 ` Luis Machado
2022-09-27 8:42 ` Luis Machado
2022-09-27 9:38 ` Lancelot SIX
2022-09-27 21:07 ` Thiago Jung Bauermann
2022-09-26 21:32 ` John Baldwin
2022-09-27 8:06 ` Bruno Larsen
2022-09-27 12:02 ` Simon Marchi
2022-09-27 12:03 ` Bruno Larsen
2022-09-27 17:11 ` John Baldwin
2022-09-27 7:58 ` Bruno Larsen
2022-09-27 12:03 ` Simon Marchi
2022-09-26 15:59 ` Luis Machado
2022-09-26 16:32 ` Elena Zannoni
2022-09-27 8:30 ` Bruno Larsen
2022-09-27 20:50 ` Thomas Schwinge
2022-10-07 7:49 ` Bruno Larsen
2022-10-07 20:46 ` Simon Marchi
2022-10-08 6:23 ` Eli Zaretskii
2022-10-08 11:55 ` Simon Marchi
2022-10-08 12:44 ` Eli Zaretskii
2022-10-09 0:29 ` Simon Marchi
2022-10-10 9:27 ` Bruno Larsen [this message]
2022-10-10 9:47 ` Eli Zaretskii
2022-10-10 10:11 ` Bruno Larsen
2022-10-10 11:27 ` Eli Zaretskii
2022-10-10 12:31 ` Bruno Larsen
2022-10-10 13:14 ` Eli Zaretskii
2022-10-10 13:26 ` Bruno Larsen
2022-10-10 15:25 ` Eli Zaretskii
2022-10-10 13:34 ` Pedro Alves
2022-10-10 9:39 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c95e1f9-db82-a60e-7d4d-21eaea4435db@redhat.com \
--to=blarsen@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).