From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 754C138582A7 for ; Mon, 10 Oct 2022 09:27:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 754C138582A7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665394027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k/3RPuO11v/mZ5mJpDpa1e4zYgPAB3/eGe5IrWi1YsA=; b=RSHPzN2yJQZ87+gXIdtHs7rZY5IIH9vqu5CBVUrykx0ZIWT3SbOUh3b+sAhV3kfl0axIip MkA8VRBmagww7v74daR/IPcovWqIpQZB6xD3faagFrSGRhhL4UCD5xFPGJ7zvNFIVAKJgQ erNfnDtf5A8nHi4NgXeosYOQs1aZ+Vk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-170-lQeyDy_qM_OC4aRNTINr8Q-1; Mon, 10 Oct 2022 05:27:06 -0400 X-MC-Unique: lQeyDy_qM_OC4aRNTINr8Q-1 Received: by mail-wr1-f71.google.com with SMTP id s5-20020adf9785000000b0022e1af0e7e8so2548903wrb.11 for ; Mon, 10 Oct 2022 02:27:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k/3RPuO11v/mZ5mJpDpa1e4zYgPAB3/eGe5IrWi1YsA=; b=6q9Ps0LfGaEfjbmqmk6A3rGM0YHcNGvPB5b4yIl6bwAjJvErzz5sldIatfjPtznwSx YfFI8V7IK676xeM3wpydMsy6BTm5ZrOwn75njG82chuw1HwAvlVi7O9b6zDrJvOJq4SE HpwIQoa7h1btvlTVvtrWm9C9rcP39Ezcpe6pE3iSvALkCeCGuIQTGV9a4XFT5u86qMON WQlwdX60jIqcJDyCEVrcFaN9TW/JS9IsOiZ8MlNB/Rx7r9Suc2wx4DImCrugVubypS5c sqQU7g9sWucffkemiAS/ELMn7E3x3x7S7TZ2+VBJT+c3wE0nQtkDbAL7plEG1hXTo4OB 4VFA== X-Gm-Message-State: ACrzQf1apn2V/aPJAHvehQLMKFjCkRZSdV0DLum+COEdyzR7Rxa8ZyBu j1hLcaqNSAA/bVhIOSdOshfdeCiL32y0CvJQU/OoWAf9xM71ShqJnZVTWjPwfhcaaCErYEXBM/1 FcH83ZaScLYo= X-Received: by 2002:a5d:4745:0:b0:22e:3521:a557 with SMTP id o5-20020a5d4745000000b0022e3521a557mr10395557wrs.125.1665394024627; Mon, 10 Oct 2022 02:27:04 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7xXdOYBhSpbKUWfmX9KSUL51QAK/miLgOox9l4zsdzanvJaJ5c9qF8om8g6D06SDlJIKanFw== X-Received: by 2002:a5d:4745:0:b0:22e:3521:a557 with SMTP id o5-20020a5d4745000000b0022e3521a557mr10395547wrs.125.1665394024398; Mon, 10 Oct 2022 02:27:04 -0700 (PDT) Received: from [10.43.2.105] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id i15-20020adffdcf000000b00223b8168b15sm8423470wrs.66.2022.10.10.02.27.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 02:27:03 -0700 (PDT) Message-ID: <1c95e1f9-db82-a60e-7d4d-21eaea4435db@redhat.com> Date: Mon, 10 Oct 2022 11:27:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: Proposal: Add review tags to patch review workflow. To: Eli Zaretskii , Simon Marchi Cc: gdb@sourceware.org References: <754258e5-b9b7-0785-5580-f8f54e7ad6ad@simark.ca> <83y1tqltpp.fsf@gnu.org> <790305bd-9cdf-9dbc-6b8e-b55f1f70258f@simark.ca> <834jwelc26.fsf@gnu.org> From: Bruno Larsen In-Reply-To: <834jwelc26.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,OBFU_UNSUB_UL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08/10/2022 14:44, Eli Zaretskii wrote: >> Date: Sat, 8 Oct 2022 07:55:00 -0400 >> Cc: blarsen@redhat.com, gdb@sourceware.org >> From: Simon Marchi >> >> >> >> On 2022-10-08 02:23, Eli Zaretskii wrote: >>>> Date: Fri, 7 Oct 2022 16:46:23 -0400 >>>> From: Simon Marchi via Gdb >>>> >>>> We don't really have a formal process for voting / adopting proposals >>>> like this. Given there was no negative feedback at all (from what I >>>> remember), please go ahead and update the wiki. I will try to remember >>>> to use the tags from now on. >>> It would help if the new rules for using the tags were posted here as >>> well, I think. Then, if someone has questions or wants to request >>> clarifications, they could do that right away, instead of waiting >>> until the first time they need to use the new rules. >> They were explained in Bruno's original message, and Bruno will add them >> to the wiki. > They were followed by discussion and some changes, AFAIR. Also, the > original post was quite long, so I hoped for a concise version akin a > cookbook. > As Simon mentioned, there weren't big changes, but here's a quick cookbook: 1. If you have the authority to approve a patch and believe the patch you are reviewing is ready to be merged, add the following line to your e-mail (usually at the end): Approved-by: Your Name 2. If you don't have the authority to approve patches, or aren't convinced that you know enough about the area of code to fully approve a patch for merging, and haven't found any technical issues (i.e. non-nitpicks) with the patch, add the following line to your e-mail: Reviewed-by: Your Name 3. If you aren't sure of the quality of the technical changes, but you have tested and verified that the patch does not add any regressions, add the following line to your e-mail: Tested-by: Your Name I hope this clears up any confusion! Cheers, Bruno