From: Daniel Jacobowitz <drow@mvista.com>
To: gdb@sources.redhat.com
Cc: ac131313@ges.redhat.com
Subject: Re: RFC: Two small remote protocol extensions
Date: Fri, 16 Aug 2002 07:30:00 -0000 [thread overview]
Message-ID: <20020816143040.GA22041@nevyn.them.org> (raw)
In-Reply-To: <20020502022543.GA22594@nevyn.them.org>
On Wed, May 01, 2002 at 10:25:43PM -0400, Daniel Jacobowitz wrote:
> In making remote thread debugging work on GNU/Linux, I needed two additions
> to the remote protocol. Neither is strictly necessary, but both are useful,
> IMHO.
>
> They are:
>
> - two new replies to the continue/step packets, 'n' and 'x'. They
> indicate thread creation and death respectively, and are asynchronous;
> the target is not stopped when they are sent.
This one got shouted down, I'm not going to bring it up again.
> - A new 'Hs' packet, paralleling Hc and Hg. This sets the "step" thread.
This one, however, needs feedback. A user just reported a bogus
SIGTRAP bug to me which is fixed by the above.
To elaborate on the problem: right now we have two ways of specifying a
thread to the remote agent. Hg specifies the "general" thread, and Hc
specifies the "continue" thread. These correspond to inferior_ptid and
resume_ptid, roughly.
When we single-step, if we are not using some form of
scheduler-locking, resume_ptid is 0. We don't tell the agent at that
point what inferior_ptid is; it has to step _some_ thread, and it picks
one, and if it doesn't pick the one GDB expected we get problems.
We need to either:
- Communicate inferior_ptid via Hg at this time
- Communicate inferior_ptid via a new Hs explicitly
I think the former makes sense. Here's a patch; what do you think of
it? Also included is the patch for gdbserver; I'd send a separate
patch along afterwards to remove the vestiges of Hs from my testing,
which escaped in the original threads patch.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
2002-08-16 Daniel Jacobowitz <drow@mvista.com>
* remote.c (remote_resume): Also send inferior_ptid.
2002-08-16 Daniel Jacobowitz <drow@mvista.com>
* target.c (set_desired_inferior): Respect general_thread
if cont_thread is 0 or -1.
Index: remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.91
diff -u -p -r1.91 remote.c
--- remote.c 9 Aug 2002 16:41:24 -0000 1.91
+++ remote.c 16 Aug 2002 14:26:51 -0000
@@ -2616,8 +2616,13 @@ remote_resume (ptid_t ptid, int step, en
{
struct remote_state *rs = get_remote_state ();
char *buf = alloca (rs->remote_packet_size);
- int pid = PIDGET (ptid);
+ int pid = PIDGET (ptid), inf_pid = PIDGET (inferior_ptid);
char *p;
+
+ if (inf_pid == -1)
+ set_thread (0, 1);
+ else
+ set_thread (inf_pid, 1);
if (pid == -1)
set_thread (0, 0); /* run any thread */
Index: gdbserver/target.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/target.c,v
retrieving revision 1.3
diff -u -p -r1.3 target.c
--- gdbserver/target.c 11 Jun 2002 17:32:40 -0000 1.3
+++ gdbserver/target.c 16 Aug 2002 14:26:51 -0000
@@ -46,6 +46,10 @@ set_desired_inferior (int use_general)
found = (struct thread_info *) find_inferior_id (&all_threads,
step_thread);
+ if (general_thread > 0 && (cont_thread == 0 || cont_thread == -1))
+ found = (struct thread_info *) find_inferior_id (&all_threads,
+ general_thread);
+
if (found == NULL)
found = (struct thread_info *) find_inferior_id (&all_threads,
cont_thread);
next prev parent reply other threads:[~2002-08-16 14:30 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-01 19:25 Daniel Jacobowitz
2002-05-02 8:38 ` Andrew Cagney
2002-05-02 8:52 ` Daniel Jacobowitz
2002-05-02 9:39 ` Andrew Cagney
2002-05-02 12:14 ` Daniel Jacobowitz
2002-05-02 12:22 ` Kevin Buettner
2002-05-02 12:34 ` Daniel Jacobowitz
2002-05-02 13:13 ` Andrew Cagney
2002-05-02 14:09 ` Daniel Jacobowitz
2002-05-03 11:24 ` Andrew Cagney
2002-05-03 14:28 ` Daniel Jacobowitz
2002-05-03 15:18 ` Andrew Cagney
2002-05-03 15:22 ` Daniel Jacobowitz
2002-05-04 19:59 ` Andrew Cagney
2002-05-02 13:13 ` Quality Quorum
2002-05-02 14:13 ` Daniel Jacobowitz
2002-05-03 13:07 ` Andrew Cagney
2002-08-16 7:30 ` Daniel Jacobowitz [this message]
2002-08-16 7:42 ` Andrew Cagney
2002-08-16 7:52 ` Daniel Jacobowitz
2002-08-16 8:21 ` Andrew Cagney
2002-08-22 19:23 ` Andrew Cagney
2002-08-22 19:36 ` Daniel Jacobowitz
2002-08-23 7:24 ` Quality Quorum
2002-08-23 7:26 ` Daniel Jacobowitz
2002-08-23 7:49 ` Quality Quorum
2002-08-23 8:57 ` Andrew Cagney
2002-08-23 11:16 ` Quality Quorum
2002-08-23 12:39 ` Andrew Cagney
2002-08-23 13:10 ` Quality Quorum
2002-08-27 20:23 ` Andrew Cagney
2002-08-28 8:31 ` Quality Quorum
2002-08-28 9:44 ` Andrew Cagney
2002-08-28 9:49 ` Daniel Jacobowitz
2002-08-22 21:08 ` Andrew Cagney
2002-08-23 5:44 ` Daniel Jacobowitz
2002-08-23 12:10 ` Andrew Cagney
2002-08-23 12:53 ` Andrew Cagney
2002-08-23 13:15 ` Daniel Jacobowitz
2002-08-27 21:07 ` Andrew Cagney
2002-08-28 6:33 ` Daniel Jacobowitz
2002-09-25 8:51 ` Daniel Jacobowitz
2002-09-25 11:17 ` Andrew Cagney
2002-09-26 18:39 ` Andrew Cagney
2002-09-26 18:48 ` Andrew Cagney
2003-06-29 7:51 ` Daniel Jacobowitz
2003-09-03 23:41 ` Andrew Cagney
2003-09-17 15:51 ` Daniel Jacobowitz
2003-09-17 16:19 ` Andrew Cagney
2003-09-17 16:23 ` Daniel Jacobowitz
2003-09-22 0:27 ` Andrew Cagney
2003-09-22 1:01 ` Daniel Jacobowitz
2003-09-22 3:02 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020816143040.GA22041@nevyn.them.org \
--to=drow@mvista.com \
--cc=ac131313@ges.redhat.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).